Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bando / ghost edge #917

Merged
merged 5 commits into from
May 2, 2020
Merged

Bando / ghost edge #917

merged 5 commits into from
May 2, 2020

Conversation

AboudyKreidieh
Copy link
Member

Pull request information

  • Status: ? (ready to merge / in development)
  • Kind of changes: ? (bug fix / new feature / documentation...)
  • Related PR or issue: ? (optional)

Description

? (general description)

@AboudyKreidieh AboudyKreidieh changed the title Bando ghost edge Bando / ghost edge Apr 30, 2020
Copy link
Member

@eugenevinitsky eugenevinitsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And tests?! LGTM.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5825

  • 106 of 107 (99.07%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 89.546%

Changes Missing Coverage Covered Lines Changed/Added Lines %
flow/controllers/car_following_models.py 23 24 95.83%
Totals Coverage Status
Change from base Build 5755: 0.09%
Covered Lines: 9431
Relevant Lines: 10532

💛 - Coveralls

@AboudyKreidieh AboudyKreidieh merged commit 86761a6 into master May 2, 2020
@AboudyKreidieh AboudyKreidieh deleted the bando-ghost-edge branch May 2, 2020 09:51
brentgryffindor pushed a commit that referenced this pull request May 18, 2020
* added bando model

* added ghost edge to the highway network

* added highway-single example

* bug fixes

* more tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants