Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmark fix #919

Merged
merged 3 commits into from
May 4, 2020
Merged

Benchmark fix #919

merged 3 commits into from
May 4, 2020

Conversation

eugenevinitsky
Copy link
Member

  • Reward function was incorrect for grid
  • Bottleneck was not in the congested regime.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5833

  • 9 of 10 (90.0%) changed or added relevant lines in 6 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 89.532%
Changes Missing Coverage Covered Lines Changed/Added Lines %
flow/envs/traffic_light_grid.py 4 5 80.0%
Files with Coverage Reduction New Missed Lines %
flow/envs/traffic_light_grid.py 1 90.22%
Totals Coverage Status
Change from base Build 5826: -0.01%
Covered Lines: 9434
Relevant Lines: 10537
💛 - Coveralls

AboudyKreidieh
AboudyKreidieh approved these changes May 4, 2020
View reviewed changes
Copy link
Member

@AboudyKreidieh AboudyKreidieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AboudyKreidieh AboudyKreidieh merged commit a26c9b7 into master May 4, 2020
@AboudyKreidieh AboudyKreidieh deleted the benchmark_fix branch May 4, 2020 06:47
brentgryffindor pushed a commit that referenced this pull request May 18, 2020
@eugenevinitsky @brentgryffindor
Benchmark fix (#919)
bb3c14c 
* Add the appropriate reward to the grid benchmark back

* Put the bottleneck in a congested regime

* Bump bottleneck inflows to put it in the congested regime
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AboudyKreidieh AboudyKreidieh AboudyKreidieh approved these changes

@cathywu cathywu Awaiting requested review from cathywu

@kanaadp kanaadp Awaiting requested review from kanaadp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eugenevinitsky @coveralls @AboudyKreidieh