Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network update #953

Merged
merged 99 commits into from
May 28, 2020
Merged
Show file tree
Hide file tree
Changes from 96 commits
Commits
Show all changes
99 commits
Select commit Hold shift + click to select a range
2c85838
Added QMIX but its hella slow right now
eugenevinitsky Mar 28, 2020
ea470a3
Speedup
eugenevinitsky Mar 28, 2020
58f357c
Replace QMIX reward w global reward
eugenevinitsky Mar 28, 2020
99f6c09
Disable RNN
eugenevinitsky Mar 28, 2020
942fe56
Add an option for a local reward that just computes speed of the AV a…
eugenevinitsky Mar 29, 2020
562bb0f
Merge branch 'i210_dev_fix' into i210_qmix
eugenevinitsky Mar 29, 2020
5c165fe
Make speed square of rewards
eugenevinitsky Apr 6, 2020
29d16bb
Add QMIX and MADDPG
eugenevinitsky Apr 7, 2020
0edfec6
Turn on RNN
eugenevinitsky Apr 7, 2020
9d6344f
Increase inflow in i210 subnetwork
eugenevinitsky Apr 7, 2020
7ed7377
Merge pull request #880 from flow-project/time_space_fixes
kjang96 Apr 9, 2020
95e63a8
moved imports under functions in train.py (#903)
chendiw Apr 21, 2020
f3e7ce8
Add option to reroute exiting vehicles back into the network
eugenevinitsky Apr 30, 2020
3600357
Change the position at which vehicles are rerouted so tall the vehicl…
eugenevinitsky Apr 30, 2020
86761a6
Bando / ghost edge (#917)
AboudyKreidieh May 2, 2020
fe05dcd
Add single agent case
eugenevinitsky May 3, 2020
a26c9b7
Benchmark fix (#919)
eugenevinitsky May 4, 2020
50be2d0
get not departed vehicles (#922)
Yasharzf May 8, 2020
72f8459
Address comments
eugenevinitsky May 8, 2020
304fcfc
Merge branch 'i210_dev' of github.com:flow-project/flow into rerouting
eugenevinitsky May 8, 2020
b80d441
Pydoc style
eugenevinitsky May 8, 2020
a93bf29
Merge branch 'i210_qmix' into flow_maddpg
eugenevinitsky May 9, 2020
7398f50
changed _departed_ids, and _arrived_ids in the update function (#926)
Yasharzf May 9, 2020
6c1ef8a
MADDPG is running but not training
eugenevinitsky May 9, 2020
73fe421
Minor
eugenevinitsky May 10, 2020
ff2ca54
But what if we just catch and ignore the exception
eugenevinitsky May 10, 2020
7d0dafa
Merge branch 'master' of github.com:flow-project/flow into flow_maddpg
eugenevinitsky May 10, 2020
adfde0e
Minor change to AMI to get sUMO version 1.1.0
eugenevinitsky May 10, 2020
0556175
Add MPG reward
eugenevinitsky May 10, 2020
1861051
Commit for local reward tests
eugenevinitsky May 10, 2020
2cd6329
Add a centralized critic
eugenevinitsky May 11, 2020
9a2a4a6
Add curricula over speed and headway
eugenevinitsky May 11, 2020
f1abcfe
add timing, remove adaptive KL from PPO
eugenevinitsky May 11, 2020
f9e573d
Minor fixes to KL
eugenevinitsky May 11, 2020
5605ec2
switch back to old AMI for testing purposes
eugenevinitsky May 11, 2020
e5437d3
Disable custom PPO for a sec
eugenevinitsky May 11, 2020
083aaee
Minor changes to centralized PPO to upgrade it to 0.9.0
eugenevinitsky May 12, 2020
ba3210f
Visuallizer rllib fixes for centralized PPO
eugenevinitsky May 12, 2020
3f4da91
Add the ability to look back in the platoon for the MPG reward
eugenevinitsky May 12, 2020
ad694c5
Minor
eugenevinitsky May 13, 2020
429df10
Add MPG reward
eugenevinitsky May 13, 2020
da5c054
Merge branch 'i210_dev' into mpg_reward2
eugenevinitsky May 13, 2020
76707c1
Flake8
eugenevinitsky May 13, 2020
4b615b4
Minor
eugenevinitsky May 13, 2020
ac8e206
Minor
eugenevinitsky May 14, 2020
2f823d8
Flake8
eugenevinitsky May 14, 2020
91f1498
Pydoc style
eugenevinitsky May 14, 2020
c783b09
Merge branch 'mpg_reward' into mpg_reward2
eugenevinitsky May 14, 2020
44d682c
Minor
eugenevinitsky May 14, 2020
1b3172e
Fix none condition handling
eugenevinitsky May 14, 2020
01cf922
Merge branch 'mpg_reward' into mpg_reward2
eugenevinitsky May 14, 2020
6d37f15
Minor
eugenevinitsky May 14, 2020
12c0f36
Downgrade to 0.8.0
eugenevinitsky May 15, 2020
d3e45b0
Merge branch 'mpg_reward2' into flow_maddpg
eugenevinitsky May 15, 2020
de4b21d
removed sweep
AboudyKreidieh May 16, 2020
62afe9c
added updated single lane highway network config
AboudyKreidieh May 16, 2020
b52d90a
added i210 xml files with downstream edge
AboudyKreidieh May 16, 2020
c370460
added I210Router
AboudyKreidieh May 16, 2020
4525a7a
added updated i210 features
AboudyKreidieh May 16, 2020
ed8506a
minor cleanup
AboudyKreidieh May 16, 2020
6c90517
better parameters based on when congestion propagates
AboudyKreidieh May 18, 2020
be0eb25
bug fixes
AboudyKreidieh May 18, 2020
bdcfb96
bug fixes
AboudyKreidieh May 18, 2020
34acd0b
Merge branch 'i210-highway-updated' of https://github.com/flow-projec…
AboudyKreidieh May 18, 2020
2892a80
more bug fixes
AboudyKreidieh May 18, 2020
3154f26
Add MPG reward (#931)
eugenevinitsky May 18, 2020
c7567b6
Fix gain on MPG
eugenevinitsky May 18, 2020
ba892f3
Merge straight road changes to multiagent straight road
eugenevinitsky May 19, 2020
20c24ed
Merge branch 'i210_dev' of github.com:flow-project/flow into ev_i210_…
eugenevinitsky May 19, 2020
c331817
Merge branch 'ev_i210_highway_updated' into flow_maddpg
eugenevinitsky May 19, 2020
00f114c
Add ability to control which lengths the control is applied on
eugenevinitsky May 20, 2020
231f04f
Move training iterations
eugenevinitsky May 21, 2020
c5a251e
Turn off mpj reward
eugenevinitsky May 21, 2020
5fb28b8
Minorg
eugenevinitsky May 21, 2020
a524f4d
Updated ray_autoscale and requirements.txt
kjang96 May 21, 2020
7f782b8
Reverted to original master's ray_autoscale.yaml and added 2 lines
kjang96 May 21, 2020
1895c4f
MPG w/ curriculum test
eugenevinitsky May 21, 2020
7772dfe
Add stop penalty
eugenevinitsky May 21, 2020
5c79a8a
Add accel_penalty
eugenevinitsky May 22, 2020
2232861
Address MacOS Catalina SegFault issue when running sumo-gui (#938)
cybermaster May 22, 2020
1e211cb
Merge pull request #941 from flow-project/slowdown_master
kjang96 May 22, 2020
45a8e0a
Fix to space time diagram to update to new highway network
eugenevinitsky May 24, 2020
cf579bf
Import georges I210 fixes
eugenevinitsky May 24, 2020
a43bf81
Merge branch 'ev/george_fixes' into flow_maddpg
eugenevinitsky May 24, 2020
9a5b532
Add ghost cell template with correct priorities
eugenevinitsky May 26, 2020
e6f7ef8
Update I210 to new model
eugenevinitsky May 26, 2020
2dfffc6
Add missing file
eugenevinitsky May 26, 2020
ce5710f
Merge branch 'master' of github.com:flow-project/flow into flow_maddpg
eugenevinitsky May 27, 2020
e400a38
Add handling of too many vehicles trying to reroute at once
eugenevinitsky May 27, 2020
3d95f2d
Minor
eugenevinitsky May 27, 2020
d4b76b1
Shorten curriculum iters
eugenevinitsky May 27, 2020
72eda14
Put back long curriculum
eugenevinitsky May 27, 2020
ca6a567
Remove MADDPG, QMIX
eugenevinitsky May 27, 2020
82a29fc
Merge branch 'i210_dev' into network_update
eugenevinitsky May 27, 2020
bbb16ff
Address comments
eugenevinitsky May 28, 2020
c311bf5
Merge branch 'network_update' of github.com:flow-project/flow into ne…
eugenevinitsky May 28, 2020
bb37992
Remove clipping so failsafes can be applied
eugenevinitsky May 28, 2020
c6949bc
Fix imports
eugenevinitsky May 28, 2020
3dd87d0
Fix on-ramp code
eugenevinitsky May 28, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions docs/source/flow_setup.rst
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,22 @@ If you are a Mac user and the above command gives you the error
``FXApp:openDisplay: unable to open display :0.0``, make sure to open the
application XQuartz.

*Troubleshooting*:
If you are a Mac user and the above command gives you the error
``Segmentation fault: 11``, make sure to reinstall ``fox`` using brew.
::

# Uninstall Catalina bottle of fox:
$ brew uninstall --ignore-dependencies fox

# Edit brew Formula of fox:
$ brew edit fox

# Comment out or delete the following line: sha256 "c6697be294c9a0458580564d59f8db32791beb5e67a05a6246e0b969ffc068bc" => :catalina
# Install Mojave bottle of fox:
$ brew install fox


Testing your SUMO and Flow installation
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Expand Down
12 changes: 8 additions & 4 deletions examples/exp_configs/non_rl/highway_single.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
"""Example of an open network with human-driven vehicles and a wave."""

import numpy as np

from flow.controllers import IDMController
Expand All @@ -10,8 +11,8 @@
from flow.core.params import VehicleParams
from flow.core.params import SumoParams
from flow.core.params import SumoLaneChangeParams
from flow.core.rewards import miles_per_gallon, miles_per_megajoule
from flow.core.params import SumoCarFollowingParams
from flow.core.rewards import miles_per_megajoule
from flow.networks import HighwayNetwork
from flow.envs import TestEnv
from flow.networks.highway import ADDITIONAL_NET_PARAMS
Expand All @@ -23,7 +24,7 @@
# the inflow rate of vehicles
TRAFFIC_FLOW = 2215
# the simulation time horizon (in steps)
HORIZON = 1500
HORIZON = 1000
# whether to include noise in the car-following models
INCLUDE_NOISE = True

Expand Down Expand Up @@ -64,13 +65,13 @@
),
)

inflows = InFlows()

if PENETRATION_RATE > 0.0:
vehicles.add(
"av",
color='red',
num_vehicles=0,
acceleration_controller=(FollowerStopper, {"v_des": 6.0}),
acceleration_controller=(FollowerStopper, {"v_des": 5.0, "control_length": [500, 2300]}),
)

inflows = InFlows()
Expand Down Expand Up @@ -145,5 +146,8 @@
env.k.vehicle.get_outflow_rate(120)),
"miles_per_megajoule": lambda env: np.nan_to_num(
miles_per_megajoule(env, env.k.vehicle.get_ids(), gain=1.0)
),
"miles_per_gallon": lambda env: np.nan_to_num(
miles_per_gallon(env, env.k.vehicle.get_ids(), gain=1.0)
)
}
Loading