Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Client eval service/endpoints #2408

Merged
merged 16 commits into from
Nov 21, 2023
Merged

feat: Client eval service/endpoints #2408

merged 16 commits into from
Nov 21, 2023

Conversation

markphelps
Copy link
Collaborator

Adds endpoints (both GRPC and REST) required for client eval

markphelps and others added 12 commits November 7, 2023 11:57
* chore(wip): gah

* feat(wip): snapshot api

* feat: finish proto server

* chore: fix linter errors

* chore: move

* chore: fix build

* chore: add ability to skip generating sdks

* chore: dont generate interface method

* chore: fix build

* fix: mount api

* chore: add namespace key to resp

* chore: detect boolean flag types

* chore: create own types for evaluation service

* chore: rm spaces

* chore: rename cmp type fields

---------

Co-authored-by: Yoofi Quansah <[email protected]>
* feat: initial commit for rust evaluator client side

* chore: rename of entire directory tree

* chore: write tests for all the matches constraints types

* chore: redo gitignore

* chore: format rust code

* chore: use generic instead of parameter impl

* chore: remove println! statement

* feat: support variant attachment as String type Rust

* feat: new engine logic

* chore: fix unwrap by using match instead

* chore: add boolean method to engine and format code

* feat: add request logic for getting document text from configurable upstream Flipt instance

* chore: apply cargo clippy updates

* feat: add three basic functions for allocating engine and retrieving it

* chore: remove TODO

* feat: modify code to adapt to endpoint

* chore: use environment variables to get update interval

* chore: remove unnecessary clone

* chore: add rust workspace

* chore: update enums

* chore: impl default for responses

* chore: make constants

* feat: Add changes for FFI boundaries and example code

---------

Co-authored-by: Mark Phelps <[email protected]>
* chore: refactor model layout; fix duration bug

* chore: rename get_duration to get_duration_millis
…#2358)

* feat: add initial commit for Python evaluation client using Rust core

* chore: fix README linting issue

* feat: move python source code and project under sdk

* chore: clean up Python client README.md and change ENGINE_LIB_PATH meaning

* chore: fix suggestions on PR
)

* feat: add integration style tests for evaluation

* feat: add evaluatortest parity with Golang evaluator on Rust core engine

* chore: use mockall as dev dependency and attribute TestParser as only being used during tests
* feat: add initial commit for flipt-client-go evaluation client

* chore: fix README.md

* chore: README updates based on suggestions

* chore: only support one namespace for Golang client

* chore: add to go.work
* chore: rm clients as they are moving to seperate repo

* chore: rm go client sdk
Copy link
Contributor

github-actions bot commented Nov 17, 2023

Uffizzi Ephemeral Environment deployment-41142

☁️ https://app.uffizzi.com/github.com/flipt-io/flipt/pull/2408

📄 View Application Logs etc.

⏰ This Preview will be destroyed in 1 hours at: Mon Nov 20 22:08:48 UTC 2023

What is Uffizzi? Learn more!

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (5d55e53) 70.82% compared to head (687213b) 70.76%.
Report is 1 commits behind head on main.

Files Patch % Lines
internal/cmd/http.go 0.00% 9 Missing ⚠️
internal/cmd/grpc.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2408      +/-   ##
==========================================
- Coverage   70.82%   70.76%   -0.07%     
==========================================
  Files          81       81              
  Lines        8103     8110       +7     
==========================================
  Hits         5739     5739              
- Misses       2018     2025       +7     
  Partials      346      346              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@markphelps markphelps merged commit 972f62c into main Nov 21, 2023
32 of 34 checks passed
@markphelps markphelps deleted the client-eval branch November 21, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants