Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Rm clients in monorepo #2407

Merged
merged 2 commits into from
Nov 17, 2023
Merged

chore: Rm clients in monorepo #2407

merged 2 commits into from
Nov 17, 2023

Conversation

markphelps
Copy link
Collaborator

we are gonna move them to a separate repo for continued development/distribution

Copy link
Contributor

github-actions bot commented Nov 16, 2023

Uffizzi Ephemeral Environment deployment-40931

☁️ https://app.uffizzi.com/github.com/flipt-io/flipt/pull/2407

📄 View Application Logs etc.

⏰ This Preview will be destroyed in 1 hours at: Thu Nov 16 21:32:25 UTC 2023

What is Uffizzi? Learn more!

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (94338fe) 70.82% compared to head (121c01a) 70.76%.
Report is 32 commits behind head on client-eval.

Files Patch % Lines
internal/cmd/http.go 0.00% 9 Missing ⚠️
internal/cmd/grpc.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           client-eval    #2407      +/-   ##
===============================================
- Coverage        70.82%   70.76%   -0.07%     
===============================================
  Files               81       81              
  Lines             8103     8110       +7     
===============================================
  Hits              5739     5739              
- Misses            2018     2025       +7     
  Partials           346      346              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@markphelps markphelps marked this pull request as ready for review November 16, 2023 21:52
@markphelps markphelps requested a review from a team as a code owner November 16, 2023 21:52
Copy link
Contributor

@yquansah yquansah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting code!

@markphelps markphelps merged commit 2354e52 into client-eval Nov 17, 2023
29 of 31 checks passed
@markphelps markphelps deleted the rm-clients branch November 17, 2023 14:38
markphelps added a commit that referenced this pull request Nov 21, 2023
* feat: Evaluation snapshot service (#2330)

* chore(wip): gah

* feat(wip): snapshot api

* feat: finish proto server

* chore: fix linter errors

* chore: move

* chore: fix build

* chore: add ability to skip generating sdks

* chore: dont generate interface method

* chore: fix build

* fix: mount api

* chore: add namespace key to resp

* chore: detect boolean flag types

* chore: create own types for evaluation service

* chore: rm spaces

* chore: rename cmp type fields

---------

Co-authored-by: Yoofi Quansah <[email protected]>

* feat: initial commit for rust evaluator client side (#2322)

* feat: initial commit for rust evaluator client side

* chore: rename of entire directory tree

* chore: write tests for all the matches constraints types

* chore: redo gitignore

* chore: format rust code

* chore: use generic instead of parameter impl

* chore: remove println! statement

* feat: support variant attachment as String type Rust

* feat: new engine logic

* chore: fix unwrap by using match instead

* chore: add boolean method to engine and format code

* feat: add request logic for getting document text from configurable upstream Flipt instance

* chore: apply cargo clippy updates

* feat: add three basic functions for allocating engine and retrieving it

* chore: remove TODO

* feat: modify code to adapt to endpoint

* chore: use environment variables to get update interval

* chore: remove unnecessary clone

* chore: add rust workspace

* chore: update enums

* chore: impl default for responses

* chore: make constants

* feat: Add changes for FFI boundaries and example code

---------

Co-authored-by: Mark Phelps <[email protected]>

* chore: engine model refactor (#2356)

* chore: refactor model layout; fix duration bug

* chore: rename get_duration to get_duration_millis

* feat: add boolean exported unsafe FFI function and couple other fixes (#2357)

Co-authored-by: Mark Phelps <[email protected]>

* chore: restructure client eval (#2362)

* feat: add initial commit for Python evaluation client using Rust core (#2358)

* feat: add initial commit for Python evaluation client using Rust core

* chore: fix README linting issue

* feat: move python source code and project under sdk

* chore: clean up Python client README.md and change ENGINE_LIB_PATH meaning

* chore: fix suggestions on PR

* feat: achieve unit test parity with Golang evaluator on Rust core (#2392)

* feat: add integration style tests for evaluation

* feat: add evaluatortest parity with Golang evaluator on Rust core engine

* chore: use mockall as dev dependency and attribute TestParser as only being used during tests

* feat: add initial commit for flipt-client-go evaluation client (#2390)

* feat: add initial commit for flipt-client-go evaluation client

* chore: fix README.md

* chore: README updates based on suggestions

* chore: only support one namespace for Golang client

* chore: add to go.work

* chore: mod tidy

* feat: incorporate error handling from Rust core over FFI to clients (#2400)

* chore: Rm clients in monorepo (#2407)

* chore: rm clients as they are moving to seperate repo

* chore: rm go client sdk

* chore: remove unused bits from .gitignore around Rust and Python and change go.work version back to 1.21

* chore: mod tidy

---------

Co-authored-by: Yoofi Quansah <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants