feat: achieve unit test parity with Golang evaluator on Rust core #2392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uffizzi Ephemeral Environment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## client-eval #2392 +/- ##
==============================================
Coverage ? 70.79%
==============================================
Files ? 78
Lines ? 7462
Branches ? 0
==============================================
Hits ? 5283
Misses ? 1878
Partials ? 301 ☔ View full report in Codecov by Sentry. |
yquansah
changed the title
GeorgeMac
reviewed
Nov 14, 2023
There was a problem hiding this comment.
Is it strange that you could make those changes to mocked data and the tests still passed? I assume we weren't asserting on these?
There was a problem hiding this comment.
@GeorgeMac The reason why these were passing is because there was only one constraint haha so it didnt matter if it was ANY or ALL but i changed it to be consistent with the test naming
… being used during tests
markphelps
approved these changes
Nov 14, 2023
markphelps
added a commit
that referenced
this pull request
Nov 21, 2023
* feat: Evaluation snapshot service (#2330) * chore(wip): gah * feat(wip): snapshot api * feat: finish proto server * chore: fix linter errors * chore: move * chore: fix build * chore: add ability to skip generating sdks * chore: dont generate interface method * chore: fix build * fix: mount api * chore: add namespace key to resp * chore: detect boolean flag types * chore: create own types for evaluation service * chore: rm spaces * chore: rename cmp type fields --------- Co-authored-by: Yoofi Quansah <[email protected]> * feat: initial commit for rust evaluator client side (#2322) * feat: initial commit for rust evaluator client side * chore: rename of entire directory tree * chore: write tests for all the matches constraints types * chore: redo gitignore * chore: format rust code * chore: use generic instead of parameter impl * chore: remove println! statement * feat: support variant attachment as String type Rust * feat: new engine logic * chore: fix unwrap by using match instead * chore: add boolean method to engine and format code * feat: add request logic for getting document text from configurable upstream Flipt instance * chore: apply cargo clippy updates * feat: add three basic functions for allocating engine and retrieving it * chore: remove TODO * feat: modify code to adapt to endpoint * chore: use environment variables to get update interval * chore: remove unnecessary clone * chore: add rust workspace * chore: update enums * chore: impl default for responses * chore: make constants * feat: Add changes for FFI boundaries and example code --------- Co-authored-by: Mark Phelps <[email protected]> * chore: engine model refactor (#2356) * chore: refactor model layout; fix duration bug * chore: rename get_duration to get_duration_millis * feat: add boolean exported unsafe FFI function and couple other fixes (#2357) Co-authored-by: Mark Phelps <[email protected]> * chore: restructure client eval (#2362) * feat: add initial commit for Python evaluation client using Rust core (#2358) * feat: add initial commit for Python evaluation client using Rust core * chore: fix README linting issue * feat: move python source code and project under sdk * chore: clean up Python client README.md and change ENGINE_LIB_PATH meaning * chore: fix suggestions on PR * feat: achieve unit test parity with Golang evaluator on Rust core (#2392) * feat: add integration style tests for evaluation * feat: add evaluatortest parity with Golang evaluator on Rust core engine * chore: use mockall as dev dependency and attribute TestParser as only being used during tests * feat: add initial commit for flipt-client-go evaluation client (#2390) * feat: add initial commit for flipt-client-go evaluation client * chore: fix README.md * chore: README updates based on suggestions * chore: only support one namespace for Golang client * chore: add to go.work * chore: mod tidy * feat: incorporate error handling from Rust core over FFI to clients (#2400) * chore: Rm clients in monorepo (#2407) * chore: rm clients as they are moving to seperate repo * chore: rm go client sdk * chore: remove unused bits from .gitignore around Rust and Python and change go.work version back to 1.21 * chore: mod tidy --------- Co-authored-by: Yoofi Quansah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to achieve unit test parity between the Golang evaluator and the Rust core engine.
Completes FLI-685