Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add build directory for testing with dagger #8

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Conversation

yquansah
Copy link
Contributor

Basic directory structure for integration testing evaluation clients with Rust core.

Completes FLI-699

Copy link

linear bot commented Nov 20, 2023

FLI-699 Add Python ITs

build/main.go Outdated Show resolved Hide resolved
build/main.go Outdated
WithExec([]string{"cargo", "build", "--release"})

// Flipt
flipt := client.Container().From("flipt/flipt:latest").
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to use a dev version of flipt here because latest doesn't have the routes that we need for testing yet.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should be able to merge flipt-io/flipt#2408, then we could use nightly starting tomorrow

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can actually build it now, now that ☝🏻 is merged

}
defer client.Close()

dir := client.Host().Directory(".")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works when you run from the root directory as

dagger run go run ./build

Copy link
Contributor

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! one comment about switching to use nightly after merging the client API in Flipt

@yquansah yquansah force-pushed the tests-structure branch 2 times, most recently from 60c4773 to 0f57a9d Compare November 21, 2023 15:35
@yquansah yquansah marked this pull request as ready for review November 21, 2023 15:37
@yquansah yquansah merged commit 6b672e0 into main Nov 21, 2023
@yquansah yquansah deleted the tests-structure branch November 21, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants