Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test flathub bot with git ssh source #18

Closed
wants to merge 1 commit into from
Closed

Test flathub bot with git ssh source #18

wants to merge 1 commit into from

Conversation

catsout
Copy link
Collaborator

@catsout catsout commented Aug 19, 2021

No description provided.

@flathubbot
Copy link

Started test build 56604

Copy link

@hfiguiere hfiguiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what you wanted to achieve but for github these URL should work better

@@ -29482,13 +29482,13 @@
},
{
"type": "git",
"url": "https://[email protected]/laurent22/node-emoji.git",
"url": "ssh://[email protected]/laurent22/node-emoji.git",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"url": "ssh://git@github.com/laurent22/node-emoji.git",
"url": "https://github.com/laurent22/node-emoji.git",

This is probably what you want.

"commit": "9fa01eac463e94dde1316ef8c53089eeef4973b5",
"dest": "flatpak-node/git-packages/node-emoji-9fa01eac463e94dde1316ef8c53089eeef4973b5"
},
{
"type": "git",
"url": "https://[email protected]/laurent22/uslug.git",
"url": "ssh://[email protected]/laurent22/uslug.git",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"url": "ssh://git@github.com/laurent22/uslug.git",
"url": "https://github.com/laurent22/uslug.git",

@catsout
Copy link
Collaborator Author

catsout commented Aug 19, 2021

not sure what you wanted to achieve but for github these URL should work better

Actually, the file changed is generated by flatpak-builder-tools.
The tools generate the source with git ssh url.
I manually change these to https:
https://github.com/flathub/net.cozic.joplin_desktop/blob/99c2127bf6b819c0a4915ab884b4e272d40d5f49/update-sources.sh#L30b

@hfiguiere
Copy link

well, there is a bug in the tool.

@hfiguiere
Copy link

It should replace //git@ by // as well on that line.

@catsout
Copy link
Collaborator Author

catsout commented Aug 19, 2021

It should replace //git@ by // as well on that line.

No, the tool generate some thing like git+ssh://[email protected]/...
It just break the build of previous pr
So I write a sed command to change urls to https, and I forgot to remove git@

@hfiguiere
Copy link

it shouldn't generate git+ssh: url either.

@catsout catsout closed this Aug 19, 2021
@catsout
Copy link
Collaborator Author

catsout commented Aug 19, 2021

it shouldn't generate git+ssh: url either.

@hfiguiere
flatpak/flatpak-builder-tools#193

@flathubbot
Copy link

Build 56604 failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants