Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git+ssh make flathub bot stuck at downloading #237

Open
catsout opened this issue Oct 24, 2021 · 3 comments
Open

git+ssh make flathub bot stuck at downloading #237

catsout opened this issue Oct 24, 2021 · 3 comments
Labels

Comments

@catsout
Copy link
Contributor

catsout commented Oct 24, 2021

From:
https://github.com/npm/arborist/blob/d9c603ede4fefb0bda1385e70b431b3adec810bf/lib/shrinkwrap.js#L704

Now npm will resolve any github url to git+ssh.
But this will make flathub bot stuck at downloading:
flathub/com.getmailspring.Mailspring#2 (comment)
flathub/net.cozic.joplin_desktop#18 (comment)

As flathub/flathub#2466 (comment), using "ssh" URL like that is bound to fail on flathub: there is no ssh key setup.

So, could we add a option to replace the url, or add some warn messages?

@catsout
Copy link
Contributor Author

catsout commented Oct 24, 2021

ping @hfiguiere

@hfiguiere
Copy link
Collaborator

no idea

@olof-nord
Copy link
Contributor

In case someone comes across this later: the node flatpak-builder-tools only supports a subset of what npm does.
What should work is the following: (see https://github.com/flatpak/flatpak-builder-tools/blob/master/node/tests/data/packages/minimal-git/package.json)

{
  "name": "@flatpak-node-generator-tests/minimal-git",
  "version": "1.0.0",
  "dependencies": {
    "nop": "https://[email protected]/supershabam/nop.git"
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants