We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
From: https://github.com/npm/arborist/blob/d9c603ede4fefb0bda1385e70b431b3adec810bf/lib/shrinkwrap.js#L704
Now npm will resolve any github url to git+ssh. But this will make flathub bot stuck at downloading: flathub/com.getmailspring.Mailspring#2 (comment) flathub/net.cozic.joplin_desktop#18 (comment)
git+ssh
As flathub/flathub#2466 (comment), using "ssh" URL like that is bound to fail on flathub: there is no ssh key setup.
So, could we add a option to replace the url, or add some warn messages?
The text was updated successfully, but these errors were encountered:
ping @hfiguiere
Sorry, something went wrong.
no idea
In case someone comes across this later: the node flatpak-builder-tools only supports a subset of what npm does. What should work is the following: (see https://github.com/flatpak/flatpak-builder-tools/blob/master/node/tests/data/packages/minimal-git/package.json)
{ "name": "@flatpak-node-generator-tests/minimal-git", "version": "1.0.0", "dependencies": { "nop": "https://[email protected]/supershabam/nop.git" } }
No branches or pull requests
From:
https://github.com/npm/arborist/blob/d9c603ede4fefb0bda1385e70b431b3adec810bf/lib/shrinkwrap.js#L704
Now npm will resolve any github url to
git+ssh
.But this will make flathub bot stuck at downloading:
flathub/com.getmailspring.Mailspring#2 (comment)
flathub/net.cozic.joplin_desktop#18 (comment)
As flathub/flathub#2466 (comment), using "ssh" URL like that is bound to fail on flathub: there is no ssh key setup.
So, could we add a option to replace the url, or add some warn messages?
The text was updated successfully, but these errors were encountered: