[axolotl-web] Adjust format used for mic-recorder-to-mp3 git npm dependency #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update npm lock file The format used is based on the minimal-git node flatpak-builder-tools test case https://github.com/flatpak/flatpak-builder-tools/blob/master/node/tests/data/packages/minimal-git/package.json This should solve #838
|
Note that the library stays the same, and the npm build should be the same too: this is effectively just to get the flatpak tooling to pick up the dependency correctly. |
|
The PR #855 did unfortunately not address the issue. |
This was referenced Aug 26, 2022
olof-nord
changed the title
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust format used for mic-recorder-to-mp3 npm git dependency and update npm lock file.
The format used is based on the minimal-git node flatpak-builder-tools test case
https://github.com/flatpak/flatpak-builder-tools/blob/master/node/tests/data/packages/minimal-git/package.json
This should solve #838
This bug has two related issues in flatpak-builder-tools: