[BUG] mic-recorder-to-mp3 npm dependency causing flatpak build issues

[olof-nord]

Description

The mic-recorder-to-mp3 axolotl-web npm dependency is causing flathub build issues.

Steps to Reproduce

1. check out main branch
2. execute make build-flatpak-web

What is actually used for the build here is the flathub build bots, the above steps should succeed locally unless its a completely new install of the OS which doesnt have the certificate already.

Expected behavior:

build to complete.

Actual behavior:

The authenticity of host 'github.com (140.82.114.4)' can't be established.
ED25519 key fingerprint is SHA256:+DiY3wvvV6TuJJhbpZisF/zLDA0zPMSvHdkr4UvCOqU.
Are you sure you want to continue connecting (yes/no/[fingerprint])? 

full log:

]2;flatpak-builder: Downloading axolotl-electron-bundle�FB: Running: git --version
FB: Git version: 2.36.1.0
FB: Running: git init --bare '/srv/buildbot/worker/build-aarch64-3/build/.flatpak-builder/git/[email protected]_NikolaBalaban_mic-recorder-to-mp3.git-O1TBO1'
hint: Using 'master' as the name for the initial branch. This default branch name
hint: is subject to change. To configure the initial branch name to use in all
hint: of your new repositories, which will suppress this warning, call:
hint: 
hint: 	git config --global init.defaultBranch <name>
hint: 
hint: Names commonly chosen instead of 'master' are 'main', 'trunk' and
hint: 'development'. The just-created branch can be renamed via this command:
hint: 
hint: 	git branch -m <name>
Initialized empty Git repository in /srv/buildbot/worker/build-aarch64-3/build/.flatpak-builder/git/[email protected]_NikolaBalaban_mic-recorder-to-mp3.git-O1TBO1/
FB: Running: git remote add --mirror=fetch origin 'git+ssh://[email protected]/NikolaBalaban/mic-recorder-to-mp3.git'
FB: Running: git cat-file -e b07b6408c41cb55122169739e4bdce626660c109
FB: Running: git ls-remote origin
The authenticity of host 'github.com (140.82.114.4)' can't be established.
ED25519 key fingerprint is SHA256:+DiY3wvvV6TuJJhbpZisF/zLDA0zPMSvHdkr4UvCOqU.
This key is not known by any other names
command timed out: 3600 seconds without output running [b'dbus-run-session', b'flatpak', b'run', b'org.flatpak.Builder', b'-v', b'--force-clean', b'--sandbox', b'--delete-build-dirs', b'--user', b'--install-deps-from=flathub', b'--install-deps-from=flathub-beta', b'--arch', b'aarch64', b'--mirror-screenshots-url=https://dl.flathub.org/repo/screenshots', b'--repo', b'repo', b'--extra-sources=/srv/buildbot/worker/build-aarch64-3/../downloads', b'--default-branch', b'test', b'--subject', b'Release 1.3.0 (324ee815)', b'--remove-tag=upstream-maintained', b'builddir', b'org.nanuc.Axolotl.yml'], attempting to kill
process killed by signal 9
program finished with exit code -1
elapsedTime=3803.047189
Are you sure you want to continue connecting (yes/no/[fingerprint])? 

Versions

latest main commit

Device

What device or OS are you using?

Arch Linux, kernel 5.18.5-arch1-1 (but the error message is from the flathub builder)

https://buildbot.flathub.org/#/builders/5/builds/7714

Link to Debug Log

Not relevant.

[olof-nord]

In the npm documentation for install, this path is indeed listed as supported, but it seems that it is not supported by flatpak.

I suggest we switch to any other path, there seems to be some different ways which are supported.

<githubname>/<githubrepo>[#<commit-ish>]
github:<githubname>/<githubrepo>[#<commit-ish>]
git://github.com/npm/cli.git#v1.0.27

Alternatively, could we avoid using a fork and instead use a properly released version?
Potentially upstreaming the fix needed to the original library.

[olof-nord]

Looking into the flathub node tooling, it seems that this issue might be of some relevance.

[node] flatpak-node-generator.py failed to deal with deps with direct git reference

[olof-nord]

I am afraid we wont get any new Flathub releases until this problem is solved - on the positive side, the Flathub node/npm support has seen some great improvements recently, with the package.json parser getting better and better.

[olof-nord]

This bug is unfortunately still not solved, reopening.

[olof-nord]

Here is the error message for 1.5.0:

Initialized empty Git repository in /srv/buildbot/worker/build-x86_64-4/build/.flatpak-builder/git/[email protected]_NikolaBalaban_mic-recorder-to-mp3.git-B8BRR1/
FB: Running: git remote add --mirror=fetch origin 'git+ssh://[email protected]/NikolaBalaban/mic-recorder-to-mp3.git'
FB: Running: git cat-file -e b07b6408c41cb55122169739e4bdce626660c109
FB: Running: git --version
FB: Git version: 2.36.1.0
FB: Running: git ls-remote origin
The authenticity of host 'github.com (140.82.113.3)' can't be established.
ED25519 key fingerprint is SHA256:+DiY3wvvV6TuJJhbpZisF/zLDA0zPMSvHdkr4UvCOqU.
This key is not known by any other names

[olof-nord]

I suggest to instead switch to a version of mic-recorder-to-mp3 which is published on npm.
Looking at alternatives, I suggest to use the @jmd01/mic-recorder-to-mp3 fork, quoting: "Forked due to the bundled dist".

https://www.npmjs.com/search?ranking=popularity&q=mic-recorder-to-mp3

PR comes soon

[olof-nord]

With PR #877 this issue was resolved, and thus I am happily closing this.