Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for git+ssh scheme #193

Closed

Conversation

proletarius101
Copy link
Contributor

So naively adding this to the support list works.

@muelli
Copy link
Member

muelli commented Apr 30, 2021

what problem does that fix for you?

@proletarius101
Copy link
Contributor Author

what problem does that fix for you?

e.g. In https://github.com/bitwarden/desktop/blob/master/package.json#L309 they use git+ssh, which we would like to build from source: flathub/com.bitwarden.desktop#52. This type of dependencies will abort the flatpak-builder-tools

@muelli
Copy link
Member

muelli commented May 1, 2021

okay, cool! :) I haven't written the generator and I prefer somebody else taking the lead here for merging, but if I merge this, I just want to make sure it fixes an actual problem rather than something that may be relevant in the future.

And so I wonder: does that really fix the problem? From what I can see the build fails in the download phase.

@hfiguiere
Copy link
Collaborator

I don't think it should replace to ssh: as this require authtentication.

@gasinvein
Copy link
Member

gasinvein commented Aug 19, 2021

git+ssh should work fine, flatpak-builder is able to handle it as-is. Can you provide some evidence of what exactly does this fix?

@muelli
Copy link
Member

muelli commented Mar 19, 2022

let me close for now. Please reopen if this becomes necessary.

@muelli muelli closed this Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants