Market deal metadata methods to return EX_DEAL_EXPIRED if the deal ID is used #989

shamb0 · 2022-12-27T15:42:26Z

Fix for the requirement 830.

Market deal metadata methods to return EX_DEAL_EXPIRED if the deal ID is used.

Closes #830

* Export Datacap Actor methods * Export Init Actor methods * Export Market Actor methods * Export Miner Actor methods * Export Multisig Actor methods * Export Verifreg Actor methods * Address review

…project#812)

* Power actor: Add exported getters for raw power * FRC-XXXX is FRC-0042 * Power actor: network_raw_power: Return this_epoch_raw_byte_power * Power actor: miner_raw_power: Return whether above consensus min power * Power actor: types: serialize one-element structs transparently * Address review * Miner actor: Add exported getters for info and monies (filecoin-project#811) * Miner actor: Add exported getters for info and monies * Tweak comment * Miner actor: Replace GetWorker and GetControls with IsControllingAddress * Miner actor: Add exported GetAvailableBalance * Miner actor: Add exported GetVestingFunds * Miner actor: Remove exported monies getters * Miner actor: types: serialize one-element structs transparently * Address review * Address review

Co-authored-by: zenground0 <[email protected]>

…roject#821)

…oject#826) * Market actor: GetDealTermExported: Return (start_epoch, duration) * Market actor: Export getter for deal total price

…filecoin-project#824) * Paych actor: Drop account req, use AuthenticateMessage to verify sigs * Address review * Address review

* Miner: Export ChangeWorkerAddress * Miner: Export ChangePeerID * Miner: Export WithdrawBalance * Miner: Export ChangeMultiaddrs * Miner: Export ConfirmUpdateWorkerKey * Miner: Export RepayDebt * Miner: Export ChangeOwnerAddress * Miner: Add exported getters for PeerID & multiaddrs * Miner: Refactor: Rename ConfirmUpdateWorkerKey to ConfirmChangeWorkerAddress

…coin-project#868) * Power: Export CreateMiner * Power Actor: Export MinerCount and MinerConsensusCount * Update actors/power/src/lib.rs Co-authored-by: Alex <[email protected]> Co-authored-by: Alex <[email protected]>

* Verifreg: Rename AddVerifierClientParams to AddVerifiedClientParams * Verifreg: Export AddVerifiedClient and GetClaims

* Datacap: Export Mint and Destroy * Datacap actor: Deprecate all internal methods * Datacap actor: Rename BalanceOf to Balance * Datacap actor: Add Granularity method

Co-authored-by: zenground0 <[email protected]>

Signed-off-by: shamb0 <[email protected]>

codecov-commenter · 2022-12-27T16:07:46Z

Codecov Report

Merging #989 (5cd66fb) into master (7fe9b77) will increase coverage by 0.03%.
The diff coverage is 93.33%.

❗ Current head 5cd66fb differs from pull request most recent head 8e920e3. Consider uploading reports for the commit 8e920e3 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #989      +/-   ##
==========================================
+ Coverage   89.05%   89.08%   +0.03%     
==========================================
  Files          95       95              
  Lines       19856    19861       +5     
==========================================
+ Hits        17683    17694      +11     
+ Misses       2173     2167       -6

Impacted Files	Coverage Δ
actors/market/src/state.rs	`93.83% <80.00%> (-0.13%)`	⬇️
actors/market/src/lib.rs	`91.06% <100.00%> (+0.02%)`	⬆️
actors/power/src/lib.rs	`84.88% <0.00%> (+1.51%)`	⬆️

…EX_DEAL_EXPIRED

…shamb0/dev-v1-830-return-EX_DEAL_EXPIRED

Signed-off-by: shamb0 <[email protected]>

bump rust toolchain to 1.64

…ecoin-project#1004) * Proof of concept exported API for Account actor (filecoin-project#797) * Export stable methods for public access (filecoin-project#807) * Export Datacap Actor methods * Export Init Actor methods * Export Market Actor methods * Export Miner Actor methods * Export Multisig Actor methods * Export Verifreg Actor methods * Address review * Restrict internal APIs of all actors (filecoin-project#809) * Exported API method for market actor escrow/locked balance (filecoin-project#812) * Power actor: Add exported getters for raw power (filecoin-project#810) * Power actor: Add exported getters for raw power * FRC-XXXX is FRC-0042 * Power actor: network_raw_power: Return this_epoch_raw_byte_power * Power actor: miner_raw_power: Return whether above consensus min power * Power actor: types: serialize one-element structs transparently * Address review * Miner actor: Add exported getters for info and monies (filecoin-project#811) * Miner actor: Add exported getters for info and monies * Tweak comment * Miner actor: Replace GetWorker and GetControls with IsControllingAddress * Miner actor: Add exported GetAvailableBalance * Miner actor: Add exported GetVestingFunds * Miner actor: Remove exported monies getters * Miner actor: types: serialize one-element structs transparently * Address review * Address review * Built-in market API for deal proposal metadata (filecoin-project#818) * Call exported authenticate method from PSD (filecoin-project#829) Co-authored-by: zenground0 <[email protected]> * Drop CALLER_TYPES_SIGNABLE and signable caller validation (filecoin-project#821) * Market actor: Minor improvements to two exported getters (filecoin-project#826) * Market actor: GetDealTermExported: Return (start_epoch, duration) * Market actor: Export getter for deal total price * Exported API for market deal activation state (filecoin-project#819) * Paych actor: Drop account req, use AuthenticateMessage to verify sigs (filecoin-project#824) * Paych actor: Drop account req, use AuthenticateMessage to verify sigs * Address review * Address review * Account actor: Deprecate AuthenticateMessage (filecoin-project#856) * Market actor: Export PublishStorageDeals (filecoin-project#857) * Miner: Export several more methods (filecoin-project#863) * Miner: Export ChangeWorkerAddress * Miner: Export ChangePeerID * Miner: Export WithdrawBalance * Miner: Export ChangeMultiaddrs * Miner: Export ConfirmUpdateWorkerKey * Miner: Export RepayDebt * Miner: Export ChangeOwnerAddress * Miner: Add exported getters for PeerID & multiaddrs * Miner: Refactor: Rename ConfirmUpdateWorkerKey to ConfirmChangeWorkerAddress * Power actor: Export methods to CreateMiner and get miner counts (filecoin-project#868) * Power: Export CreateMiner * Power Actor: Export MinerCount and MinerConsensusCount * Update actors/power/src/lib.rs Co-authored-by: Alex <[email protected]> Co-authored-by: Alex <[email protected]> * Verifreg: Export AddVerifiedClient and GetClaims (filecoin-project#873) * Verifreg: Rename AddVerifierClientParams to AddVerifiedClientParams * Verifreg: Export AddVerifiedClient and GetClaims * Datacap actor: Modify exported methods (filecoin-project#909) * Datacap: Export Mint and Destroy * Datacap actor: Deprecate all internal methods * Datacap actor: Rename BalanceOf to Balance * Datacap actor: Add Granularity method * fix: comments on newly exported methods (filecoin-project#910) * Miner: Export method to GetPendingOwner * MarketNotifyDeal (filecoin-project#944) Co-authored-by: zenground0 <[email protected]> * Verifreg: Call AuthenticateMessage instead of validating siggys * Multisig: Do not export any functionality (filecoin-project#967) * use const for EX_DEAL_EXPIRED (filecoin-project#954) * Address review Co-authored-by: Alex <[email protected]> Co-authored-by: ZenGround0 <[email protected]> Co-authored-by: zenground0 <[email protected]> Co-authored-by: Shashank <[email protected]>

…1019)

chore: update hamt & kamt Replaces filecoin-project#1020

Co-authored-by: anorth <[email protected]> Closes filecoin-project#662

…ged (filecoin-project#1030)

1. Use absolute paths so we don't have to import things everywhere. 2. Support dispatch fallbacks (`_`). 3. Support dispatching to methods without decoding/encoding (`[raw]`).

…g 0.3.3 (filecoin-project#1095) * Update to FVM SDK 3.0.0-alpha.22, shared 3.0.0-alpha.17, ipld_encoding 0.3.3 * Datacap: Turn Messenger struct into SyscallProvider * Update frc42_dispatch, frc46_tokn, fvm_actor_utils

…lecoin-project#1118) * feat: Partial implementation of FIP-0048 * Address review

* feat: runtime: Add send_generalized * Refactor: Runtime: Add send_simple and extract_send_result methods * Address review

…project#1133)

…1131)

Signed-off-by: shamb0 <[email protected]>

The base branch was changed.

Signed-off-by: shamb0 <[email protected]>

shamb0 · 2023-01-31T12:32:47Z

@anorth Re-base to master done. I hope now it's ready for intake.

anorth

Thanks.

The change itself looks good. The rebase looks a bit wierd though, I see 181 commits. I will see if I can squash it cleanly.

actors/market/src/lib.rs

anorth and others added 24 commits December 11, 2022 10:37

Proof of concept exported API for Account actor (filecoin-project#797)

36810e9

Export stable methods for public access (filecoin-project#807)

0f3d72f

* Export Datacap Actor methods * Export Init Actor methods * Export Market Actor methods * Export Miner Actor methods * Export Multisig Actor methods * Export Verifreg Actor methods * Address review

Restrict internal APIs of all actors (filecoin-project#809)

370223b

Exported API method for market actor escrow/locked balance (filecoin-…

dec77b8

…project#812)

Built-in market API for deal proposal metadata (filecoin-project#818)

5c3ca43

Call exported authenticate method from PSD (filecoin-project#829)

68aaba2

Co-authored-by: zenground0 <[email protected]>

Drop CALLER_TYPES_SIGNABLE and signable caller validation (filecoin-p…

0e18683

…roject#821)

Market actor: Minor improvements to two exported getters (filecoin-pr…

fdd6303

…oject#826) * Market actor: GetDealTermExported: Return (start_epoch, duration) * Market actor: Export getter for deal total price

Exported API for market deal activation state (filecoin-project#819)

b26fc74

Paych actor: Drop account req, use AuthenticateMessage to verify sigs (…

cd33132

…filecoin-project#824) * Paych actor: Drop account req, use AuthenticateMessage to verify sigs * Address review * Address review

Account actor: Deprecate AuthenticateMessage (filecoin-project#856)

d6048c0

Market actor: Export PublishStorageDeals (filecoin-project#857)

904bd6a

Verifreg: Export AddVerifiedClient and GetClaims (filecoin-project#873)

6e04569

* Verifreg: Rename AddVerifierClientParams to AddVerifiedClientParams * Verifreg: Export AddVerifiedClient and GetClaims

Datacap actor: Modify exported methods (filecoin-project#909)

fe6320c

* Datacap: Export Mint and Destroy * Datacap actor: Deprecate all internal methods * Datacap actor: Rename BalanceOf to Balance * Datacap actor: Add Granularity method

fix: comments on newly exported methods (filecoin-project#910)

37cb754

Miner: Export method to GetPendingOwner

9d02326

MarketNotifyDeal (filecoin-project#944)

4c1c251

Co-authored-by: zenground0 <[email protected]>

Verifreg: Call AuthenticateMessage instead of validating siggys

0841be4

Merge branch 'master' into integration/builtin-api

e5e1318

Multisig: Do not export any functionality (filecoin-project#967)

c57b032

exit code refactor

ab4c1ae

Signed-off-by: shamb0 <[email protected]>

sudo-shashank and others added 5 commits January 2, 2023 11:50

use const for EX_DEAL_EXPIRED (filecoin-project#954)

0562655

Merge branch 'integration/builtin-api' into shamb0/dev-v1-830-return-…

f17bb35

…EX_DEAL_EXPIRED

Merge remote-tracking branch 'upstream/integration/builtin-api' into …

f7c03aa

…shamb0/dev-v1-830-return-EX_DEAL_EXPIRED

upstream merge & few more refactor

2b16c4b

Signed-off-by: shamb0 <[email protected]>

remove junk whitespace

fae0253

Signed-off-by: shamb0 <[email protected]>

arajasek and others added 21 commits January 31, 2023 11:59

Remove unused macro (filecoin-project#969)

69a9274

Upgade Rust to 1.64 (master) (filecoin-project#973)

8f2a226

bump rust toolchain to 1.64

Refactor: Actors now return Option<IpldBlock> (filecoin-project#987)

47fee6b

Address review

aa083b4

Implement log initialisation inline in FVM runtime (filecoin-project#…

4b6b558

…1019)

chore: update hamt & amt (filecoin-project#1052)

62b8132

chore: update hamt & kamt Replaces filecoin-project#1020

Market actor batch datacap token transfers (filecoin-project#722)

88acd83

Co-authored-by: anorth <[email protected]> Closes filecoin-project#662

Avoid redundant read/write of allocation/claims HAMT root when unchan…

c5e51cb

…ged (filecoin-project#1030)

feat: improve dispatch macro (filecoin-project#1088)

1821bc7

1. Use absolute paths so we don't have to import things everywhere. 2. Support dispatch fallbacks (`_`). 3. Support dispatching to methods without decoding/encoding (`[raw]`).

feat: allow ActorErrors to carry optional data (filecoin-project#1093)

c107b0b

Use is_controlling_address in actors (filecoin-project#948)

9692ad2

feat: Partial implementation of FIP-0048 (f4/delegated addresses) (fi…

e094196

…lecoin-project#1118) * feat: Partial implementation of FIP-0048 * Address review

feat: runtime: Add send_generalized (filecoin-project#1126)

d5d64e6

* feat: runtime: Add send_generalized * Refactor: Runtime: Add send_simple and extract_send_result methods * Address review

feat: runtime: Add read_only getter (filecoin-project#1127)

a07aa05

refactor: Runtime: Move create and state into default impl (filecoin-…

b9abdfb

…project#1133)

test_vm: support creating actors over placeholders (filecoin-project#…

d276afc

…1131)

rebase to upstream master

a898584

Signed-off-by: shamb0 <[email protected]>

rebase to upstream & review comments closure

bb06eac

Signed-off-by: shamb0 <[email protected]>

rebase to upstream & review comments closure

af148d6

Signed-off-by: shamb0 <[email protected]>

shamb0 changed the base branch from integration/builtin-api to master January 31, 2023 11:50

shamb0 added 2 commits January 31, 2023 17:50

rebase to upstream & review comments closure

6364afd

Signed-off-by: shamb0 <[email protected]>

cargo.lock updates

6efa19d

anorth approved these changes Jan 31, 2023

View reviewed changes

actors/market/src/lib.rs Outdated Show resolved Hide resolved

anorth added 2 commits February 1, 2023 10:18

Remove old comment

5cd66fb

Merge branch 'master' into shamb0/dev-v1-830-return-EX_DEAL_EXPIRED

8e920e3

anorth merged commit c976f74 into filecoin-project:master Feb 1, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Market deal metadata methods to return EX_DEAL_EXPIRED if the deal ID is used #989

Market deal metadata methods to return EX_DEAL_EXPIRED if the deal ID is used #989

shamb0 commented Dec 27, 2022 •

edited by anorth

Loading

codecov-commenter commented Dec 27, 2022 •

edited

Loading

shamb0 commented Jan 31, 2023

anorth left a comment

Market deal metadata methods to return EX_DEAL_EXPIRED if the deal ID is used #989

Market deal metadata methods to return EX_DEAL_EXPIRED if the deal ID is used #989

Conversation

shamb0 commented Dec 27, 2022 • edited by anorth Loading

codecov-commenter commented Dec 27, 2022 • edited Loading

Codecov Report

shamb0 commented Jan 31, 2023

anorth left a comment

Choose a reason for hiding this comment

shamb0 commented Dec 27, 2022 •

edited by anorth

Loading

codecov-commenter commented Dec 27, 2022 •

edited

Loading