Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call exported authenticate method from PSD #829

Merged
merged 4 commits into from
Nov 11, 2022
Merged

Call exported authenticate method from PSD #829

merged 4 commits into from
Nov 11, 2022

Conversation

ZenGround0
Copy link
Contributor

For contract deal clients to be possible

anorth
anorth reviewed Nov 11, 2022
View reviewed changes
Copy link
Member

@anorth anorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I think we should also deprecate the non-exported method on the account and multisig actors. Nothing except builtins will be calling it in nv17

actors/market/src/ext.rs Outdated
@@ -10,7 +10,8 @@ use fvm_shared::smooth::FilterEstimate;
pub mod account {
use super::*;

pub const AUTHENTICATE_MESSAGE_METHOD: u64 = 3;
pub const AUTHENTICATE_MESSAGE_EXPORTED_METHOD: u64 =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I don't think you need to rename the constant.

@ZenGround0 ZenGround0 merged commit 8ae3114 into integration/builtin-api Nov 11, 2022
@ZenGround0 ZenGround0 deleted the market/call-exported-authenticate branch November 11, 2022 19:27
arajasek pushed a commit that referenced this pull request Nov 16, 2022
@ZenGround0 @arajasek
Call exported authenticate method from PSD (#829)
222c13a 
Co-authored-by: zenground0 <[email protected]>
arajasek pushed a commit that referenced this pull request Nov 16, 2022
@ZenGround0 @arajasek
Call exported authenticate method from PSD (#829)
0c7de86 
Co-authored-by: zenground0 <[email protected]>
arajasek pushed a commit that referenced this pull request Nov 17, 2022
@ZenGround0 @arajasek
Call exported authenticate method from PSD (#829)
fc24732 
Co-authored-by: zenground0 <[email protected]>
arajasek pushed a commit that referenced this pull request Nov 17, 2022
@ZenGround0 @arajasek
Call exported authenticate method from PSD (#829)
d2cf652 
Co-authored-by: zenground0 <[email protected]>
arajasek pushed a commit that referenced this pull request Nov 17, 2022
@ZenGround0 @arajasek
Call exported authenticate method from PSD (#829)
1e7182a 
Co-authored-by: zenground0 <[email protected]>
arajasek pushed a commit that referenced this pull request Nov 21, 2022
@ZenGround0 @arajasek
Call exported authenticate method from PSD (#829)
2fadf9f 
Co-authored-by: zenground0 <[email protected]>
arajasek pushed a commit that referenced this pull request Nov 23, 2022
@ZenGround0 @arajasek
Call exported authenticate method from PSD (#829)
2ab676a 
Co-authored-by: zenground0 <[email protected]>
@arajasek arajasek mentioned this pull request Nov 25, 2022
Open
arajasek pushed a commit that referenced this pull request Nov 27, 2022
@ZenGround0 @arajasek
Call exported authenticate method from PSD (#829)
98917b7 
Co-authored-by: zenground0 <[email protected]>
arajasek pushed a commit that referenced this pull request Nov 28, 2022
@ZenGround0 @arajasek
Call exported authenticate method from PSD (#829)
adaf449 
Co-authored-by: zenground0 <[email protected]>
arajasek pushed a commit that referenced this pull request Nov 28, 2022
@ZenGround0 @arajasek
Call exported authenticate method from PSD (#829)
14b6a5c 
Co-authored-by: zenground0 <[email protected]>
arajasek pushed a commit that referenced this pull request Nov 29, 2022
@ZenGround0 @arajasek
Call exported authenticate method from PSD (#829)
1680aaf 
Co-authored-by: zenground0 <[email protected]>
arajasek pushed a commit that referenced this pull request Nov 30, 2022
@ZenGround0 @arajasek
Call exported authenticate method from PSD (#829)
dcb9afa 
Co-authored-by: zenground0 <[email protected]>
arajasek pushed a commit that referenced this pull request Nov 30, 2022
@ZenGround0 @arajasek
Call exported authenticate method from PSD (#829)
687ae94 
Co-authored-by: zenground0 <[email protected]>
arajasek pushed a commit that referenced this pull request Dec 5, 2022
@ZenGround0 @arajasek
Call exported authenticate method from PSD (#829)
8f039ed 
Co-authored-by: zenground0 <[email protected]>
arajasek pushed a commit that referenced this pull request Dec 7, 2022
@ZenGround0 @arajasek
Call exported authenticate method from PSD (#829)
7594b3c 
Co-authored-by: zenground0 <[email protected]>
vyzo pushed a commit that referenced this pull request Dec 7, 2022
@arajasek @shamb0
@anorth @ZenGround0
Merge master and integration/builtin-api into next (#918)
3c417b8 
* Remove the market actor state mutation pattern (#734)

Fixes #656

* Proof of concept exported API for Account actor (#797)

* Export stable methods for public access (#807)

* Export Datacap Actor methods

* Export Init Actor methods

* Export Market Actor methods

* Export Miner Actor methods

* Export Multisig Actor methods

* Export Verifreg Actor methods

* Address review

* Restrict internal APIs of all actors (#809)

* Exported API method for market actor escrow/locked balance (#812)

* Power actor: Add exported getters for raw power (#810)

* Power actor: Add exported getters for raw power

* FRC-XXXX is FRC-0042

* Power actor: network_raw_power: Return this_epoch_raw_byte_power

* Power actor: miner_raw_power: Return whether above consensus min power

* Power actor: types: serialize one-element structs transparently

* Address review

* Miner actor: Add exported getters for info and monies (#811)

* Miner actor: Add exported getters for info and monies

* Tweak comment

* Miner actor: Replace GetWorker and GetControls with IsControllingAddress

* Miner actor: Add exported GetAvailableBalance

* Miner actor: Add exported GetVestingFunds

* Miner actor: Remove exported monies getters

* Miner actor: types: serialize one-element structs transparently

* Address review

* Address review

* Built-in market API for deal proposal metadata (#818)

* Call exported authenticate method from PSD (#829)


Co-authored-by: zenground0 <[email protected]>

* Drop CALLER_TYPES_SIGNABLE and signable caller validation (#821)

* Market actor: Minor improvements to two exported getters (#826)

* Market actor: GetDealTermExported: Return (start_epoch, duration)

* Market actor: Export getter for deal total price

* Exported API for market deal activation state (#819)

* Paych actor: Drop account req, use AuthenticateMessage to verify sigs (#824)

* Paych actor: Drop account req, use AuthenticateMessage to verify sigs

* Address review

* Address review

* Account actor: Deprecate AuthenticateMessage (#856)

* Market actor: Export PublishStorageDeals (#857)

* Miner: Export several more methods (#863)

* Miner: Export ChangeWorkerAddress

* Miner: Export ChangePeerID

* Miner: Export WithdrawBalance

* Miner: Export ChangeMultiaddrs

* Miner: Export ConfirmUpdateWorkerKey

* Miner: Export RepayDebt

* Miner: Export ChangeOwnerAddress

* Miner: Add exported getters for PeerID & multiaddrs

* Miner: Refactor: Rename ConfirmUpdateWorkerKey to ConfirmChangeWorkerAddress

* Power actor: Export methods to CreateMiner and get miner counts (#868)

* Power: Export CreateMiner

* Power Actor: Export MinerCount and MinerConsensusCount

* Update actors/power/src/lib.rs

Co-authored-by: Alex <[email protected]>

Co-authored-by: Alex <[email protected]>

* Verifreg: Export AddVerifiedClient and GetClaims (#873)

* Verifreg: Rename AddVerifierClientParams to AddVerifiedClientParams

* Verifreg: Export AddVerifiedClient and GetClaims

* Datacap actor: Modify exported methods (#909)

* Datacap: Export Mint and Destroy

* Datacap actor: Deprecate all internal methods

* Datacap actor: Rename BalanceOf to Balance

* Datacap actor: Add Granularity method

* fix: comments on newly exported methods (#910)

Co-authored-by: RK <[email protected]>
Co-authored-by: Alex <[email protected]>
Co-authored-by: ZenGround0 <[email protected]>
Co-authored-by: zenground0 <[email protected]>
arajasek pushed a commit that referenced this pull request Dec 11, 2022
@ZenGround0 @arajasek
Call exported authenticate method from PSD (#829)
68aaba2 
Co-authored-by: zenground0 <[email protected]>
arajasek added a commit that referenced this pull request Jan 12, 2023
@arajasek @anorth
@ZenGround0 @sudo-shashank
FIP-0050: API between user-programmed actors and built-in actors (#1004)
b84d38c 
* Proof of concept exported API for Account actor (#797)

* Export stable methods for public access (#807)

* Export Datacap Actor methods

* Export Init Actor methods

* Export Market Actor methods

* Export Miner Actor methods

* Export Multisig Actor methods

* Export Verifreg Actor methods

* Address review

* Restrict internal APIs of all actors (#809)

* Exported API method for market actor escrow/locked balance (#812)

* Power actor: Add exported getters for raw power (#810)

* Power actor: Add exported getters for raw power

* FRC-XXXX is FRC-0042

* Power actor: network_raw_power: Return this_epoch_raw_byte_power

* Power actor: miner_raw_power: Return whether above consensus min power

* Power actor: types: serialize one-element structs transparently

* Address review

* Miner actor: Add exported getters for info and monies (#811)

* Miner actor: Add exported getters for info and monies

* Tweak comment

* Miner actor: Replace GetWorker and GetControls with IsControllingAddress

* Miner actor: Add exported GetAvailableBalance

* Miner actor: Add exported GetVestingFunds

* Miner actor: Remove exported monies getters

* Miner actor: types: serialize one-element structs transparently

* Address review

* Address review

* Built-in market API for deal proposal metadata (#818)

* Call exported authenticate method from PSD (#829)


Co-authored-by: zenground0 <[email protected]>

* Drop CALLER_TYPES_SIGNABLE and signable caller validation (#821)

* Market actor: Minor improvements to two exported getters (#826)

* Market actor: GetDealTermExported: Return (start_epoch, duration)

* Market actor: Export getter for deal total price

* Exported API for market deal activation state (#819)

* Paych actor: Drop account req, use AuthenticateMessage to verify sigs (#824)

* Paych actor: Drop account req, use AuthenticateMessage to verify sigs

* Address review

* Address review

* Account actor: Deprecate AuthenticateMessage (#856)

* Market actor: Export PublishStorageDeals (#857)

* Miner: Export several more methods (#863)

* Miner: Export ChangeWorkerAddress

* Miner: Export ChangePeerID

* Miner: Export WithdrawBalance

* Miner: Export ChangeMultiaddrs

* Miner: Export ConfirmUpdateWorkerKey

* Miner: Export RepayDebt

* Miner: Export ChangeOwnerAddress

* Miner: Add exported getters for PeerID & multiaddrs

* Miner: Refactor: Rename ConfirmUpdateWorkerKey to ConfirmChangeWorkerAddress

* Power actor: Export methods to CreateMiner and get miner counts (#868)

* Power: Export CreateMiner

* Power Actor: Export MinerCount and MinerConsensusCount

* Update actors/power/src/lib.rs

Co-authored-by: Alex <[email protected]>

Co-authored-by: Alex <[email protected]>

* Verifreg: Export AddVerifiedClient and GetClaims (#873)

* Verifreg: Rename AddVerifierClientParams to AddVerifiedClientParams

* Verifreg: Export AddVerifiedClient and GetClaims

* Datacap actor: Modify exported methods (#909)

* Datacap: Export Mint and Destroy

* Datacap actor: Deprecate all internal methods

* Datacap actor: Rename BalanceOf to Balance

* Datacap actor: Add Granularity method

* fix: comments on newly exported methods (#910)

* Miner: Export method to GetPendingOwner

* MarketNotifyDeal (#944)


Co-authored-by: zenground0 <[email protected]>

* Verifreg: Call AuthenticateMessage instead of validating siggys

* Multisig: Do not export any functionality (#967)

* use const for EX_DEAL_EXPIRED (#954)

* Address review

Co-authored-by: Alex <[email protected]>
Co-authored-by: ZenGround0 <[email protected]>
Co-authored-by: zenground0 <[email protected]>
Co-authored-by: Shashank <[email protected]>
shamb0 pushed a commit to shamb0/builtin-actors that referenced this pull request Jan 31, 2023
@ZenGround0 @shamb0
Call exported authenticate method from PSD (filecoin-project#829)
249d199 
Co-authored-by: zenground0 <[email protected]>
shamb0 pushed a commit to shamb0/builtin-actors that referenced this pull request Jan 31, 2023
@arajasek @anorth
@ZenGround0 @sudo-shashank @shamb0
FIP-0050: API between user-programmed actors and built-in actors (fil…
c7f4279 
…ecoin-project#1004)

* Proof of concept exported API for Account actor (filecoin-project#797)

* Export stable methods for public access (filecoin-project#807)

* Export Datacap Actor methods

* Export Init Actor methods

* Export Market Actor methods

* Export Miner Actor methods

* Export Multisig Actor methods

* Export Verifreg Actor methods

* Address review

* Restrict internal APIs of all actors (filecoin-project#809)

* Exported API method for market actor escrow/locked balance (filecoin-project#812)

* Power actor: Add exported getters for raw power (filecoin-project#810)

* Power actor: Add exported getters for raw power

* FRC-XXXX is FRC-0042

* Power actor: network_raw_power: Return this_epoch_raw_byte_power

* Power actor: miner_raw_power: Return whether above consensus min power

* Power actor: types: serialize one-element structs transparently

* Address review

* Miner actor: Add exported getters for info and monies (filecoin-project#811)

* Miner actor: Add exported getters for info and monies

* Tweak comment

* Miner actor: Replace GetWorker and GetControls with IsControllingAddress

* Miner actor: Add exported GetAvailableBalance

* Miner actor: Add exported GetVestingFunds

* Miner actor: Remove exported monies getters

* Miner actor: types: serialize one-element structs transparently

* Address review

* Address review

* Built-in market API for deal proposal metadata (filecoin-project#818)

* Call exported authenticate method from PSD (filecoin-project#829)

Co-authored-by: zenground0 <[email protected]>

* Drop CALLER_TYPES_SIGNABLE and signable caller validation (filecoin-project#821)

* Market actor: Minor improvements to two exported getters (filecoin-project#826)

* Market actor: GetDealTermExported: Return (start_epoch, duration)

* Market actor: Export getter for deal total price

* Exported API for market deal activation state (filecoin-project#819)

* Paych actor: Drop account req, use AuthenticateMessage to verify sigs (filecoin-project#824)

* Paych actor: Drop account req, use AuthenticateMessage to verify sigs

* Address review

* Address review

* Account actor: Deprecate AuthenticateMessage (filecoin-project#856)

* Market actor: Export PublishStorageDeals (filecoin-project#857)

* Miner: Export several more methods (filecoin-project#863)

* Miner: Export ChangeWorkerAddress

* Miner: Export ChangePeerID

* Miner: Export WithdrawBalance

* Miner: Export ChangeMultiaddrs

* Miner: Export ConfirmUpdateWorkerKey

* Miner: Export RepayDebt

* Miner: Export ChangeOwnerAddress

* Miner: Add exported getters for PeerID & multiaddrs

* Miner: Refactor: Rename ConfirmUpdateWorkerKey to ConfirmChangeWorkerAddress

* Power actor: Export methods to CreateMiner and get miner counts (filecoin-project#868)

* Power: Export CreateMiner

* Power Actor: Export MinerCount and MinerConsensusCount

* Update actors/power/src/lib.rs

Co-authored-by: Alex <[email protected]>

Co-authored-by: Alex <[email protected]>

* Verifreg: Export AddVerifiedClient and GetClaims (filecoin-project#873)

* Verifreg: Rename AddVerifierClientParams to AddVerifiedClientParams

* Verifreg: Export AddVerifiedClient and GetClaims

* Datacap actor: Modify exported methods (filecoin-project#909)

* Datacap: Export Mint and Destroy

* Datacap actor: Deprecate all internal methods

* Datacap actor: Rename BalanceOf to Balance

* Datacap actor: Add Granularity method

* fix: comments on newly exported methods (filecoin-project#910)

* Miner: Export method to GetPendingOwner

* MarketNotifyDeal (filecoin-project#944)

Co-authored-by: zenground0 <[email protected]>

* Verifreg: Call AuthenticateMessage instead of validating siggys

* Multisig: Do not export any functionality (filecoin-project#967)

* use const for EX_DEAL_EXPIRED (filecoin-project#954)

* Address review

Co-authored-by: Alex <[email protected]>
Co-authored-by: ZenGround0 <[email protected]>
Co-authored-by: zenground0 <[email protected]>
Co-authored-by: Shashank <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anorth anorth anorth approved these changes

@arajasek arajasek Awaiting requested review from arajasek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZenGround0 @anorth