Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change market deal metadata methods to return EX_DEAL_EXPIRED if the deal ID is used #830

Closed
anorth opened this issue Nov 10, 2022 · 1 comment · Fixed by #989
Closed

Change market deal metadata methods to return EX_DEAL_EXPIRED if the deal ID is used #830

anorth opened this issue Nov 10, 2022 · 1 comment · Fixed by #989
Labels
P3

Comments

@anorth
Copy link
Member

anorth commented Nov 10, 2022 •
edited
Loading

We added this new exit code for the deal activation state method in #819. Change the new deal metadata methods to do the same thing for consistency.

Target the integration/builtin-api branch for this.
@anorth anorth moved this to 🔖 Ready in Network v18 Nov 13, 2022
@jennijuju jennijuju added the P3 label Nov 25, 2022
@jennijuju jennijuju moved this from 🔖 Ready to 📋 Backlog in Network v18 Nov 28, 2022
@anorth anorth moved this from 📋 Nice To Haves to 🌟 In Scope in Network v18 Dec 7, 2022
@shamb0 shamb0 mentioned this issue Dec 27, 2022
Merged
@jennijuju jennijuju moved this from 🌟 In Scope to 🏗 In progress in Network v18 Jan 5, 2023
@anorth
Copy link
Member Author

anorth commented Jan 11, 2023

@shamb0 is taking this on

@anorth anorth moved this from 🏗 In progress to 👀 In review in Network v18 Jan 11, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Network v18 Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P3
Projects
No open projects
Network v18
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Market deal metadata methods to return EX_DEAL_EXPIRED if the deal ID is used shamb0/builtin-actors
3 participants
@anorth @jennijuju @sudo-shashank