Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Market actor should batch datacap token transfers #662

Closed
anorth opened this issue Sep 15, 2022 · 2 comments · Fixed by #722
Closed

Market actor should batch datacap token transfers #662

anorth opened this issue Sep 15, 2022 · 2 comments · Fixed by #722
Labels
enhancement New feature or request P2

Comments

@anorth
Copy link
Member

anorth commented Sep 15, 2022

The market actor currently makes datacap token transfers once per deal, even when many deals are published at once. This is so that it runs out of datacap balance/allowance, some deals can still succeed. A batch would simply fail if the token balance was insufficient.

The market could instead fetch the balance/allowance, and then make a single transfer for a subset of deals that falls within the datacap balance available.
@anorth anorth added enhancement New feature or request P2 x/FIP-0045 labels Sep 15, 2022
@anorth anorth moved this to Incoming in Network nv17 Sep 15, 2022
@anorth anorth mentioned this issue Sep 15, 2022
Merged
@jennijuju jennijuju moved this from Incoming to Opportunistic in Network nv17 Sep 19, 2022
@jennijuju
Copy link
Member

builtin-actors/actors/market/src/lib.rs

Line 359 in b9f6b74

// For verified deals, transfer datacap tokens from the client

@swift-mx swift-mx mentioned this issue Sep 21, 2022
Closed
@ZenGround0
Copy link
Contributor

From discussion today we're going to defer including this until post nv17

@anorth anorth moved this to 📋 Backlog in Network v18 Nov 23, 2022
@anorth anorth moved this from 📋 Backlog to 🏗 In progress in Network v18 Nov 23, 2022
@anorth anorth moved this from 🏗 In progress to 👀 In review in Network v18 Nov 23, 2022
@jennijuju jennijuju removed this from Network nv17 Nov 25, 2022
@jennijuju jennijuju linked a pull request Nov 25, 2022 that will close this issue
Market actor batch datacap token transfers #722
Merged
This was referenced Jan 12, 2023
Closed
Merged
anorth pushed a commit that referenced this issue Jan 18, 2023
@swift-mx
Market actor batch datacap token transfers (#722)
a600986 
Co-authored-by: anorth <[email protected]>
Closes #662
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Network v18 Jan 18, 2023
shamb0 pushed a commit to shamb0/builtin-actors that referenced this issue Jan 31, 2023
@swift-mx @shamb0
Market actor batch datacap token transfers (filecoin-project#722)
88acd83 
Co-authored-by: anorth <[email protected]>
Closes filecoin-project#662
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request P2
Projects
No open projects
Network v18
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Market actor batch datacap token transfers macro-ss/builtin-actors
3 participants
@anorth @ZenGround0 @jennijuju