More string consts into single file (CleverRaven#38189) #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the changes introduced in PR #37787 dropped the conditional check for character strength being *equal* to exertion required, and instead applied the "It takes some time" movement penalty to everyone (regardless of strength). And, due to the first `if` being changed to `ex >= u.get_str() + 1`, there was no case for `ex == u.get_str()`, allowing characters with a very specific strength, just 1 less than the strength needed, to avoid any movement penalty at all. Fixes #38104 The pain penalty is preserved (with comment), and a narrower condition (potentially matching 2 different strength stat values) gives the "It takes some time" message with the same movement penalty. Any character with sufficient (or more than sufficient) strength to drag the vehicle will see no message and receive no additional movement penalty.
Don't penalize strong characters for dragging vehicles
Move string consts/rename string consts
add lore documentation to the magiclysm mod
- allow build properties override from local.properties; - report values for build properties.
Updated Android build process (2020-02-21)
Added "Trap Back button" option to Android prelaunch menu
Magazine name to object
Skills were in arbitrary order, making it annoying to find and modify skills for debugging. This alphabetizes them to make devs' lives easier.
Magazine name to object
Bionic name to object
Alphabetize the debug skill wishlist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Purpose of change
Describe the solution
Describe alternatives you've considered
Testing
Additional context