Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alphabetize the debug skill wishlist #38194

Merged
merged 1 commit into from
Feb 21, 2020

Conversation

wapcaplet
Copy link
Contributor

Summary

SUMMARY: Infrastructure "Alphabetize the debug skill wish list"

Purpose of change

To make it easier to use the debug menu for player/NPC skill modification

Describe the solution

Borrows the skill-sorting routine used by src/newcharacter.cpp for the debug skill menu so they'll be in sorted order, instead of arbitrary Skill::skills order.

Describe alternatives you've considered

Going slowly mad

Testing

Used the menu to modify character skills up and down using the left/right arrow keys, and by entering direct values.

Additional context

Before (left), after (right):

image

Skills were in arbitrary order, making it annoying to find and modify
skills for debugging. This alphabetizes them to make devs' lives easier.
@ZhilkinSerg ZhilkinSerg added [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. labels Feb 21, 2020
@ZhilkinSerg ZhilkinSerg merged commit eda55f9 into CleverRaven:master Feb 21, 2020
@wapcaplet wapcaplet deleted the debug-sort-skills branch February 24, 2020 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants