"Updated vehicle dragging" update broke how it worked #38104
Comments
|
To get your version information and modlist in a convenient format go to the debug menu, select game info, then choose the last item in that menu. Something along the lines of "save report to clipboard". Then you just have to paste it! |
|
Thanks, i updated the original post |
|
I'm seeing the same behavior with a folding cart - it takes the same amount of time to move, whether it has wheels or not:
Either way, it takes 323 moves (~3-4 seconds) to push or pull the cart, no matter whether I am pushing it across sidewalk, floor, pavement, grass, or dirt:
The change in #37787 appears to cause the "It takes some time to move the X" message to be always displayed, instead of only when the character has just barely enough strength.
|
wapcaplet
added a commit
to wapcaplet/Cataclysm-DDA
that referenced
this issue
Feb 20, 2020
One of the changes introduced in PR CleverRaven#37787 dropped the conditional check for character strength being *equal* to exertion required, and instead applied the "It takes some time" movement penalty to everyone (regardless of strength). And, due to the first `if` being changed to `ex >= u.get_str() + 1`, there was no case for `ex == u.get_str()`, allowing characters with a very specific strength, just 1 less than the strength needed, to avoid any movement penalty at all. Fixes CleverRaven#38104 The pain penalty is preserved (with comment), and a narrower condition (potentially matching 2 different strength stat values) gives the "It takes some time" message with the same movement penalty. Any character with sufficient (or more than sufficient) strength to drag the vehicle will see no message and receive no additional movement penalty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Probably works the same with other vehicles but im just testing it and its the exacly same drag a "cart" with casters or without, it just take loads of time and spam "it takes some time to move the vehicle" messages.
Steps to reproduce the behavior:
1 Find or craft a vehicle that can be dragged and has casters as wheels (like a shopping cart)
2 Drag it.
3 Remove the casters and compare.
Expected behavior:
Casters should work, dragging vehicles was working nice before the update that broke them.
Versions and configuration:
Dark Days Ahead [dda],
Disable NPC Needs [no_npc_food],
Aftershock [aftershock],
C.R.I.T Expansion Mod [crt_expansion],
Magiclysm [magiclysm],
Stats Through Kills [stats_through_kills],
Stats Through Skills [StatsThroughSkills],
No Fungal Monsters [No_Fungi],
Vehicle Additions Pack [blazemod],
No Ants [No_Anthills],
Garden Pots [growable-pots],
SpeedyDex [speedydex],
Manual Bionic Installation [manualbionicinstall],
Safe Autodoc [safeautodoc]
]
The text was updated successfully, but these errors were encountered: