Adds Android click sound to Touchables #17183

akriger · 2017-12-13T17:04:44Z

Motivation

Android apps play a touch sound on press, as long as you have "Touch sounds" enabled in the settings. As and Android user, when building my app using React Native, one of the first things I noticed was that there were not any touch sounds. This is missing from React Native and there have been multiple PRs to have this implemented, but no success.

Related PRs

This PR iterates over #6825 and #11136

This PR keeps it simple by only implementing the enhancement for Android, as iOS apps typically do not use touch sounds, and follows the users' system settings for whether or not the sound is played.

Test Plan

I have manually tested this on multiple devices and emulators with zero problems

Release Notes

[ANDROID] [ENHANCEMENT] [UIManagerModule.java]- Adds Android click sound to touchables

[ANDROID] [ENHANCEMENT] [Touchable] - Adds Android click sound to touchables

pull-bot · 2017-12-13T17:06:19Z

	Warnings
⚠️	📋 Release Notes - This PR may have incorrectly formatted Release Notes.

@facebook-github-bot label Needs more information

Generated by 🚫 dangerJS

eslint-bot · 2017-12-13T17:06:53Z

Libraries/Components/Touchable/Touchable.js

+  _playTouchSound: function() {
+    UIManager.playTouchSound();
+  },
+


no-trailing-spaces: Trailing spaces not allowed.

eslint-bot · 2017-12-13T17:06:53Z

Libraries/Components/Touchable/Touchable.js

        this.touchableHandlePress(e);
      }
    }

    this.touchableDelayTimeout && clearTimeout(this.touchableDelayTimeout);
    this.touchableDelayTimeout = null;
  },
-
+


no-trailing-spaces: Trailing spaces not allowed.

eslint-bot · 2017-12-13T17:06:53Z

Libraries/Components/Touchable/Touchable.js

@@ -743,14 +743,21 @@ var TouchableMixin = {
          this._startHighlight(e);
          this._endHighlight(e);
        }
+        if(Platform.OS === 'android') {


keyword-spacing: Expected space(s) after "if".

facebook-github-bot · 2017-12-13T17:07:21Z

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot · 2017-12-14T01:33:34Z

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Update to latest version

pull-bot · 2017-12-28T16:33:26Z

@facebook-github-bot label Android

Generated by 🚫 dangerJS

facebook-github-bot · 2018-02-03T18:04:50Z

@akriger I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project.

Update to latest React Native Version

akriger · 2018-04-05T00:17:13Z

@hramos @janicduplessis is there anything else I need to do for this PR? I see one of the checks failed but, not sure if that has anything to do with my PR.

facebook-github-bot

@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Summary: Android apps play a touch sound on press, as long as you have "Touch sounds" enabled in the settings. As and Android user, when building my app using React Native, one of the first things I noticed was that there were not any touch sounds. This is missing from React Native and there have been multiple PRs to have this implemented, but no success. This PR iterates over [facebook#6825](facebook#6825) and [facebook#11136](facebook#11136) This PR keeps it simple by only implementing the enhancement for Android, as iOS apps typically do not use touch sounds, and follows the users' system settings for whether or not the sound is played. I have manually tested this on multiple devices and emulators with zero problems [ANDROID] [ENHANCEMENT] [UIManagerModule.java]- Adds Android click sound to touchables [ANDROID] [ENHANCEMENT] [Touchable] - Adds Android click sound to touchables Closes facebook#17183 Differential Revision: D7560327 Pulled By: hramos fbshipit-source-id: ce1094c437541bc677c7d64b0dba343dd9574422

Summary: Currently, every time a touchable is pressed on Android, a system sound is played. It was added in the PR #17183. There is no way to disable it, except disabling touch on sound on the system level. I am pretty sure there are cases when touches should be silent and there should be an option to disable it. Related PRs - #17183, #11136 [Android][added] - Added a touchSoundDisabled prop to Touchable. If true, doesn't system sound on touch. Pull Request resolved: #24666 Differential Revision: D15166582 Pulled By: cpojer fbshipit-source-id: 48bfe88f03f791e3b9c7cbd0e2eed80a2cfba8ee

akriger added 2 commits December 13, 2017 11:29

Adds Touchable Click Sound for Android

407eba5

Adds Touchable Click Sound for Android

ea854a5

eslint-bot reviewed Dec 13, 2017

View reviewed changes

keyword-spacing

f02709a

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 14, 2017

akriger added 3 commits December 18, 2017 19:51

Merge branch 'master' into master

4c19c41

Merge branch 'master' into master

95ba232

Merge pull request #1 from facebook/master

7d6eb25

Update to latest version

Merge branch 'master' into master

11ebd7e

Merge pull request #2 from facebook/master

2970a33

Update to latest React Native Version

hramos added the Android label Mar 13, 2018

react-native-bot added Feature Request 🌟 Ran Commands One of our bots successfully processed a command. labels Mar 16, 2018

janicduplessis removed the Android label Mar 18, 2018

react-native-bot added Platform: Android Android applications. Ran Commands One of our bots successfully processed a command. labels Mar 18, 2018

janicduplessis removed the Android 🤖 label Mar 19, 2018

hramos added Type: Enhancement A new feature or enhancement of an existing feature. and removed 🌟Feature Request labels Mar 19, 2018

facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Apr 9, 2018

facebook-github-bot approved these changes Apr 9, 2018

View reviewed changes

facebook-github-bot closed this in 722f88c Apr 10, 2018

janicduplessis mentioned this pull request Apr 14, 2018

[Accessibility] Touchable components need "Touch Sounds" for more native feeling. #6188

Closed

janicduplessis mentioned this pull request Apr 19, 2019

Adds touchSoundEnabled prop to Touchables #11136

Closed

yurykorzun mentioned this pull request Apr 30, 2019

Adds a touchSoundDisabled prop to Touchable #24666

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds Android click sound to Touchables #17183

Adds Android click sound to Touchables #17183

akriger commented Dec 13, 2017 •

edited

Loading

pull-bot commented Dec 13, 2017 •

edited

Loading

eslint-bot Dec 13, 2017

eslint-bot Dec 13, 2017

eslint-bot Dec 13, 2017

facebook-github-bot commented Dec 13, 2017

facebook-github-bot commented Dec 14, 2017

pull-bot commented Dec 28, 2017 •

edited

Loading

facebook-github-bot commented Feb 3, 2018

akriger commented Apr 5, 2018

facebook-github-bot left a comment

Adds Android click sound to Touchables #17183

Adds Android click sound to Touchables #17183

Conversation

akriger commented Dec 13, 2017 • edited Loading

Motivation

Related PRs

Test Plan

Release Notes

pull-bot commented Dec 13, 2017 • edited Loading

eslint-bot Dec 13, 2017

Choose a reason for hiding this comment

eslint-bot Dec 13, 2017

Choose a reason for hiding this comment

eslint-bot Dec 13, 2017

Choose a reason for hiding this comment

facebook-github-bot commented Dec 13, 2017

facebook-github-bot commented Dec 14, 2017

pull-bot commented Dec 28, 2017 • edited Loading

facebook-github-bot commented Feb 3, 2018

akriger commented Apr 5, 2018

facebook-github-bot left a comment

Choose a reason for hiding this comment

akriger commented Dec 13, 2017 •

edited

Loading

pull-bot commented Dec 13, 2017 •

edited

Loading

pull-bot commented Dec 28, 2017 •

edited

Loading