Update to latest React Native Version #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Closes #17929 Differential Revision: D6953331 Pulled By: hramos fbshipit-source-id: d7b50b18a2c2e5826ed2af5f5ef08ed9aa2878bf
Differential Revision: D6943293 fbshipit-source-id: cb67b063b77e8f89712fb437fc5471b7f874c482
Summary: … prevent unknown websocket IDs from crashing on Android (show warning on development builds instead) This PR addresses #3346; an unknown websocket ID should produce a warning during development, but not cause crashes in production RN apps. This PR was created by satya164's request, and was inspired by tanthanh289's suggestion on #3346's thread. On Android, create a websocket using a service like Pusher (`pusher-js` npm package) or manually, and then induce removal of its websocket ID. Result should be a red warning screen during development, and no crash in the app's release variant. [ANDROID] [BUGFIX] [WebSocket] - Prevent unknown websocket IDs from crashing on Android Closes #17884 Differential Revision: D6954038 Pulled By: hramos fbshipit-source-id: b346d80d7568996b8819c0de54552abb534cbfae
Reviewed By: mzlee Differential Revision: D6954781 fbshipit-source-id: 0ec78e6f7f2780951ac008e9b12f41cfd5441ed5
Reviewed By: bvaughn Differential Revision: D6953225 fbshipit-source-id: f96e3cec57cce397d46d49115dd3734a33427992
Summary: Closes #17934 Differential Revision: D6956755 Pulled By: hramos fbshipit-source-id: 518171156638effc279f17b38c379e029ed23ba0
Reviewed By: adamjernst Differential Revision: D6956725 fbshipit-source-id: d223aa238dbb67190a1c244c7d482fc95005ccb0
Reviewed By: adamjernst Differential Revision: D6959356 fbshipit-source-id: 77c61998f23a6acd7cdfe2c87d8760a23d957800
Summary: The current implementation of DevLoadingView for iPhone currently gives a static height of `22` and does not take into account iPhoneX screen dimensions. Devices: All iPhone devices currently available with Xcode v9.2 SDK: 8.1, 9, 10, 11 Validate resize only occurs on iPhone X devices and others remain consistent. Before:  After:  [GENERAL][ENHANCEMENT][{React}] - Improvements to DevLoadingView for iPhone X Closes #17936 Differential Revision: D6962962 Pulled By: shergin fbshipit-source-id: e11d9386544fe19a9195e22a03e12f64e934cad7
Summary: This is reimagining of interoperability layer between Yoga and ShadowViews (at least in Yoga -> RN part). Goals: * Make it clear and easy. * Make clear separation between "what layout what", now parent always layout children, noone layout itself. * Make possible to interleave Yoga layout with custom imperative layout (may be used in SafeAreaView, Text, Modal, InputAccessoryView and so on). Reviewed By: mmmulani Differential Revision: D6863654 fbshipit-source-id: 5a6a933874f121d46f744aab99a31ae42ddd4a1b
Summary: Every `job` is run in a separate container and so, `checkout` step is required for the Git host to be added to `~/.ssh/known_hosts`. Without this step, it will timeout after 10 minutes waiting for you to add (yes) or reject (no) from known hosts (we get this prompt when we checkout from a host for the very first time). Closes #17956 Differential Revision: D6968130 Pulled By: hramos fbshipit-source-id: 6d62166fd375f8f408cf5f18b188f841d035d97f
Reviewed By: flarnie Differential Revision: D6965585 fbshipit-source-id: 48c20d0010f4daf83272a36b3bdaca94493ab8fa
Differential Revision: D6970534 fbshipit-source-id: da1df549b6157e5ec684cf4eed5f411740a73ed0
Summary: A collection of Unicode sequences for various characters and emoji. - More explicit than using the sequences directly in code. - Source code should be limitted to ASCII. - Less chance of typos. Reviewed By: TheSavior Differential Revision: D6969065 fbshipit-source-id: c11ec96b74f5dfa7c624a3c53f3c29f6284a82b3
Reviewed By: TheSavior Differential Revision: D6945233 fbshipit-source-id: 9630a72e4a7c88ca282392c374ca88326f282713
Reviewed By: rafeca Differential Revision: D6965150 fbshipit-source-id: 332c8202f350e2014fedb9790f3d895222fb4f8d
Summary: This commit removes special cases for linking iOS and Android platforms. A previous commit opened up link and other commands for other platforms to provide their own behaviors. It left special cases in tact for iOS and Android. This PR removes the special case. - Added jest tests related to the link command. - Ran the `link` and `unlink` commands for iOS and Android and confirmed no changes. #17745 <!-- Help reviewers and the release process by writing your own release notes **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.** CATEGORY [----------] TYPE [ CLI ] [-------------] LOCATION [ DOCS ] [ BREAKING ] [-------------] [ GENERAL ] [ BUGFIX ] [-{Component}-] [ INTERNAL ] [ ENHANCEMENT ] [ {File} ] [ IOS ] [ FEATURE ] [ {Directory} ] |-----------| [ ANDROID ] [ MINOR ] [ {Framework} ] - | {Message} | [----------] [-------------] [-------------] |-----------| [CATEGORY] [TYPE] [LOCATION] - MESSAGE EXAMPLES: [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see --> [CLI][FEATURE][local-cli/link/link.js] - Removes special cases for linking in iOS and Android. Closes #17961 Differential Revision: D6975951 Pulled By: hramos fbshipit-source-id: 8dd5da35619e2124ce4b3b18db8b694757792363
Reviewed By: cpojer Differential Revision: D6976161 fbshipit-source-id: 0cf20f4b2372997a8aac41cc07a9bdd641a93ad4
Reviewed By: bnham Differential Revision: D6938018 fbshipit-source-id: c79853ddf835acab86a16ebd539874d29d3aa60a
Summary: These tests have not run for one reason or another since the migration from Travis. They are not passing, and are commented out to avoid flagging new PRs as breaking. These tests need to be fixed and re-enabled ASAP. Closes #17959 Differential Revision: D6976781 Pulled By: hramos fbshipit-source-id: 712a09877d0597c12cafa741779b471680b7d2db
Summary: Visually show files merged with conflicts when running `react-native-git-upgrade`. <!-- Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html Happy contributing! --> After running `react-native-git-upgrade`, files with conflicts are not immediately recognised visually. With this patch, files with conflicts are highlighted in red.  <!-- Help reviewers and the release process by writing your own release notes **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.** CATEGORY [----------] TYPE [ CLI ] [-------------] LOCATION [ DOCS ] [ BREAKING ] [-------------] [ GENERAL ] [ BUGFIX ] [-{Component}-] [ INTERNAL ] [ ENHANCEMENT ] [ {File} ] [ IOS ] [ FEATURE ] [ {Directory} ] |-----------| [ ANDROID ] [ MINOR ] [ {Framework} ] - | {Message} | [----------] [-------------] [-------------] |-----------| [CATEGORY] [TYPE] [LOCATION] - MESSAGE EXAMPLES: [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see --> [CLI] [ENHANCEMENT] [react-native-git-upgrade/cliEntry.js] - Print files with conflicts in red. Closes #17947 Differential Revision: D6977042 Pulled By: hramos fbshipit-source-id: 3c67561ea3acbee227a7a0cf42857af4fb75c75c
Summary: Signed-off-by: Evan J Brunner <[email protected]> <!-- Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html Happy contributing! --> Motivation can be found in #17899 This `RNTester/js/http_test_server.js` is part of a internal websocket test suite / devtool. Can be tested with `curl -D - localhost:5556` observing that the `Set-Cookie: wstest=OK; Path=\` header is present, and the service throws no exceptions.. etc [INTERNAL][MINOR][./RNTester/js/http_test_server.js] - fixed set cookie with connect framework <!-- Help reviewers and the release process by writing your own release notes **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.** CATEGORY [----------] TYPE [ CLI ] [-------------] LOCATION [ DOCS ] [ BREAKING ] [-------------] [ GENERAL ] [ BUGFIX ] [-{Component}-] [ INTERNAL ] [ ENHANCEMENT ] [ {File} ] [ IOS ] [ FEATURE ] [ {Directory} ] |-----------| [ ANDROID ] [ MINOR ] [ {Framework} ] - | {Message} | [----------] [-------------] [-------------] |-----------| [CATEGORY] [TYPE] [LOCATION] - MESSAGE EXAMPLES: [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see --> Closes #17900 Differential Revision: D6977087 Pulled By: hramos fbshipit-source-id: af6205343fccf69c57e0c26a85a5b04d61288a23
Reviewed By: fkgozali Differential Revision: D6955828 fbshipit-source-id: 1a77b652a7e372acf961a0b0772ae93a999b90b1
Summary: There seems to be a rounding error in the android code for line height, so that for some fonts and at some combinations of line height and font size the actual height of the elements seems to be slightly too short. I've identified one issue that I mentioned here #10712 (comment) that could at least explain some of the problem. That when the line-height minus the original sum of the absolute value of top and bottom from the metrics, happens to be an odd number, the division by two causes a rounding error of 1, so that the actual line height is 1pt less than it should. The fix uses floating point division instead of integer division, and rounds (arbitrarily) the negative values up and the positive values down so that the total is still the correct for odd numbers. It turns out that only ascent and descent is used to give the actual line-height between lines in the same text-element. The top and bottom values are only used for padding the top and bottom of the text. So when the line-height is greater than the font size and the extra padding this PR sets the ascent and descent to the same value as the top and bottom respectively. I've renamed the shouldIncreaseAllMetricsProportionally test to evenLineHeightShouldIncreaseAllMetricsProportionally and added an extra assertion to check that bottom-top still equals the line height. Added another test oddLineHeightShouldAlsoWork that is similar but uses an odd number for the line height to test that it still works with odd numbers. This test only uses the sum of the values so that it's indifferent to what value the implementation chooses to round up or down. Improvement on #16448 Fix line-height calculation on Android. | Before | After | | ------------- |-------------| |  |  | (All three columns have font size 16 and lineHeight: 32. The first one is has fixed height 9*32, the second is 9 Text elements, the last is one text element with lots of text limited to 9 lines, so they should be the same height. ) Closes #17952 Differential Revision: D6980333 Pulled By: hramos fbshipit-source-id: 0a501358cfbf7f139fca46056d0d972b1daf6ae3
Summary: Don't want anyone accidentally mutating it. Also make deepFreezeAndThrowOnMutationInDev easier to use with nice flow typing. Reviewed By: yungsters Differential Revision: D6974089 fbshipit-source-id: 0f90e7939cb726893fa353a4f2a6bbba701205bc
Summary: Android equivalent of #15066 Tested that download progress shows up properly when reloading the app. [ANDROID] [FEATURE] [DevSupport] - Show bundle download progress on Android Closes #17809 Differential Revision: D6982823 Pulled By: hramos fbshipit-source-id: da01e42b8ebb1c603f4407f6bafd68e0b6b3ecba
Reviewed By: TheSavior Differential Revision: D6983446 fbshipit-source-id: c8ce4b1c7836654910db84c9cd4b6d0bcec8ae27
Reviewed By: mdvacca Differential Revision: D6957397 fbshipit-source-id: 172905861fbb1c9ed45149e33b406c28ad616cd7
Reviewed By: sebmarkbage Differential Revision: D6934518 fbshipit-source-id: 1f626f79a74fb199925644e8b16238aa17d40e1f
Reviewed By: sebmarkbage Differential Revision: D6982785 fbshipit-source-id: 7bbcc5416e1d1a3a577328349a7c18af5c0f8577
Reviewed By: achen1 Differential Revision: D7195840 fbshipit-source-id: d596e3ada8fe48577b91295721d41c0afd33087f
Reviewed By: achen1 Differential Revision: D7195373 fbshipit-source-id: 6611726c3e1f92f387e00e733b1b8909a3e9edc2
Reviewed By: achen1 Differential Revision: D7205127 fbshipit-source-id: 6c27070806de36cab7adf9c392a10c815aee90d4
Reviewed By: yungsters Differential Revision: D7209495 fbshipit-source-id: e4b247e947b3463ea1200298e6078c7485d636e7
Reviewed By: yungsters Differential Revision: D7209560 fbshipit-source-id: fd0c55c4f69648927380d12ad9a6b9bcb98047eb
Reviewed By: alex1kom Differential Revision: D7177071 fbshipit-source-id: 685d40e564d391d18592cedfcc12d8ac743a5331
Reviewed By: yungsters Differential Revision: D7215800 fbshipit-source-id: 175f769a2b1fc67e72b10e113a96eb4167437ab0
Summary: Added Android ID as one of the constants returned by AndroidInfoModule Reviewed By: fkgozali Differential Revision: D7206029 fbshipit-source-id: 110b33235d3023b4a4607d37acc3440cfe735cef
Reviewed By: yungsters Differential Revision: D7215114 fbshipit-source-id: 867a7b897f27d415269c11572708afeb570b4be0
Reviewed By: yungsters Differential Revision: D7218964 fbshipit-source-id: f4b25a533b7e150c978863ff8411dc80937a4fed
Summary: tvOS and iOS workflows were flaky, apparently due to a stale cache that contained a problematic version of the Metro dependency. Thanks to motiz88 for identifying the potential cause of flakiness in react-native-community/releases#2 (comment). https://circleci.com/workflow-run/440180a2-e888-4f27-bec9-b8e5d9be6708 [GENERAL] [MINOR] [CI] - Resolve iOS, tvOS failures in Circle Closes #18304 Differential Revision: D7220150 Pulled By: hramos fbshipit-source-id: 0f5e68c779dfce44e6deb8b813a3ac9e25a2ab97
Reviewed By: yungsters Differential Revision: D7215391 fbshipit-source-id: fa144c0dc3fd897864403b589e943ea88e78a999
Reviewed By: BYK Differential Revision: D7214924 fbshipit-source-id: 4f50ec27e2dceb18e9ef82e741675df295235d74
Summary: Moving towards reusing existing scripts to ensure local and CI tests are kept in sync. Closes #18307 Differential Revision: D7222664 Pulled By: hramos fbshipit-source-id: ecce91e32159c55b19c29eab69a6754642f02236
Summary: The flow type for View using createReactClass was essentially `any`, allowing any Prop to be passed in, only pseudo enforced at run time via propTypes. This diff converts View away from createReactClass and instead uses ReactNative.NativeComponent. This was previously typed as any as well which didn't buy us much. This change converts View to be an ES6 React class component to ensure proptypechecking, and exposes the methods copied from NativeMethodsMixin. Reviewed By: yungsters Differential Revision: D5933888 fbshipit-source-id: eae63b818203e0e86741f9f154ec9cf3498369e2
Reviewed By: gabelevi Differential Revision: D7208080 fbshipit-source-id: 81380aca39b7a74646a4a44af1e5571bc5629b77
Summary: [GENERAL] [MINOR] [./scripts/validate-android-test-env.sh] - Fix buck version check Closes #18311 Differential Revision: D7227452 Pulled By: hramos fbshipit-source-id: c7b32afc36821fbb2462317581ae32d3b257de03
Reviewed By: fkgozali Differential Revision: D7226404 fbshipit-source-id: b5637dee9a4f10daf0682e46f1ec8920ea03ae33
Reviewed By: fkgozali Differential Revision: D7227752 fbshipit-source-id: 3577c86b416a7c04190063243839e98e2a80ec7f
Reviewed By: TheSavior Differential Revision: D7209266 fbshipit-source-id: 9f9ce66121ff375e5a5d965d58f4137616407853
Differential Revision: D7216928 fbshipit-source-id: 9e8c456c7e94ec3456061ad5c699c0eae30cbe5e
Differential Revision: D7194366 fbshipit-source-id: 676f2db2e493230b8d9698941f003ec4e96f15ea
…atforms Summary: Don't lock out other non-iOS platforms (e.g. Windows) with an overly specific check. This change allows this JS file to be re-used instead of copied and modified. There was one other instance of this pattern, but I'll submit it separate for easier cherry-picking. Tested Android and iOS playground on simulators. [GENERAL] [ENHANCEMENT] - some core ReactNative JS library files will be easier to re-use across RN platforms. Closes #18308 Differential Revision: D7230803 Pulled By: hramos fbshipit-source-id: 11e03183535a7453cee00dc1e795c27f2fd2bf5d
Summary: Add correct dependencies and linker flags to the HelloWorld template Xcode project so that HelloWorld-tvOSTests builds correctly for release builds. Fixes #18288 . Tested with `react-native init --version=https://github.com/dlowder-salesforce/react-native#tvos-init-release-fix` . [IOS][BUGFIX][ local-cli/templates/ios/HelloWorld ]- fix release build for tvOS Closes #18337 Differential Revision: D7240376 Pulled By: hramos fbshipit-source-id: a4ad219e7d6b06bd6928d55ed7398f8fc9352e72
Reviewed By: adiphos, mantong01 Differential Revision: D7198155 fbshipit-source-id: 360955de7ed686170a23b9883058e3137e17b277
Reviewed By: mdvacca Differential Revision: D7201334 fbshipit-source-id: 50929b4294188cd5a2a8ffa2080c38c0a9983535
Summary: `<Image resizeMode="repeat" />` for Android, matching the iOS implementation (#7968). (Non-goal: changing the component's API for finer-grained control / feature parity with CSS - this would be nice in the future) As requested in e.g. #14158. Given facebook/fresco#1575, and lacking the context to follow the specific recommendations in facebook/fresco#1575 (comment), I've opted for a minimal change within RN itself. It's likely that performance can be improved by offloading this work to Fresco in some clever way; but I'm assuming that the present naive approach is still an improvement over a userland implementation with `onLayout` and multiple `<Image>` instances. - Picking up on a TODO note in the existing code, I implemented `MultiPostprocessor` to allow arbitrary chaining of Fresco-compatible postprocessors inside `ReactImageView`. - Rather than extensively refactor `ImageResizeMode`, `ReactImageManager` and `ReactImageView`, I mostly preserved the existing API that maps `resizeMode` values to [`ScaleType`](http://frescolib.org/javadoc/reference/com/facebook/drawee/drawable/ScalingUtils.ScaleType.html) instances, and simply added a second mapping, to [`TileMode`](https://developer.android.com/reference/android/graphics/Shader.TileMode.html). - To match the iOS rendering exactly for oversized images, I found that scaling with a custom `ScaleType` was required - a kind of combination of `CENTER_INSIDE` and `FIT_START` which Fresco doesn't provide - so I implemented that as `ScaleTypeStartInside`. (This is, frankly, questionable as the default behaviour on iOS to begin with - but I am aiming for parity here) - `resizeMode="repeat"` is therefore unpacked by the view manager to the effect of: ```js view.setScaleType(ScaleTypeStartInside.INSTANCE); view.setTileMode(Shader.TileMode.REPEAT); ``` And the added postprocessing in the view (in case of a non-`CLAMP` tile mode) consists of waiting for layout, allocating a destination bitmap and painting the source bitmap with the requested tile mode and scale type. Note that as in #17398 (comment), I have neither updated nor tested the "Flat" UI implementation - everything compiles but I've taken [this comment](#12770 (comment)) to mean there's no point in trying to wade through it on my own right now; I'm happy to tackle it if given some pointers. Also, I'm happy to address any code style issues or other feedback; I'm new to this codebase and a very infrequent Android/Java coder. Tested by enabling the relevant case in RNTester on Android. | iOS | Android | |-|-| | <img src=https://user-images.githubusercontent.com/2246565/34461897-4e12008e-ee2f-11e7-8581-1dc0cc8f2779.png width=300>| <img src=https://user-images.githubusercontent.com/2246565/34461894-40b2c8ec-ee2f-11e7-8a8f-96704f3c8caa.png width=300> | Docs update: facebook/react-native-website#106 [ANDROID] [FEATURE] [Image] - Implement resizeMode=repeat Closes #17404 Reviewed By: achen1 Differential Revision: D7070329 Pulled By: mdvacca fbshipit-source-id: 6a72fcbdcc7c7c2daf293dc1d8b6728f54ad0249
Summary: Utilizing ES6 Classes instead of createReactClass lets us actually enforce the way Text is used via Flow. Reviewed By: fkgozali Differential Revision: D7227755 fbshipit-source-id: 8e8285f9ebb3783a0dc4837c37c163178910ff9f
Summary: The project at large switched to MIT last month. A PR that was opened prior to the change was merged, this PR updates the file to use the correct license. None, trivial PR [ANDROID] [MINOR] [Image] Update license Closes #18343 Differential Revision: D7252836 Pulled By: hramos fbshipit-source-id: b7c207c782f4bf19c12d121e86f394e52326a5ab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
(Write your motivation here.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/react-native-website, and link to your PR here.)
Release Notes