Update to latest version #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The change enabling virtualization in nested lists contained a hidden assumption that nested lists would only appear within the *cells* of a parent list. If a list header or footer component contains a `VirtualizedList`, that child list won't be wrapped in a `CellRenderer` component and therefore won't have access to `virtualizedCellRenderer` through its context. This causes an error when the child list tries to access the `cellKey` property on an undefined object. This change wraps the header/footer views in a `VirtualizedCellWrapper` component which supplies that context properly. Reviewed By: sahrens Differential Revision: D6603342 fbshipit-source-id: 4d2d82f04947048a16ec9968121d8ecc8c95655a
Reviewed By: mhorowitz Differential Revision: D6594498 fbshipit-source-id: 67f281ded088bdbad3eb1e173882d4328c1fdc93
Summary: If we draw using `drawRect:` with possible transparent pixels, we have to have `isOpaque = YES`. https://developer.apple.com/documentation/uikit/uiview/1622622-isopaque Differential Revision: D6609013 fbshipit-source-id: e483fd38b09c07e33b8b424d22c7a1adf81e6916
Summary: The previous file/class name convention seemed cool... but now it drives me BANANAS! It makes all this code really hard to maintain. So, evething were renamed following common modern RN convention. Reviewed By: mmmulani Differential Revision: D6605090 fbshipit-source-id: 88ca13d793a5d2adaac2b7922ec6bd4654aacec5
Reviewed By: achen1 Differential Revision: D6606265 fbshipit-source-id: d432661b5f8aa2b7600b1140e1617aab852f343e
…eReactSubviews` events Summary: Motivation: * Current implementation of `didUpdateReactSubviews` relies on `processUpdatedProperties:parentProperties:` method of RCTShadowView, which we plan to remove. * The existing implementation does not call handlers on unmounted nodes (because they are not part of traversing tree), which is not correct. * The current implementation is tight with RCTComponentData, which is conceptually wrong, it should be a UIManager thing. * The new implementation must be much more performant because of simplicity. (We can measure it only after removing `processUpdatedProperties`.) Reviewed By: mmmulani Differential Revision: D6595780 fbshipit-source-id: a517207c17b5d5db839c9ce99a37136292acf78c
Summary: The `-[RCTShadowView viewName]` prop must exist, we don't need special handling for this case. Reviewed By: mmmulani Differential Revision: D6596375 fbshipit-source-id: 3e99a62bd6296e0285156f03dc2ac93db7f630e5
Summary: Nobody uses it. If the reference to the bridge is available (which is should be case for testing purposes at least), it is easy to get same information. Reviewed By: mmmulani Differential Revision: D6596376 fbshipit-source-id: 066eeb1e9465b4e0cc9d9b5b6bf41722450870e4
Reviewed By: mhorowitz Differential Revision: D6601992 fbshipit-source-id: 4bd69f90943b14286e5618c70fc7eaca689fb02c
Summary: This should help make it clearer, at a glance, which specific step is failing. Run on Circle. Workflows will now show that Node 8 JS tests are green, but Node 6 JS tests are not. Lint/flow checks are also not green. Previously, it would be necessary to open the two test-node workflows to investigate which particular test failed. Given these tests and checks tend to break often, the additional clarity would be helpful. <img width="485" alt="screen shot 2017-12-20 at 9 40 07 am" src="https://user-images.githubusercontent.com/165856/34220526-ce3d3b26-e569-11e7-803f-0e4bf1090f2f.png"> Closes #17293 Differential Revision: D6612623 Pulled By: hramos fbshipit-source-id: c84351da50916e72e52c4271e2a31c16f6cdfbb9
Summary: This was introduced as part of a codemod a few months back. Hopefully this edit makes the example code clearer. Closes #17189 Differential Revision: D6613378 Pulled By: hramos fbshipit-source-id: da7263b3ce2b5c45d6e312807c88743fe10cd15d
Reviewed By: mhorowitz Differential Revision: D6613463 fbshipit-source-id: 2553a0475ade061f3b70ffce90fcf4e0ceb7d9fa
Reviewed By: mjesun Differential Revision: D6613447 fbshipit-source-id: 4d03cf86427c7ccd8ee471078d3798ab21aee933
Summary: It's always bothered that we have this protocol and I figured it could just be merged with RCTWrapperViewController. Closes #17290 Reviewed By: mmmulani Differential Revision: D6611544 Pulled By: javache fbshipit-source-id: a50b9d5adbeb2c48dbadbbfc1c77ccf6d1aae144
Summary: grabbou: "This has been recently added to Node 8.x. Since it makes our tests to fail, I decided to do a workaround that works for all the versions." Originally patched in `0.52-stable` by grabbou Fixes Node 6 JavaScript tests. Closes #17298 Differential Revision: D6616521 Pulled By: hramos fbshipit-source-id: 7256450d824a60a14006af7a68191222b3a5041a
… updateView:]` Differential Revision: D6596375 fbshipit-source-id: f8b0ea2dafbf997a18e9c86fb279682d31b06d0e
Reviewed By: mjesun Differential Revision: D6617297 fbshipit-source-id: 5216f2862cbf7707a57c4257f0e2c93f9dfab667
Reviewed By: emilsjolander Differential Revision: D6611904 fbshipit-source-id: f01ac144159c1b333d8deb8cbb5ba0288e4bf7a4
Reviewed By: adamjernst Differential Revision: D6618153 fbshipit-source-id: 188e2ca3cc78efad6e71f0a22547e26abf2f62e1
Reviewed By: fromcelticpark Differential Revision: D6502049 fbshipit-source-id: 31a611cea4c017877c3ce2f7e9a3503723af4c2d
Summary: This PR fixes the problem with dev loading view on KitKat and older Android devices after #16596 Install RNTester app on Android API 19 or lower device. See green loading view show up under status bar. Do the same with full screen theme set and see it show up correctly at the top of the screen. Verify the green loading bar displays correctly on devices with API > 19 too. This fixes an issue introduced in #16596 [ANDROID][MINOR][DevSupport] - Fix green dev loading bar on Android Kitkat and below Closes #17305 Differential Revision: D6621077 Pulled By: achen1 fbshipit-source-id: 3b4216af535d7db5c96d137f20004fe2651b1dc9
Summary: Test Plan Rebuilt Docker images locally, confirmed successful image build. Can later be reproed with ``` npm run test-android-setup npm run test-android-build npm run test-android-run-unit-tests ``` Note that unit tests are failing in master, but in this PR we can repro the same failure. Closes #17313 Differential Revision: D6624899 Pulled By: hramos fbshipit-source-id: 42b8cd708ec2a02399bb6ef30fd73faba2646f79
Summary: Setting `windowSize = 0` doesn't make sense. Let's make sure we catch this problem in the constructor so that it doesn't cause inexplicable list behavior. Also fixed an invariant in `VirtualizeUtils` that is meant to prohibit non-monotonically-increasing offset arrays. As written, the invariant condition can never actually be violated. Reviewed By: sahrens Differential Revision: D6625302 fbshipit-source-id: b2a983cbe7bb5fbe0aed7c5d59e69a8a00672993
Reviewed By: emilsjolander Differential Revision: D6619293 fbshipit-source-id: c1632efd97f47696b7f8bb1b3e763de92c707287
Reviewed By: hramos Differential Revision: D6626785 fbshipit-source-id: bb7c89499bc7c72e24dabd82899c3d9c49874101
Summary: WIP. Closes #17295 Differential Revision: D6628523 Pulled By: hramos fbshipit-source-id: ac2833e99de9e94340b8027469cc74a5b7379962
Reviewed By: ttsugriy Differential Revision: D6630280 fbshipit-source-id: 6355d4b64a39feb000d5a104f39733a90fc5a31e
Summary: android-setup.html does not seem to exist. https://facebook.github.io/react-native/docs/android-setup.html (404) Closes #17324 Differential Revision: D6630732 Pulled By: hramos fbshipit-source-id: c1bd4750e3b72a0b1542a75f50d404807eabb8f1
Summary: <!-- Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html Happy contributing! --> (Write your motivation here.) (Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!) (If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/react-native-website, and link to your PR here.) <!-- Help reviewers and the release process by writing your own release notes **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.** CATEGORY [----------] TYPE [ CLI ] [-------------] LOCATION [ DOCS ] [ BREAKING ] [-------------] [ GENERAL ] [ BUGFIX ] [-{Component}-] [ INTERNAL ] [ ENHANCEMENT ] [ {File} ] [ IOS ] [ FEATURE ] [ {Directory} ] |-----------| [ ANDROID ] [ MINOR ] [ {Framework} ] - | {Message} | [----------] [-------------] [-------------] |-----------| [CATEGORY] [TYPE] [LOCATION] - MESSAGE EXAMPLES: [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see --> Closes #17326 Differential Revision: D6630825 Pulled By: hramos fbshipit-source-id: f2c0369e3dc5b279aba96c8307b742693be1494c
Summary: Use newer Docker image and add script that rebuilds the image locally Rebuilding should be rarely needed, but in this case we did need a newer BUCK version To run tests locally: ``` npm run test-android-setup npm run test-android-build npm run test-android-run-unit-test ``` If a newer android-base image is needed, just run `npm run test-android-build-base` to rebuild the image locally. Ping hramos if the Docker hub image is too out of date. Closes #17325 Differential Revision: D6630793 Pulled By: hramos fbshipit-source-id: ec76ec86aec0debf914649b7ec5fdafccf28fec7
Reviewed By: davidaurelio Differential Revision: D6633160 fbshipit-source-id: ce45cae413959c232cb18b4b5ad51f04a52410a4
Reviewed By: mzlee Differential Revision: D6632262 fbshipit-source-id: 1ec3ba232e573b9cbc892f23827f9a7c5df34106
Summary: URLs were updated to use HTTPS protocol <!-- Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html Happy contributing! --> Improves security and privacy. I tested all urls to insure that the destination supported https. This is an update to Docs only. [ DOCS ] [ ENHANCEMENT ] -URLs were updated to use HTTPS protocol <!-- Help reviewers and the release process by writing your own release notes **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.** CATEGORY [----------] TYPE [ CLI ] [-------------] LOCATION [ DOCS ] [ BREAKING ] [-------------] [ GENERAL ] [ BUGFIX ] [-{Component}-] [ INTERNAL ] [ ENHANCEMENT ] [ {File} ] [ IOS ] [ FEATURE ] [ {Directory} ] |-----------| [ ANDROID ] [ MINOR ] [ {Framework} ] - | {Message} | [----------] [-------------] [-------------] |-----------| [CATEGORY] [TYPE] [LOCATION] - MESSAGE EXAMPLES: [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see --> Closes #17332 Differential Revision: D6635123 Pulled By: hramos fbshipit-source-id: f1d8b1a5268eb27d55198dd3d8a2f0aab20c405e
Reviewed By: alexeylang Differential Revision: D6581907 fbshipit-source-id: ca4bd4beef6d75305133a2b2c7de62e65e5aa3da
Reviewed By: alexeylang Differential Revision: D6596304 fbshipit-source-id: 0285611cfdd66ce5bdfa503c9fe8f1963a0c583f
Reviewed By: mzlee Differential Revision: D6638538 fbshipit-source-id: 4b11b8f4f88aa533ac0467348df36e5780bfbb70
Summary: This is a leftover from recent changes in D6595780 where a prop application step was moved out to separare mount block. Differential Revision: D6640736 fbshipit-source-id: 70de0f55f992a7912e222ec4bf9ade1c9bad99f2
Summary: Buck is failing due to missing args: https://circleci.com/gh/facebook/react-native/29268 Closes #17346 Differential Revision: D6642181 Pulled By: hramos fbshipit-source-id: 399d3c5f197ae0de9748a592def945c14ac1d348
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pull