Adds a touchSoundDisabled prop to Touchable #24666
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
react-native-bot
added
the
No CLA
|
@yurykorzun before I can land this, would you mind signing the FB CLA at code.facebook.com/cla? |
Done! |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
react-native-bot
removed
the
No CLA
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @yurykorzun in 45e77c8. When will my fix make it into a release? | Upcoming Releases |
Summary
Currently, every time a touchable is pressed on Android, a system sound is played. It was added in the PR #17183. There is no way to disable it, except disabling touch on sound on the system level. I am pretty sure there are cases when touches should be silent and there should be an option to disable it.
Related PRs - #17183, #11136
Changelog
[Android][added] - Added a touchSoundDisabled prop to Touchable. If true, doesn't system sound on touch.
Test Plan
Tested my changes on an Android emulator.