-
-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makes an arrayLimit configurable #43
Comments
Hi! I'm not sure how I was supposed to know that your issue over in In any case, the default for this library is an arrayLimit of 100. I do not plan to add the ability to configure anything If you really want me to, please describe to me a really good reason you need an arrayLimit different from 100 and also why you cannot send JSON instead of a urlencoded body. |
Maybe you do not understand me. You guys are doing a great job. I am using body-parser with expressjs for parsing of post requests with extended = true. Few versions before was this limit hard coded to 20 in a QS library. Because your library is in the middle of expressjs and qs I would like to have a option to set this optional parameter. Is it possible? |
Well, it is not possible at this time, no, but I'm just trying to understand why you would need to make it configurable. The main reason I don't really want to is because this library is trying to hide the fact that I added I did bump up the default from 20 to 100 recently. Do you still need a larger limit? If so, you really need to be using JSON bodies and not urlencoded bodies. The extended urlencoded bodies are there purely for HTML |
Thanks for explanation. I will use bodyParser.json() with (application/json) instead of bodyParser.urlencoded. |
Please, can you add arrayLimit (qs library) as optional parameter like a parameterLimit?
For this I created request month ago. ljharb/qs#18
The text was updated successfully, but these errors were encountered: