Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why is there arrayLimit? #18

Closed
seeden opened this issue Aug 13, 2014 · 7 comments
Closed

Why is there arrayLimit? #18

seeden opened this issue Aug 13, 2014 · 7 comments
Assignees
@nlf
Labels
enhancement feature request
Milestone
2.0.0

Comments

@seeden
Copy link

seeden commented Aug 13, 2014

I am not really sure why you are using this limit. There is no option to change this value. Do you have a good reason for this? Because I have JSON structure with list of pictures greater than 20
@hueniverse
Copy link
Contributor

Is this for parsing or formatting?

@seeden
Copy link
Author

seeden commented Aug 13, 2014

Parsing of query parameters(expressjs)

@hueniverse
Copy link
Contributor

Parsing limits are for security reasons. This should be configurable.

@seeden
Copy link
Author

seeden commented Aug 14, 2014

Security reasons? Please can you tell me which one? This limit is hardcoded in source code without option to change it

@hueniverse
Copy link
Contributor

My point is that we should make it configurable... but we need the low default.

@seeden
Copy link
Author

seeden commented Aug 19, 2014

Configurable limit sounds good for me. Thank you

@nlf nlf self-assigned this Aug 25, 2014
@nlf nlf added this to the 1.2.3 milestone Aug 25, 2014
@nlf nlf mentioned this issue Aug 25, 2014
Closed
nlf added a commit that referenced this issue Aug 25, 2014
@nlf
make all limits optional, for #18, for #20
a5422fc
geek added a commit that referenced this issue Aug 25, 2014
@geek
Merge pull request #21 from hapijs/optional_limits
d15a581 
make all limits optional, for #18, for #20
@nlf
Copy link
Collaborator

nlf commented Aug 25, 2014

Closed via a5422fc

@nlf nlf closed this as completed Aug 25, 2014
@seeden seeden mentioned this issue Sep 4, 2014
Closed
@nfroidure nfroidure mentioned this issue Jun 17, 2015
Closed
@ljharb ljharb mentioned this issue Jun 16, 2018
Closed
@ljharb ljharb mentioned this issue Sep 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nlf nlf

Labels
enhancement feature request
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
3 participants
@hueniverse @nlf @seeden