Make the maximum items in an array configurable.

[bobbysciacchitano]

We're using body-parser to handle a large array however we hit 100 limit and got an unexpected result of the array being converted into an object.

This pull request makes the arrayLimit property configurable for use cases where there is a array larger than 100. Could potentially extend it further to validate and throw an exception if the limit is hit.

[dougwilson]

Hi! Please read the discussion over at #55 (comment) while I look at your PR. The gist is unless the option will change the behavior of extended: false in some way, it won't be added.

[Fishrock123]

See #60 also.. and yeah.

[dougwilson]

A user has also created https://www.npmjs.org/package/urlencoded-request-parser as an immediate work-around, but really you should really consider why you are creating a HTML <form> with over 100 <input> fields. And if you're not, then why can't you use JSON? The urlencoded is purely for raw HTML <form> elements.

[dougwilson]

So just for the sake on consistency, I'm seriously thinking of just setting arrayLimit to something even higher (I assumed, really, people would not be sending arrays > 100 items in the very inefficient and slow-to-parse urlencoded format). Can you share what the value you wanted to change it to was?

cc @adrian-ludwig @aez @ApeChimp @jcready

[bobbysciacchitano]

Thanks, I'll take a look at a couple of other body parsing repos to look at possible options.

Our use case was a fairly simple UI which parses a json file, displays it in a table, allows the user to make changes and then save the file back on submit [to prevent direct manipulation of the JSON].

The list size was finalised at 101 items which is where we saw the issue.

[dougwilson]

Ok. So perhaps I'll just set the limit to... 500? :)

[dougwilson]

Actually, I know a way to support Infinity limit without introducing the security issue the limit was added to fix. Win for everyone!

[dougwilson]

The code on master now addresses your use-case and similar ones automagically.