Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass more options to qs module #60

Closed
wants to merge 1 commit into from
Closed

Pass more options to qs module #60

wants to merge 1 commit into from

Conversation

adrian-ludwig
Copy link

There was not enough passed options from body-parser to qs module in extended mode.

@Fishrock123
Copy link
Contributor

As the extended option (which uses qs) in this module is deprecated and will be removed, I don't think we are going to be having extra options.

@dougwilson Maybe we can have it pass a sub-options to the parser from some parserOpts object? Would be applicable for any parser then.

What @dougwilson said.

@dougwilson
Copy link
Contributor

No. This has been turned down over and over. The only options that are to exist in urlencoded MUST apply to both extended: false and extended: true. 100% of the time, if you are tuning these args, you should be using JSON instead.

@dougwilson dougwilson closed this Oct 14, 2014
@Fishrock123 Fishrock123 mentioned this pull request Oct 30, 2014
Closed
dougwilson added a commit that referenced this pull request Oct 30, 2014
@dougwilson
make internal extended: true array limit dynamic
df1d88a 
closes #42
closes #43
closes #46
closes #58
closes #60
closes #61
closes #65
dougwilson added a commit that referenced this pull request Nov 22, 2014
@dougwilson
make internal extended: true array limit dynamic
e54219e 
closes #42
closes #43
closes #46
closes #58
closes #60
closes #61
closes #65
@expressjs expressjs locked and limited conversation to collaborators Nov 9, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
pr wontfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adrian-ludwig @Fishrock123 @dougwilson