Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Privacy components 🥸 #3411

Merged
merged 32 commits into from
Jun 8, 2023
Merged

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented May 31, 2023

Feature branch for privacy component work!

PR's that went into this:

@cypress
Copy link

cypress bot commented May 31, 2023

Passing run #2590 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 53fdb3b into a343404...
Project: fides Commit: 04dda6abea ℹ️
Status: Passed Duration: 00:49 💡
Started: Jun 8, 2023 10:10 PM Ended: Jun 8, 2023 10:11 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

eastandwestwind and others added 21 commits May 31, 2023 14:29
…Updated) and cross-publish to Fides.gtm() integration (#3454)
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.93 🎉

Comparison is base (e9f3ed6) 85.22% compared to head (3f5170c) 87.16%.

❗ Current head 3f5170c differs from pull request most recent head d186af8. Consider uploading reports for the commit d186af8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3411      +/-   ##
==========================================
+ Coverage   85.22%   87.16%   +1.93%     
==========================================
  Files         311      312       +1     
  Lines       18800    18808       +8     
  Branches     2395     2395              
==========================================
+ Hits        16023    16394     +371     
+ Misses       2341     1991     -350     
+ Partials      436      423      -13     

see 32 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@allisonking allisonking marked this pull request as ready for review June 8, 2023 14:49
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
clients/fides-js/src/components/CloseButton.tsx Outdated Show resolved Hide resolved
clients/fides-js/src/components/ConsentBanner.tsx Outdated Show resolved Hide resolved
clients/fides-js/src/components/ConsentModal.tsx Outdated Show resolved Hide resolved
clients/fides-js/src/components/Overlay.tsx Show resolved Hide resolved
clients/fides-js/src/components/fides.css Outdated Show resolved Hide resolved
clients/privacy-center/features/consent/helpers.ts Outdated Show resolved Hide resolved
@allisonking allisonking mentioned this pull request Jun 8, 2023
13 tasks
@eastandwestwind eastandwestwind merged commit fd8b1fe into main Jun 8, 2023
@eastandwestwind eastandwestwind deleted the feature/privacy-components branch June 8, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants