Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix banner transform #3476

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Fix banner transform #3476

merged 1 commit into from
Jun 6, 2023

Conversation

allisonking
Copy link
Contributor

Fixes bug reported by @eastandwestwind https://www.loom.com/share/566b70db1ca345d0a133bad689ff05a8

Code Changes

  • Use a var for the offset
  • Increase transform percentage

Steps to Confirm

  • Pull up the demo site
  • Banner should come up. Click the reject all button. Banner should completely hide

Pre-Merge Checklist

Description Of Changes

Write some things here about the changes and any potential caveats

@allisonking allisonking changed the base branch from main to feature/privacy-components June 6, 2023 18:20
@allisonking allisonking marked this pull request as ready for review June 6, 2023 18:22
@cypress
Copy link

cypress bot commented Jun 6, 2023

Passing run #2466 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 42cb9ad into 485d62f...
Project: fides Commit: 8a37e681b4 ℹ️
Status: Passed Duration: 01:02 💡
Started: Jun 6, 2023 6:39 PM Ended: Jun 6, 2023 6:40 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

eastandwestwind
eastandwestwind approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@eastandwestwind eastandwestwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested and this works well, thanks!

@eastandwestwind eastandwestwind merged commit dea614d into feature/privacy-components Jun 6, 2023
@eastandwestwind eastandwestwind deleted the aking/fix-banner-transform branch June 6, 2023 18:57
@allisonking allisonking mentioned this pull request Jun 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eastandwestwind eastandwestwind eastandwestwind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@allisonking @eastandwestwind