-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3424 styling for banner #3430
3424 styling for banner #3430
Conversation
Passing run #2349 ↗︎Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good overall! #3429 will fix the font
font size is going to be an issue, and one I ran into in that PR as well. I opted to use em
s which makes things look a little big I think, at least in the banner. the modal looks ok though. actually I think the figma might have different font sizes for the modal and the banner which makes it difficult to use the font size var 🤔
let's get yours merged in and I can resolve conflicts in my branch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Closes #3424
Code Changes
Steps to Confirm
Mocks:

This PR:

Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
Write some things here about the changes and any potential caveats