Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3424 styling for banner #3430

Merged
merged 5 commits into from
Jun 2, 2023

Conversation

eastandwestwind
Copy link
Contributor

Closes #3424

Code Changes

  • Updates banner styling according to Figma mocks

Steps to Confirm

Mocks:
Screenshot 2023-06-01 at 5 41 30 PM

This PR:
Screenshot 2023-06-01 at 5 37 19 PM

Pre-Merge Checklist

Description Of Changes

Write some things here about the changes and any potential caveats

@eastandwestwind eastandwestwind changed the base branch from main to feature/privacy-components June 1, 2023 21:44
@cypress
Copy link

cypress bot commented Jun 1, 2023

Passing run #2349 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge def2520 into ca140f5...
Project: fides Commit: 4dfc53ee50 ℹ️
Status: Passed Duration: 00:46 💡
Started: Jun 2, 2023 3:06 PM Ended: Jun 2, 2023 3:07 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good overall! #3429 will fix the font

font size is going to be an issue, and one I ran into in that PR as well. I opted to use ems which makes things look a little big I think, at least in the banner. the modal looks ok though. actually I think the figma might have different font sizes for the modal and the banner which makes it difficult to use the font size var 🤔

let's get yours merged in and I can resolve conflicts in my branch!

Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@eastandwestwind eastandwestwind merged commit c3b9e61 into feature/privacy-components Jun 2, 2023
@eastandwestwind eastandwestwind deleted the 3424-styling-for-banner branch June 2, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix styling issues with consent banner
2 participants