-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Responsive banner #3466
Responsive banner #3466
Conversation
Passing run #2444 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Oh, nice! The designs for this actually show that, when not full-width, there should be some spacing between the bottom of the page and the banner. Mockups vary between 51px and 66px which is confusing but we could pick |
whoops good catch, didn't notice that! |
Added 48px spacing between bottom and the banner: Screen.Recording.2023-06-06.at.9.54.06.AM.mov |
Closes #3444
Code Changes
Steps to Confirm
localhost:3000/fides-js-demo.html
and resize your browserPre-Merge Checklist
CHANGELOG.md
Description Of Changes
Screen.Recording.2023-06-05.at.3.29.29.PM.mov