Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive banner #3466

Merged

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Jun 5, 2023

Closes #3444

Code Changes

  • Add breakpoints for banner width and borders at different sizes
  • Slightly edit the banner DOM to have a "container" element so that it's easy to center the banner when it isn't full width

Steps to Confirm

  • Spin up the privacy center and visit localhost:3000/fides-js-demo.html and resize your browser

Pre-Merge Checklist

Description Of Changes

Screen.Recording.2023-06-05.at.3.29.29.PM.mov

@allisonking allisonking marked this pull request as ready for review June 5, 2023 20:08
@cypress
Copy link

cypress bot commented Jun 5, 2023

Passing run #2444 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge edfe46b into 384301e...
Project: fides Commit: c71c2708ff ℹ️
Status: Passed Duration: 00:45 💡
Started: Jun 6, 2023 2:11 PM Ended: Jun 6, 2023 2:12 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@NevilleS
Copy link
Contributor

NevilleS commented Jun 5, 2023

Oh, nice! The designs for this actually show that, when not full-width, there should be some spacing between the bottom of the page and the banner. Mockups vary between 51px and 66px which is confusing but we could pick 48px and use that?

@allisonking
Copy link
Contributor Author

Oh, nice! The designs for this actually show that, when not full-width, there should be some spacing between the bottom of the page and the banner. Mockups vary between 51px and 66px which is confusing but we could pick 48px and use that?

whoops good catch, didn't notice that!

@allisonking
Copy link
Contributor Author

Added 48px spacing between bottom and the banner:

Screen.Recording.2023-06-06.at.9.54.06.AM.mov

@allisonking allisonking merged commit 52f3497 into feature/privacy-components Jun 6, 2023
@allisonking allisonking deleted the aking/3444/responsive-banner branch June 6, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants