Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2011 distributed fides better handle children with no access results #2012

Conversation

adamsachs
Copy link
Contributor

Closes #2011

Code Changes

  • return empty dict if we error on the transfer endpoint, so that we just do not add results to the aggregate data result
  • put in a simple test case around this scenario
  • improve some logging in fides connector and client

Steps to Confirm

See issue

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

@adamsachs adamsachs linked an issue Dec 8, 2022 that may be closed by this pull request
This was missed in #2000 so just sliding it in here.
@adamsachs
Copy link
Contributor Author

looks like there are some unrelated mypy errors? may be from #1793?

@sanders41
Copy link
Contributor

sanders41 commented Dec 9, 2022

looks like there are some unrelated mypy errors? may be from #1793?

Looks like the mypy error could be related to that pr but not pylint. What I find interesting is mypy and pylint passed locally and in CI on that PR before merging.

The line pylint is complaining about hasn't changed since early October so weird it started failing now.

@sanders41 sanders41 merged commit ec7aee8 into main Dec 9, 2022
@sanders41 sanders41 deleted the 2011-distributed-fides-better-handle-children-with-no-access-results branch December 9, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Distributed fides - better handle children with no access results
2 participants