You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, if a given child runs to completion successfully but simply doesn't have any access results, the parent result aggregation step poorly handles this, and puts an error detail message into the aggregate access response data. An example access result with this behavior looks like this:
{"detail": "No access request information found for privacy request id pri_967396e0-bc6d-4403-88de-5e0c9a66b1de"}
Steps to Reproduce
nox -s dev -- child
docker exec -ti fides-fides-1 /bin/bash to shell into the parent fides
once in, run python scripts/load_fides_child_examples.py to load up the fides connector configs on the parent so that it can talk to the child
exit the parent shell, and simply submit an access request from whatever client. note that we do not add any connectors on the child, which means that the child will correctly not retrieve any access data, which is the scenario we're trying to reproduce. an example access request:
look at your storage location (likely fides_uploads dir) and confirm the access result that's been output matches what's above
Expected behavior
If there's no access data for a given privacy request from a given child, we should simply not add any data to our aggregate result on the parent. We should include some sort of logging on parent and/or child to indicate and warn about this, just so there's some trace of the fact that we retrieved no data from the given child.
Additional context
We found this when doing some deployed testing of distributed fides, where we had one child that had connectors configured, and another child without any connectors configured
The text was updated successfully, but these errors were encountered:
Bug Description
Currently, if a given child runs to completion successfully but simply doesn't have any access results, the parent result aggregation step poorly handles this, and puts an error detail message into the aggregate access response data. An example access result with this behavior looks like this:
Steps to Reproduce
nox -s dev -- child
docker exec -ti fides-fides-1 /bin/bash
to shell into the parent fidespython scripts/load_fides_child_examples.py
to load up the fides connector configs on the parent so that it can talk to the childfides_uploads
dir) and confirm the access result that's been output matches what's aboveExpected behavior
If there's no access data for a given privacy request from a given child, we should simply not add any data to our aggregate result on the parent. We should include some sort of logging on parent and/or child to indicate and warn about this, just so there's some trace of the fact that we retrieved no data from the given child.
Additional context
We found this when doing some deployed testing of distributed fides, where we had one child that had connectors configured, and another child without any connectors configured
The text was updated successfully, but these errors were encountered: