1999 connectors connection test endpoints can clog up the whole server #2000
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1999
Code Changes
async
keyword for the methods that define our connection endpoints that actually test a connectionSteps to Confirm
Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
Note that another option to resolve this issue would be to keep the endpoints as
async
functions and instead ensure that all of our connection tests are effectivelyasync
down the stack, and ceding control of the event loop when they reach out to make their calls to the external resources. that felt like a big change that would require a fair amount of regression testing, if it's even feasible.I feel more comfortable going down this route, especially given some of the general guidance found on the fastAPI docs: