1999 connectors connection test endpoints can clog up the whole server (

#2000)
ethyca · Dec 8, 2022 · 5a180f6 · 5a180f6
1 parent 4f4655c
commit 5a180f6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/fides/api/ops/api/v1/endpoints/connection_endpoints.py b/src/fides/api/ops/api/v1/endpoints/connection_endpoints.py
@@ -357,7 +357,7 @@ def connection_status(
     dependencies=[Security(verify_oauth_client, scopes=[CONNECTION_CREATE_OR_UPDATE])],
     response_model=TestStatusMessage,
 )
-async def put_connection_config_secrets(
+def put_connection_config_secrets(
     connection_key: FidesOpsKey,
     *,
     db: Session = Depends(deps.get_db),
@@ -392,7 +392,7 @@ async def put_connection_config_secrets(
     dependencies=[Security(verify_oauth_client, scopes=[CONNECTION_READ])],
     response_model=TestStatusMessage,
 )
-async def test_connection_config_secrets(
+def test_connection_config_secrets(
     connection_key: FidesOpsKey,
     *,
     db: Session = Depends(deps.get_db),

diff --git a/src/fides/api/ops/service/connectors/fides/fides_client.py b/src/fides/api/ops/service/connectors/fides/fides_client.py
@@ -177,7 +177,7 @@ def request_status(self, privacy_request_id: str = None) -> List[Dict[str, Any]]
             if privacy_request_id
             else None,
         )
-        response = self.session.send(request)
+        response = self.session.send(request, timeout=5)
         if not response.ok:
             log.error(
                 f"Error retrieving status of privacy request [{privacy_request_id}] on remote Fides {self.uri}",