Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mypy and pylint errors showing up in CI #2013

Merged
merged 2 commits into from
Dec 9, 2022
Merged

Fix mypy and pylint errors showing up in CI #2013

merged 2 commits into from
Dec 9, 2022

Conversation

sanders41
Copy link
Contributor

@sanders41 sanders41 commented Dec 9, 2022 •
edited
Loading

Closes

Code Changes

  • Remove unused PrivacyRequest import
  • Add type ignore to mypy error

Steps to Confirm

  • list any manual steps taken to confirm the changes

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

Fixes mypy and pylint errors showing up in #2012 that are unrelated to that PR.

adamsachs
adamsachs approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@adamsachs adamsachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for quickly addressing

@adamsachs adamsachs merged commit de0f1fb into main Dec 9, 2022
@adamsachs adamsachs deleted the mypy-pylint-errors branch December 9, 2022 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamsachs adamsachs adamsachs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanders41 @adamsachs