bump cel-cpp #36661
Merged
bump cel-cpp #36661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
repokitteh-read-only
bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
|
This PR will complete and obsolete #36167 and #35514. (cc: @kyessenov) |
|
We've got a gcc build issue; I'm working on fixing that upstream. |
|
@asedeno this (re-) adds a bit of noise to the build external/com_google_cel_cpp/common/internal/reference_count.cc:83:33: warning: offset of on non-standard-layout type 'cel::common_internal::(anonymous namespace)::ReferenceCountedString' [-Winvalid-offsetof]
internal::SizedDelete(that, offsetof(ReferenceCountedString, data_) + size);
^ ~~~~~
/opt/llvm/lib/clang/14.0.0/include/stddef.h:104:24: note: expanded from macro 'offsetof'
#define offsetof(t, d) __builtin_offsetof(t, d)
^ ~INFO: From Compiling internal/well_known_types.cc:
In file included from external/com_google_cel_cpp/internal/well_known_types.cc:15:
external/com_google_cel_cpp/internal/well_known_types.h:1133:52: warning: private field 'fields_key_field_string_type_' is not used [-Wunused-private-field]
google::protobuf::FieldDescriptor::CppStringType fields_key_field_string_type_; INFO: From Compiling common/type_factory.cc:
external/com_google_cel_cpp/common/type_factory.cc:25:6: warning: unused function 'IsValidMapKeyType' [-Wunused-function]
bool IsValidMapKeyType(const Type& type) {
^
1 warning generated.can we resolve upstream or failing that patch it out? |
Working on it now; which specific build(s) did you pull these from? I want to cross-reference against |
|
iirc the |
Signed-off-by: Alejandro R. Sedeño <[email protected]>
|
The warnings have been resolved (or silenced) upstream. |
|
/retest |
phlax
approved these changes
Oct 23, 2024
repokitteh-read-only
bot
removed
the
deps
krinkinmu
added a commit
to krinkinmu/cel-cpp
that referenced
this pull request
Nov 4, 2024
gcc complains about FieldBackedMapImpl::ListKeys when overloaded-virtual check is enabled. When using -Werror, warnings like this are converted to errors breaking builds. That's what happened to gcc build of Envoy a while back. The issue in Envoy was fixed by introducing a patch for cel-cpp that was applied to the source during Envoy build (see envoyproxy/envoy#31814). Unfortunately during cel-cpp version update in Envoy instead of updating the patch, dropping the parts that are not needed anymore, we dropped the whole cep-cpp patch all together in envoyproxy/envoy#36661. And now gcc can't build Envoy again. This change makes the change to silence the gcc warning in the cel-cpp codebase, which hopefully will be a bit more durable than maintaing a patch on the Envoy side. Signed-off-by: Mikhail Krinkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update cel-cpp to
HEADas of when this PR was made, and drop the now-obsolete patches.google/cel-cpp@b03438a
Risk Level:
Testing: CI