-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update absl, googleapis, cel-cpp #35514
Conversation
Change-Id: I45d346443dea2ba767c6c929805af65d7af05a93 Signed-off-by: Kuat Yessenov <[email protected]>
Change-Id: Ida8a42d5de3cd8c24504dcdedbacb70a7c172046 Signed-off-by: Kuat Yessenov <[email protected]>
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
/assign @yanavlasov |
/wait-any |
@kyessenov this adds 100s of lines of warnings to most of our builds can we either fix this upstream before merging or patch out the warnings if they are not important |
@phlax, yeah I can fix upstream. There's work to do here with various static asserts too. |
Change-Id: I1fa5cc0418b5b267f77cf021844685aa96521487
Change-Id: Ifa9f8e1da03c7404044de12a3a825929420a9dcf Signed-off-by: Kuat Yessenov <[email protected]>
Change-Id: I97525ca09a9e043017466455e371eb6745c1da37 Signed-off-by: Kuat Yessenov <[email protected]>
Change-Id: I2c5f1bb8d3331eb35c78746efea1d2b48151983d Signed-off-by: Kuat Yessenov <[email protected]>
Change-Id: I452b4cb002335ac7ef334ab6dd295f0d938997ab
Change-Id: Icc5580dfc89124e4b97c33f75e8a40b1106c60cd Signed-off-by: Kuat Yessenov <[email protected]>
Deps looks good and will check back when CI errors are fixed |
/wait |
@kyessenov regarding the iOS/macOS failures, if I change the Abseil library to be the previous one, i.e.
then it builds properly. It seems like this version of the Abseil library has issues in its macOS/iOS target build? |
@abeyad macOS build failure is distinct - it's something about alignment difference. I am not sure how iOS build error is triggered - is it using clang 14 or some strange compiler version? |
I'm using clang 15 locally on my mac and it fails to build with the same error as the iOS job. Note that I'm using the option Lines 69 to 71 in 770fa7b
|
Sigh, I don't have a Mac. And it's also quic code. Any way to proceed debugging besides Googling for some other reports of a build failure? |
Change-Id: I14ccd0ae23629055cb30a3ea86a303a7f9b7731e
I see two problems:
|
/wait |
Change-Id: I3de3c8c8b04d8269d1961e082cf33886aca19b03
/retest |
1 similar comment
/retest |
ci fails look real /wait |
For the macOS failure: google/cel-cpp#831 |
The macOS build failure should be fixed by bumping CEL to google/cel-cpp@aafa026. That's going to require bumping protobuf too though. |
I'd like to decouple the absl update from the cel update, just to untangle the various build failures. Was [edit:] ah, I see that 20240722.0 was released August 1st, after this PR was opened. |
@asedeno i tried updating absl on its own previously and iirc came to the conclusion that it would need a CEL update also - at least without patching |
@phlax, I'm a bit late to this party and also arriving to the same conclusion. I might poke at it some more just to satisfy my own curiosity. |
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Commit Message: update absl, googleapis, cel-cpp
Risk Level: low