Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update various dependencies #36167

Closed
wants to merge 12 commits into from
Closed

Update various dependencies #36167

wants to merge 12 commits into from

Conversation

asedeno
Copy link
Contributor

@asedeno asedeno commented Sep 16, 2024

This draft PR contains updates to:

  • abseil to 20240722.0
  • cel-cpp
    • with a patch to fix some linking issues on macOS that we shouldn't have to carry for too long.
  • protobuf to 28.1
  • googleapis

Also included:

  • patches for protoconverter that should be upstreamed once github export process is ironed out.
  • patches for grpc-httpjson-transcoding that I have open PRs for and want merged before committing these changes.

@asedeno
Bump abseil top 20240722.0
3b2c28b 
Signed-off-by: Alejandro R Sedeño <[email protected]>
@asedeno
add //absl/log:flags to quiche_common_mobile_quiche_logging_lib for t…
e76bf58 
…he --v flag impl

Signed-off-by: Alejandro R Sedeño <[email protected]>
@asedeno
bump cel-cpp
be6333e 
Signed-off-by: Alejandro R Sedeño <[email protected]>
@asedeno
bump protobuf to 28.1
a039f54 
Signed-off-by: Alejandro R Sedeño <[email protected]>
@asedeno
bump googleapis
fe87402 
Signed-off-by: Alejandro R Sedeño <[email protected]>
@asedeno
[DO NOT MERGE] protoconverter and grpc-httpjson-transcoding cleanup
76263c2 
This is a test commit with patches from a set of PRs I want to get in
merged into upstream grpc-httpjson-transcoding, as well as some
patches for protoconverter that I expect we will have to carry for the
short term to allow for updates to protobuf in envoy.

Signed-off-by: Alejandro R Sedeño <[email protected]>
@repokitteh-read-only RepoKitteh - Read Only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #36167 was opened by asedeno.

see: more, trace.

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Sep 16, 2024
@repokitteh-read-only RepoKitteh - Read Only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @phlax

🐱

Caused by: #36167 was opened by asedeno.

see: more, trace.

@phlax
Copy link
Member

phlax commented Sep 17, 2024

i know its draft but this looks like a lot to update in one go - if we can separate any of these updates that would definitely be preferable

also we are getting close to release so we want to start limiting updates to less risky changes

@asedeno
Copy link
Contributor Author

asedeno commented Sep 17, 2024

Yeah, I tried, but it's all a tangled mess right now. I think we can tease out protoconverter and grpc-httpjson-transcoding if they go first, but they need to be cleaned up to update protobuf. Maybe googleapis can be split off too, but I haven't tried yet.

It can't go in until I figure out why mobile is failing to include standard headers though.

This was referenced Sep 17, 2024
Merged
Merged
@asedeno
fixup httpjson-transcoding
37a0b5e 
Signed-off-by: Alejandro R Sedeño <[email protected]>
@asedeno
update mobile/third_party/rbe_configs/cc/module.modulemap
e3c8e7b 
This should be done as a separate PR updating the RBE configs for
mobile, but let's get one in here to show that it's actually the
problem.

Signed-off-by: Alejandro R Sedeño <[email protected]>
@asedeno
protobuf: also update protoc release date
53369f3 
Signed-off-by: Alejandro R Sedeño <[email protected]>
@asedeno
bump protobuf to 28.2
1114538 
Signed-off-by: Alejandro R Sedeño <[email protected]>
@asedeno
update more files in mobile/third_party/rbe_configs/cc/
542910b 
A followup on e3c8e7b with more path updates.

Signed-off-by: Alejandro R Sedeño <[email protected]>
This was referenced Sep 24, 2024
Merged
Merged
This was referenced Oct 15, 2024
Merged
Merged
@asedeno asedeno closed this Oct 17, 2024
@asedeno asedeno deleted the update_deps branch October 17, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanTheOptimist RyanTheOptimist Awaiting requested review from RyanTheOptimist RyanTheOptimist will be requested when the pull request is marked ready for review RyanTheOptimist is a code owner

@alyssawilk alyssawilk Awaiting requested review from alyssawilk alyssawilk will be requested when the pull request is marked ready for review alyssawilk is a code owner

@abeyad abeyad Awaiting requested review from abeyad abeyad will be requested when the pull request is marked ready for review abeyad is a code owner

@fredyw fredyw Awaiting requested review from fredyw fredyw will be requested when the pull request is marked ready for review fredyw is a code owner

@wbpcode wbpcode Awaiting requested review from wbpcode wbpcode will be requested when the pull request is marked ready for review wbpcode is a code owner

@tyxia tyxia Awaiting requested review from tyxia tyxia will be requested when the pull request is marked ready for review tyxia is a code owner

@mattklein123 mattklein123 Awaiting requested review from mattklein123 mattklein123 will be requested when the pull request is marked ready for review mattklein123 is a code owner

Assignees

@phlax phlax

Labels
deps Approval required for changes to Envoy's external dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asedeno @phlax