cel: fix gcc contrib build #31814
Merged
cel: fix gcc contrib build #31814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kuat Yessenov <[email protected]>
repokitteh-read-only
bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
phlax
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
lgtm, thanks @kyessenov
lets try and move as much of this patch upstream as we can after release
repokitteh-read-only
bot
removed
the
deps
|
Will file a bug internally. Google doesn't build with GCC - and this is a GCC weirdness. |
ggreenway
added a commit
to ggreenway/envoy
that referenced
this pull request
Feb 1, 2024
This reverts commit 21c4a2c. Signed-off-by: Greg Greenway <[email protected]>
krinkinmu
added a commit
to krinkinmu/cel-cpp
that referenced
this pull request
Nov 4, 2024
gcc complains about FieldBackedMapImpl::ListKeys when overloaded-virtual check is enabled. When using -Werror, warnings like this are converted to errors breaking builds. That's what happened to gcc build of Envoy a while back. The issue in Envoy was fixed by introducing a patch for cel-cpp that was applied to the source during Envoy build (see envoyproxy/envoy#31814). Unfortunately during cel-cpp version update in Envoy instead of updating the patch, dropping the parts that are not needed anymore, we dropped the whole cep-cpp patch all together in envoyproxy/envoy#36661. And now gcc can't build Envoy again. This change makes the change to silence the gcc warning in the cel-cpp codebase, which hopefully will be a bit more durable than maintaing a patch on the Envoy side. Signed-off-by: Mikhail Krinkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Fixes #31760