-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lens formula improvements #89457
Lens formula improvements #89457
Conversation
@dej611 I tried to test the PR, but I'm only getting errors when clicking the Formula operation. |
…a into lens/formula-error-handling
@wylieconlon Tried to play with this but it's always failing with |
@wylieconlon Tried it again and it's still failing on these steps:
The error message is different now though: It works if starting with an empty formula dimension. I'm not entirely sure which parts I should ignore for now. Random collection of things I noticed:
All in all pretty usable already. This is going to be a great tool :) |
Closing in favor of #99297 |
Summary
Building on top of #88997
Count()
string
when coming toFormula
isTransferable
implementationWorkout references remappingnot requiredmoving_average
,cumulative_sum
, etc...(uses a name remap without the_
)Validate supported functions:Use for autocomplete recommendationspecificOperations
fn + moving_average( ... )
=> does not detect missingwindow
argumentfullReference
function when used after a first function (fn + moving_average( ...? )
cardinality
operation (why just numberic fields?)[skip=ci]