Code

Lens formula improvements#89457

Code

Closed

dej611 wants to merge 123 commits intoelastic:masterelastic/kibana:masterfrom dej611:lens/formula-error-handlingdej611/kibana:lens/formula-error-handlingCopy head branch name to clipboard

+5,408-477

Commits

Commits on Jan 21, 2021

• Lens formula

  flash1293

  committed
  5941b55

  Copy full SHA for 5941b55

Commits on Jan 27, 2021

• Merge remote-tracking branch 'upstream/master' into lens/formula-error-handling

  dej611

  committed
  c175dd9

  Copy full SHA for c175dd9

• ⚗️ Adding basic error handling + transferable

  dej611

  committed
  71b0812

  Copy full SHA for 71b0812

Commits on Jan 28, 2021

• ✨ Implement new features

  dej611

  committed
  c89bbf7

  Copy full SHA for c89bbf7

Commits on Jan 29, 2021

• Merge remote-tracking branch 'upstream/master' into lens/formula-error-handling

  dej611

  committed
  7e0b149

  Copy full SHA for 7e0b149

• 🐛 Fix isTransferable from Formula

  dej611

  committed
  cd83321

  Copy full SHA for cd83321

• ✨ Add all fullReferences ops + initial params

  dej611

  committed
  7df6c2d

  Copy full SHA for 7df6c2d

• Expand Tinymath grammar, including named arguments

  wylieconlon

  committed
  0473cb8

  Copy full SHA for 0473cb8

Commits on Feb 1, 2021

• Merge remote-tracking branch 'upstream/master' into lens/formula-error-handling

  dej611

  committed
  7897563

  Copy full SHA for 7897563

• ✨ Add enhanced validation for fields, operations and parameters

  dej611

  committed
  aaf5664

  Copy full SHA for aaf5664

• Add tsconfig project

  wylieconlon

  committed
  66b7dde

  Copy full SHA for 66b7dde

• Fix tests

  wylieconlon

  committed
  0e8a7be

  Copy full SHA for 0e8a7be

Commits on Feb 2, 2021

• ✨ Add id and name (optional) decoupling

  dej611

  committed
  af6da20

  Copy full SHA for af6da20

• ✨ Give Formula column custom label

  dej611

  committed
  7e5b825

  Copy full SHA for 7e5b825

• Merge branch 'pr/89795' into lens/formula-named-params

  dej611

  committed
  d6df1e2

  Copy full SHA for d6df1e2

• Merge branch 'master' into tinymath-named-arguments

  kibanamachine

  authored
  c558744

  Copy full SHA for c558744

Commits on Feb 3, 2021

• Allow named arguments with numeric types

  wylieconlon

  committed
  bde55d3

  Copy full SHA for bde55d3

• 🏷️ Migrate AST to new format + types fix + extended validation

  dej611

  committed
  bf8f8c4

  Copy full SHA for bf8f8c4

• 🐛 Improved validation

  dej611

  committed
  d02ee52

  Copy full SHA for d02ee52

• ✅ Add first batch of validation tests

  dej611

  committed
  03b1bd4

  Copy full SHA for 03b1bd4

• Merge branch 'pr/89795' into lens/formula-error-handling

  dej611

  committed
  3f8d248

  Copy full SHA for 3f8d248

• ✅ Add more validation tests for formula

  dej611

  committed
  b5ee6ab

  Copy full SHA for b5ee6ab

Commits on Feb 4, 2021

• Merge remote-tracking branch 'upstream/master' into lens/formula-error-handling

  dej611

  committed
  9c45213

  Copy full SHA for 9c45213

• 🐛 Fix parsing issues + tests

  dej611

  committed
  d71c30c

  Copy full SHA for d71c30c

• Merge remote-tracking branch 'origin/master' into tinymath-named-arguments

  wylieconlon

  committed
  973a569

  Copy full SHA for 973a569

• Merge branch 'tinymath-named-arguments' into HEAD

  wylieconlon

  committed
  c87277d

  Copy full SHA for c87277d

• Reorganize code to support autocomplete

  wylieconlon

  committed
  abcb1a4

  Copy full SHA for abcb1a4

• ✨ Refactor validation

  dej611

  committed
  6c4855e

  Copy full SHA for 6c4855e

• Refactoring by dej611

  Show description for 1f9ebb9
  

  wylieconlon

  and

  dej611

  committed
  1f9ebb9

  Copy full SHA for 1f9ebb9

Commits on Feb 5, 2021

• Use real fields

  wylieconlon

  committed
  8ecde1d

  Copy full SHA for 8ecde1d

• 🐛 Fix most of test issues + hide Math op

  dej611

  committed
  17f49fa

  Copy full SHA for 17f49fa

• Show errors in formula editor

  wylieconlon

  committed
  c919670

  Copy full SHA for c919670

Commits on Feb 9, 2021

• 🏷️ fix types

  dej611

  committed
  155a986

  Copy full SHA for 155a986

• Merge remote-tracking branch 'origin/master' into lens/formulas

  wylieconlon

  committed
  8720257

  Copy full SHA for 8720257

Commits on Feb 10, 2021

• Fix types and parsing

  wylieconlon

  committed
  a53d074

  Copy full SHA for a53d074

• Merge branch lens/formula-error-handling-2 into lens/formula-error-handling

  dej611

  committed
  844692a

  Copy full SHA for 844692a

• 💄 Hack to fix suggestion box

  dej611

  committed
  d4c5998

  Copy full SHA for d4c5998

Commits on Feb 15, 2021

• Merge branch 'master' into lens/formula-error-handling

  kibanamachine

  authored
  bb37b7f

  Copy full SHA for bb37b7f

Commits on Feb 18, 2021

• Merge branch 'master' into lens/formula-error-handling

  kibanamachine

  authored
  2420565

  Copy full SHA for 2420565

Commits on Feb 19, 2021

• Merge branch 'master' into lens/formula-error-handling

  kibanamachine

  authored
  036415a

  Copy full SHA for 036415a

• 🐛 Fix validation messages

  dej611

  committed
  4d5dca2

  Copy full SHA for 4d5dca2

• 🐛 Relax operations check for managedReferences

  dej611

  committed
  7c38af3

  Copy full SHA for 7c38af3

• Merge remote-tracking branch 'origin/master' into lens/formulas

  wylieconlon

  committed
  e90a5df

  Copy full SHA for e90a5df

• Change completion params

  wylieconlon

  committed
  a695329

  Copy full SHA for a695329

Commits on Feb 22, 2021

• 🏷️ Fix missing arg issue

  dej611

  committed
  ea574f7

  Copy full SHA for ea574f7

Commits on Mar 2, 2021

• Merge remote-tracking branch 'upstream/master' into lens/formula-error-handling

  dej611

  committed
  28c0427

  Copy full SHA for 28c0427

Commits on Mar 3, 2021

• ✨ Add more tinymath fns

  dej611

  committed
  417edff

  Copy full SHA for 417edff

• 🐛 Improved validation around math operations + multiple named arguments

  dej611

  committed
  fcbdc74

  Copy full SHA for fcbdc74

• 🐛 Use new onError feature in math expression

  dej611

  committed
  55d3bc6

  Copy full SHA for 55d3bc6

• ♻️ Refactor namedArguments validation

  dej611

  committed
  642fa53

  Copy full SHA for 642fa53

• 🐛 Fix circular dependency issue in tests + minor fixes

  dej611

  committed
  08b9b6f

  Copy full SHA for 08b9b6f

• Merge remote-tracking branch 'upstream/master' into lens/formula-error-handling

  dej611

  committed
  530226c

  Copy full SHA for 530226c

• Merge remote-tracking branch 'origin/master' into lens/formulas

  wylieconlon

  committed
  586f6ef

  Copy full SHA for 586f6ef

Commits on Mar 4, 2021

• Move formula into a tab

  wylieconlon

  committed
  7832aeb

  Copy full SHA for 7832aeb

• 🔥 Leftovers from previous merge

  dej611

  committed
  f05c647

  Copy full SHA for f05c647

• ✨ Move over namedArgs from previous function

  dej611

  committed
  d050e6f

  Copy full SHA for d050e6f

• ✅ Add tests for transferable scenarios

  dej611

  committed
  37c9c5f

  Copy full SHA for 37c9c5f

• Merge branch 'lens/formula-error-handling' of github.com:dej611/kibana into lens/formula-error-handling

  dej611

  committed
  006f569

  Copy full SHA for 006f569

• ✅ Fixed broken test

  dej611

  committed
  135987c

  Copy full SHA for 135987c

• ✨ Use custom label for axis

  dej611

  committed
  28847f1

  Copy full SHA for 28847f1

• Allow switching back and forth to formula tab

  wylieconlon

  committed
  5524cf2

  Copy full SHA for 5524cf2

• Add a section for the function reference

  wylieconlon

  committed
  6650f67

  Copy full SHA for 6650f67

Commits on Mar 5, 2021

• Add modal editor and markdown docs

  wylieconlon

  committed
  1e32e0a

  Copy full SHA for 1e32e0a

• Merge remote-tracking branch 'origin/master' into lens/formulas

  wylieconlon

  committed
  cacf486

  Copy full SHA for cacf486

• Change the way math nodes are validated

  wylieconlon

  committed
  2bc7f6c

  Copy full SHA for 2bc7f6c

Commits on Mar 8, 2021

• Merge remote-tracking branch 'origin/master' into lens/formulas

  wylieconlon

  committed
  367de12

  Copy full SHA for 367de12

Commits on Mar 9, 2021

• Merge remote-tracking branch 'origin/master' into lens/formulas

  wylieconlon

  committed
  d42d02e

  Copy full SHA for d42d02e

Commits on Mar 10, 2021

• Use custom portal to fix monaco positioning

  wylieconlon

  committed
  e0cd7d4

  Copy full SHA for e0cd7d4

• Fix model sharing issues

  wylieconlon

  committed
  a1e8412

  Copy full SHA for a1e8412

• Merge remote-tracking branch 'origin/master' into lens/formulas

  wylieconlon

  committed
  039a5c2

  Copy full SHA for 039a5c2

Commits on Mar 11, 2021

• Provide signature help

  wylieconlon

  committed
  86f36dd

  Copy full SHA for 86f36dd

• 🐛 Fix small test issue

  dej611

  committed
  dba216c

  Copy full SHA for dba216c

• 🐛 Mark pow arguments as required

  dej611

  committed
  4d5ce24

  Copy full SHA for 4d5ce24

• 🐛 validate on first render only if a formula is present

  dej611

  committed
  f47c5db

  Copy full SHA for f47c5db

• 🔥 Remove log10 fn for now

  dej611

  committed
  e102ad2

  Copy full SHA for e102ad2

• ✨ Improved math validation + add tests for math functions

  dej611

  committed
  1483d9d

  Copy full SHA for 1483d9d

Commits on Mar 17, 2021

• Merge remote-tracking branch upstream/master into lens/formula-error-handling

  dej611

  committed
  1e510cc

  Copy full SHA for 1e510cc

Commits on Mar 18, 2021

• Merge branch 'master' into lens/formula-error-handling

  kibanamachine

  authored
  9069161

  Copy full SHA for 9069161

Commits on Mar 23, 2021

• Merge remote-tracking branch 'origin/master' into lens/formulas

  wylieconlon

  committed
  c4e6be8

  Copy full SHA for c4e6be8

Commits on Mar 24, 2021

• Fix mount/unmount issues with Monaco

  wylieconlon

  committed
  89bf4d2

  Copy full SHA for 89bf4d2

• [Lens] Fully unmount React when flyout closes

  wylieconlon

  committed
  2334c1b

  Copy full SHA for 2334c1b

Commits on Mar 25, 2021

• Merge remote-tracking branch 'origin/master' into lens/unmount-bug

  wylieconlon

  committed
  3f2b10f

  Copy full SHA for 3f2b10f

• Fix bug with editor frame unmounting

  wylieconlon

  committed
  502f74d

  Copy full SHA for 502f74d

• Fix type

  wylieconlon

  committed
  5df313c

  Copy full SHA for 5df313c

• Merge remote-tracking branch 'origin/master' into lens/formulas

  wylieconlon

  committed
  dc20489

  Copy full SHA for dc20489

• Merge branch 'lens/unmount-bug' into lens/formulas

  wylieconlon

  committed
  5c4b75f

  Copy full SHA for 5c4b75f

Commits on Mar 26, 2021

• Merge remote-tracking branch 'origin/master' into lens/formulas

  wylieconlon

  committed
  7dfed34

  Copy full SHA for 7dfed34

• Add tests for monaco providers, add hover provider

  wylieconlon

  committed
  2382797

  Copy full SHA for 2382797

• Add test for last_value

  wylieconlon

  committed
  f746acf

  Copy full SHA for f746acf

Commits on Mar 29, 2021

• Merge remote-tracking branch 'origin/master' into lens/formulas

  wylieconlon

  committed
  81eace1

  Copy full SHA for 81eace1

• Usability improvements

  wylieconlon

  committed
  387059e

  Copy full SHA for 387059e

Commits on Mar 30, 2021

• Merge remote-tracking branch 'origin/master' into lens/formulas

  wylieconlon

  committed
  1065a76

  Copy full SHA for 1065a76

• Add KQL and Lucene named parameters

  wylieconlon

  committed
  46bd80f

  Copy full SHA for 46bd80f

Commits on Mar 31, 2021

• Merge remote-tracking branch 'origin/master' into lens/formulas

  wylieconlon

  committed
  14ec327

  Copy full SHA for 14ec327

• Add kql, lucene completion and validation

  wylieconlon

  committed
  bbf55a2

  Copy full SHA for bbf55a2

Commits on Apr 1, 2021

• Merge remote-tracking branch 'origin/master' into lens/formulas

  wylieconlon

  committed
  9351572

  Copy full SHA for 9351572

• Fix autocomplete on weird characters and properly connect KQL

  wylieconlon

  committed
  c7e4154

  Copy full SHA for c7e4154

Commits on Apr 2, 2021

• Merge remote-tracking branch 'origin/master' into lens/formulas

  wylieconlon

  committed
  15ccac2

  Copy full SHA for 15ccac2

• Highlight functions that have additional requirements after validating

  wylieconlon

  committed
  08a985c

  Copy full SHA for 08a985c

• Fix type error and move help text to popover

  wylieconlon

  committed
  daa5685

  Copy full SHA for daa5685

Commits on Apr 5, 2021

• Merge remote-tracking branch 'origin/master' into lens/formulas

  wylieconlon

  committed
  ccf7266

  Copy full SHA for ccf7266

• Merge remote-tracking branch 'origin/master' into lens/formulas

  wylieconlon

  committed
  0c1cfa9

  Copy full SHA for 0c1cfa9

• Fix escape characters inside KQL

  wylieconlon

  committed
  239c72d

  Copy full SHA for 239c72d

Commits on Apr 6, 2021

• 🐛 Fix dataType issue when moving over to Formula

  dej611

  committed
  fa57951

  Copy full SHA for fa57951

• Merge branch 'lens/formula-error-handling' of github.com:dej611/kibana into lens/formula-error-handling

  dej611

  committed
  3da8f82

  Copy full SHA for 3da8f82

• Automatically insert single quotes on every named param

  wylieconlon

  committed
  1fd06bf

  Copy full SHA for 1fd06bf

Commits on Apr 8, 2021

• Only insert single quotes when typing kql= or lucene=

  wylieconlon

  committed
  b62f96e

  Copy full SHA for b62f96e

• Reorganize help popover

  wylieconlon

  committed
  d563cb5

  Copy full SHA for d563cb5

Commits on Apr 21, 2021

• Merge remote-tracking branch 'origin/master' into lens/formulas

  wylieconlon

  committed
  32fdfbf

  Copy full SHA for 32fdfbf

• Merge remote-tracking branch 'origin/master' into lens/formulas

  wylieconlon

  committed
  c81b47c

  Copy full SHA for c81b47c

• Fix merge issues

  wylieconlon

  committed
  edb522d

  Copy full SHA for edb522d

Commits on Apr 27, 2021

• Merge remote-tracking branch 'origin/master' into lens/formulas

  wylieconlon

  committed
  87b435b

  Copy full SHA for 87b435b

• Update grammar for formulas

  wylieconlon

  committed
  7169655

  Copy full SHA for 7169655

• Fix bad merge

  wylieconlon

  committed
  e01bca8

  Copy full SHA for e01bca8

Commits on Apr 28, 2021

• Rough fullscreen mode

  wylieconlon

  committed
  ec493d1

  Copy full SHA for ec493d1

• Merge remote-tracking branch 'origin/master' into lens/formulas

  wylieconlon

  committed
  255a40f

  Copy full SHA for 255a40f

• Type updates

  wylieconlon

  committed
  90cff4a

  Copy full SHA for 90cff4a

• Pass through fullscreen state

  wylieconlon

  committed
  12391f6

  Copy full SHA for 12391f6

Commits on Apr 29, 2021

• Remove more chrome from full screen mode

  wylieconlon

  committed
  83ae9bf

  Copy full SHA for 83ae9bf

Commits on Apr 30, 2021

• Fix minor bugs in formula typing

  wylieconlon

  committed
  f520d2f

  Copy full SHA for f520d2f

Commits on May 4, 2021

• Merge remote-tracking branch 'origin/master' into lens/formulas

  wylieconlon

  committed
  23f65d8

  Copy full SHA for 23f65d8

• 🐛 Decouple column order of references and output

  wylieconlon

  committed
  5a26025

  Copy full SHA for 5a26025

• 🔧 Fix tests and types

  wylieconlon

  committed
  e6ff6d7

  Copy full SHA for e6ff6d7