Icon Additions for Upcoming Lens Features #4779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4779/ |
elizabetdev
suggested changes
May 5, 2021
There was a problem hiding this comment.
Thanks @MichaelMarcialis,
These icons look amazing. 🎉
I look at the code and it looks good. Also tested in light and dark mode, and in Figma using the grid to see the alignments.
One thing that I noticed looking at the documentation and doing my Figma tests is that the eraser icon seems more left-aligned than centered:
I think it seems more centered if we move the icon 1px to the right. What do you think?
Good catch! I'll update shortly. |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4779/ |
elizabetdev
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added some new icons to EUI to support the needs of upcoming Lens features (dynamic coloring, thresholds, custom formula). This PR includes the following icons:
color(was already in Figma; just added to EUI repo)continuityAbovecontinuityAboveBelowcontinuityBelowcontinuityWithineraserfullScreenExitfunction(was already in Figma; just added to EUI repo)percent(for use in icon-only elements, such asEuiButtonIconand icon-onlyEuiButtonGroupcomponents)wordWrapwordWrapDisabledChecklist
[ ] Checked in mobile[ ] Props have proper autodocs and playground toggles[ ] Checked Code Sandbox works for the any docs examples[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes