Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiCodeBlock] Exit cross icon should be replaced by fullScreenExit icon #5416

Closed
elizabetdev opened this issue Nov 29, 2021 · 2 comments · Fixed by #5421
Closed

[EuiCodeBlock] Exit cross icon should be replaced by fullScreenExit icon #5416

elizabetdev opened this issue Nov 29, 2021 · 2 comments · Fixed by #5421
Labels
good first issue

Comments

@elizabetdev
Copy link
Contributor

A fullScreenExit icon was added in #4779 so we should replace the cross icon being used in EuiCodeBlock with it. This way we ensure consistency across our products.

CodeBlock - Full screen exit@2x
@cee-chen
Copy link
Contributor

Should this also apply to EuiDataGrid?

@elizabetdev
Copy link
Contributor Author

@constancecchen, yes. Actually, this issue came after the review on #5415 (comment)

@cee-chen cee-chen mentioned this issue Nov 29, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
2 participants
@cee-chen @elizabetdev