-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade EUI to v34.3.0 #101334
Upgrade EUI to v34.3.0 #101334
Conversation
yarn.lock
Outdated
@@ -18955,7 +18956,7 @@ mdast-util-from-markdown@^0.8.0: | |||
parse-entities "^2.0.0" | |||
unist-util-stringify-position "^2.0.0" | |||
|
|||
[email protected]: | |||
[email protected], mdast-util-to-hast@^10.0.0: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mistic mdast-util-to-hast
is now an EUI dep
@cchaos kibana/src/core/public/styles/_base.scss Line 29 in 9b2d0c3
|
@flash1293 Do you have any ideas for fixing the Lens data grid test failures? Local output
|
@thompsongl Thanks for pining me here. This worked for me (waiting for a tick, then updating the enzyme wrapper to get the new tree): await act(async () => {
await new Promise(r => setTimeout(r, 0));
});
wrapper.update(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uptime Changes LGTM !!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AppServices change LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good from design 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stack Management changes LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Presentation changes LGTM. Just FYI I had to do a clean before doing the bootstrap but everything worked after that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Workplace Search changes LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Security Solution changes LGTM! Thanks for the upgrade @thompsongl! 🙂
Note: In testing I did notice that the Security Solution Timeline was now in a partial page flyout vs full-page. I've pinged the @elastic/security-threat-hunting team and they'll address in a follow-up.
@spong That's most likely related to how you all were setting the size before. Now EuiFlyout takes any CSS |
Code changes owned by @elastic/stack-monitoring-ui are only (expected) snapshot updates. Will merge after successful CI |
💚 Build Succeeded
Metrics [docs]Async chunks
Public APIs missing exports
Page load bundle
History
To update your PR or re-run it, just comment with: |
* eui to v34.1.0 * styled-components types * src snapshot updates * x-pack snapshot updates * eui to v34.2.0 * styled-components todo * src snapshot updates * x-pack snapshot updates * jest test updates * collapsible_nav * Hard-code global nav width for bottom bar’s (for now) * Update to eui v34.3.0 * flyout unmock * src flyout snapshots * remove duplicate euioverlaymask * xpack flyout snapshots * remove unused import * sidenavprops * attr updates * trial: flyout ownfocus * remove unused * graph selector * jest * jest * flyout ownFocus * saved objects flyout * console welcome flyout * timeline flyout * clean up * visible * colorpicker data-test-subj * selectors * selector * ts * selector * snapshot * Fix `use_security_solution_navigation` TS error * cypress Co-authored-by: cchaos <[email protected]> Co-authored-by: Chandler Prall <[email protected]>
* Upgrade EUI to v34.3.0 (#101334) * eui to v34.1.0 * styled-components types * src snapshot updates * x-pack snapshot updates * eui to v34.2.0 * styled-components todo * src snapshot updates * x-pack snapshot updates * jest test updates * collapsible_nav * Hard-code global nav width for bottom bar’s (for now) * Update to eui v34.3.0 * flyout unmock * src flyout snapshots * remove duplicate euioverlaymask * xpack flyout snapshots * remove unused import * sidenavprops * attr updates * trial: flyout ownfocus * remove unused * graph selector * jest * jest * flyout ownFocus * saved objects flyout * console welcome flyout * timeline flyout * clean up * visible * colorpicker data-test-subj * selectors * selector * ts * selector * snapshot * Fix `use_security_solution_navigation` TS error * cypress Co-authored-by: cchaos <[email protected]> Co-authored-by: Chandler Prall <[email protected]> * fix bad merge resolution * fix bad merge resolution Co-authored-by: cchaos <[email protected]> Co-authored-by: Chandler Prall <[email protected]>
Summary
[email protected]
⏩[email protected]
onwFocus=true
, which also adds an overlay mask34.3.0
testenv
mock forEuiFlyout
(#4858)mobile
glyph toEuiIcon
(#4827)EuiSideNav
to only if the item is not linked but has children (#4827)EuiSideNav
(#4827)heading
,headingProps
, andmobileBreakpoints
props for better accessibility toEuiSideNav
(#4827)Bug fixes
EuiDataGrid
(#4844)Theme: Amsterdam
EuiSideNav
(#4816)34.2.0
text-transform: capitalize
from theEuiTourSteps
title to better fit with Elastic title guidelines (#4839)color
andsize
props and added support for click event toEuiBetaBadge
(#4798)documentation
andlayers
glyphs toEuiIcon
(#4833)EuiTourStep
'stitle
andsubtitle
prop type fromstring
toReactNode
(#4841)euiCantAnimate
Sass mixin (#4835)EuiLoadingLogo
component (#4835)icon
props toEuiEmptyPrompt
for custom icons (#4835)EuiLoadingKibana
(#4835)prefers-reduced-motion
is on for loader components (#4835)Bug fixes
onBlur
anddata-test-subj
prop propagation inEuiColorPicker
(#4822)EuiDataGrid
(#4844)34.1.0
max
andmin
label positioning forEuiRange
andEuiDualRange
(#4781)timeslider
,playFilled
,frameNext
andframePrevious
glyphs toEuiIcon
(#4810)EuiSideNavProps
(#4802)fullHeight
andminHeight
props toEuiPageTemplate
(#4793).eui-fullHeight
andeuiFullHeight()
utilities (#4793)paddingSize
prop toEuiPageSideBar
(#4793)Bug fixes
EuiText
color ofEuiCallout
todefault
(#4816)EuiRange
andEuiDualRange
with custom tick values (#4781)EuiDataGrid
is used together withEuiFlyout
and the user clicks a cell (4813)flex-shrink: 0
toEuiTabs
,EuiSpacer
, andEuiImage
to fix possible shrunken heights (#4793)main
aria roles inEuiPageTemplate
and most commonEuiPage
patterns (#4793)EuiBottomBar
(#4793)34.0.0
textTransform
property toschemaDetectors
prop ofEuiDataGrid
(#4752)color
,continuityAbove
,continuityAboveBelow
,continuityBelow
,continuityWithin
,eraser
,fullScreenExit
,function
,percent
,wordWrap
, andwordWrapDisabled
glyphs toEuiIcon
(#4779)as
,role
,closeButtonProps
,closeButtonPosition
,outsideClickCloses
,side
,type
, andpushMinBreakpoint
props toEuiFlyout
(#4713)EuiFlyout
size
prop to accept any CSSwidth
value (#4713)EuiFlyout
and most of its props inEuiCollapsibleNav
(#4713)helpText
prop inEuiFormRow
to accept an array of messages(#4782)Breaking changes
EuiFlyout
ownFocus
totrue
(#4713)EuiFlyout
within theEuiOverlayMask
whenownFocus=true
(#4713)EuiCollapsibleNav
width sizing from a Sass variable to asize
prop (#4713)EuiOverlayMask
z-indexing when positionedbelow
header to usingtop
offset (#4713)Bug fixes
EuiTourStepIndicator
to useEuiI18n
following the standard way (#4785)euiTourStep.closeTour
default token value inEuiTourStep
to be more specific (#4790)