Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Icon Additions for Upcoming Lens Features #4833

Merged
merged 5 commits into from
May 28, 2021

Conversation

MichaelMarcialis
Copy link
Contributor

@MichaelMarcialis MichaelMarcialis commented May 27, 2021

Summary

Added some more new icons to EUI to support the needs of upcoming Lens features (thresholds, custom formula). This PR includes the following icons:

  • documentation
  • layers

image

Checklist

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4833/

@cchaos
Copy link
Contributor

cchaos commented May 27, 2021

I'm curious why not just use the help life preserver icon for documentation? We use it anywhere we direct users to the docs in Kibana.

@MichaelMarcialis
Copy link
Contributor Author

MichaelMarcialis commented May 27, 2021

I'm curious why not just use the help life preserver icon for documentation? We use it anywhere we direct users to the docs in Kibana.

We've received some user feedback in recent Lens testing that the help icon doesn't translate to the idea of opening/reading documentation in their minds. I tend to agree with that feedback, as a life preserver is likely not an object that is immediately familiar to all users. For Lens' case, the plan would be to use this new documentation icon on buttons that trigger the display of more robust "inline" documentation.

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I would make sure to communicate this out to all the rest of the designers and make sure add them to the Figma library.

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4833/

@MichaelMarcialis MichaelMarcialis merged commit 7516099 into elastic:master May 28, 2021
@MichaelMarcialis MichaelMarcialis deleted the lens-icons branch May 28, 2021 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants