[Security Solution] Alerts details #83963

angorayc · 2020-11-20T18:53:39Z

Summary

https://github.com/elastic/security-team/issues/439

To avoid code conflict, this PR is only to add the content of summary tab for alerts. Further behaviours mentioned in the issue above is not included in this PR.

If go to detections page, clicking on an alert in the table, you should be able to see the summary tab and the content appears.
If clicking on an ordinary event, no summary tab appears.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios

elasticmachine · 2020-11-30T14:53:47Z

Pinging @elastic/kibana-security (Team:Security)

MadameSheema · 2020-12-01T10:52:23Z

When alerts details are opened from a timeline, the hyperlinks does not work.
On the detections page, the rule name not corresponds with the one displayed on the alerts details tab. On the rule details tab looks like we are displaying the description

When creating a rule, you have the option of adding an investigation guide, one we display on alert details on detections page, does not correspond with the one on the rule. I would say that or are the same or we should rename that field.
signal.rule.name is empty on the Alert details tab, but is displayed on the alerts table.

On timeline, when you perform a search that does not return any alert, the details of the previous alert remains opened.

On timeline, when you start to filter, the event details are not wiped out.

...lugins/security_solution/public/timelines/components/timeline/body/events/stateful_event.tsx

...ck/plugins/security_solution/public/timelines/components/timeline/expandable_event/index.tsx

x-pack/plugins/security_solution/public/common/components/event_details/summary_view.tsx

patrykkopycinski · 2020-12-10T22:03:49Z

...k/plugins/security_solution/public/timelines/components/timeline/query_tab_content/index.tsx

@@ -295,6 +321,7 @@ export const QueryTabContentComponent: React.FC<Props> = ({
                className="timeline-flyout-body"
              >
                <StatefulBody
+                  defaultModel={timelineDefaults}


I think you wanted to remove that as well

yeah but if we remove it here, then it couldn't get the right fallback value in x-pack/plugins/security_solution/public/timelines/components/timeline/body/index.tsx Line 215

that happens in cypress test, but seems to be fine in ordinary env.

what is the Cypress error?

it couldn't get the right value of columns or sometime missing showCheckboxes on detections page

x-pack/plugins/security_solution/public/timelines/components/timeline/body/index.tsx

angorayc · 2020-12-11T09:14:23Z

@elasticmachine merge upstream

…ts-details

patrykkopycinski · 2020-12-11T12:36:58Z

@elasticmachine merge upstream

patrykkopycinski

Tested locally and performed code review. Thank you for implementing all the feedback! LGTM

patrykkopycinski · 2020-12-11T23:46:37Z

@elasticmachine merge upstream

…ts-details

kibanamachine · 2020-12-12T04:29:36Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: f167fae

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`securitySolution`	2119	2124	+5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	8.3MB	8.3MB	+21.6KB

Distributable file count

id	before	after	diff
`default`	47129	47889	+760

History

💚 Build #93807 succeeded 77c5235
💔 Build #93804 failed 0a9e904
💚 Build #93785 succeeded 64a9371
💚 Build #93767 succeeded 26191ac
💔 Build #93760 failed 46f944f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* init alert details tab * styles * readMore button * readmore btn * field mappings * add unit tests * unit test * fix unit test * functional test * isolate lineClamp component * review * unit test * fix rule name in events table * originalvalue * unit test * add close event details button * rollback cypress configs * cypress * close events details * remove Ip * review * review * review * review * review * review * review * fix i18n check * fix import * fix eslint * use connect * close flyout when expanded event doesn't exist in the list * Update x-pack/plugins/security_solution/public/timelines/components/timeline/expandable_event/index.tsx Co-authored-by: Patryk Kopyciński <[email protected]> * fix types * unit test * fix rule status badge * isolate host name renderer * fixup * cypress * cypress * defaultModel * review comments * unit test * replace findIndex with some * review * remove defaultModel from toggle event action * review * cleanup defaultModel * unit test * rollback handleClearSelection * fixup * fix i18n * cleanup defaultmodel * cleanup * summary value * fix showing timeline details * layout * fix timeline memoization * fix long query * styling Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Patryk Kopyciński <[email protected]>

* init alert details tab * styles * readMore button * readmore btn * field mappings * add unit tests * unit test * fix unit test * functional test * isolate lineClamp component * review * unit test * fix rule name in events table * originalvalue * unit test * add close event details button * rollback cypress configs * cypress * close events details * remove Ip * review * review * review * review * review * review * review * fix i18n check * fix import * fix eslint * use connect * close flyout when expanded event doesn't exist in the list * Update x-pack/plugins/security_solution/public/timelines/components/timeline/expandable_event/index.tsx Co-authored-by: Patryk Kopyciński <[email protected]> * fix types * unit test * fix rule status badge * isolate host name renderer * fixup * cypress * cypress * defaultModel * review comments * unit test * replace findIndex with some * review * remove defaultModel from toggle event action * review * cleanup defaultModel * unit test * rollback handleClearSelection * fixup * fix i18n * cleanup defaultmodel * cleanup * summary value * fix showing timeline details * layout * fix timeline memoization * fix long query * styling Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Patryk Kopyciński <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Patryk Kopyciński <[email protected]>

* master: (116 commits) Fix UX E2E tests (elastic#85722) Increasing default api key removalDelay to 1h (elastic#85576) align cors settings names with elasticsearch (elastic#85738) unskip tests and make sure submit is not triggered too quickly (elastic#85567) Row trigger 2 (elastic#83167) Add session id to audit log (elastic#85451) [TSVB] Fields lists do not populate all the times (elastic#85530) [Visualize] Removes the external link icon from OSS badges (elastic#85580) fixes EQL tests (elastic#85712) [APM] enable 'log_level' for Go (elastic#85511) ini `1.3.5` -> `1.3.7` (elastic#85707) Fix fleet route protections (elastic#85626) [Monitoring] Some progress on making alerts better in the UI (elastic#81569) [Security Solution] Refactor Timeline Notes to use EuiCommentList (elastic#85256) [Security Solution][Detections][Threshold Rules] Threshold rule exceptions (elastic#85103) [Security Solution] Alerts details (elastic#83963) skip flaky suite (elastic#62060) skip flaky suite (elastic#85098) skip flaky suite (elastic#84020) skip flaky suite (elastic#85671) ...

angorayc added 2 commits November 23, 2020 10:23

init alert details tab

a75a9b8

styles

54d1032

angorayc force-pushed the alerts-details branch from 2e42c46 to 54d1032 Compare November 23, 2020 12:40

angorayc added 7 commits November 24, 2020 17:54

readMore button

e329b91

readmore btn

c9fcf96

field mappings

c65a78c

add unit tests

88faf98

Merge branch 'master' of github.com:elastic/kibana into alerts-details

6ecc525

unit test

441aef9

fix unit test

bb67c96

cnasikas mentioned this pull request Nov 27, 2020

[Security Solution][Case] Alerts comment UI #84450

Merged

8 tasks

angorayc added 2 commits November 30, 2020 09:47

Merge branch 'master' of github.com:elastic/kibana into alerts-details

edf3efb

functional test

5ad64e9

angorayc marked this pull request as ready for review November 30, 2020 14:52

angorayc requested review from a team as code owners November 30, 2020 14:52

angorayc added release_note:enhancement Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! Team:Threat Hunting Security Solution Threat Hunting Team v7.11.0 labels Nov 30, 2020

azasypkin added Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. and removed Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! labels Nov 30, 2020

angorayc added the v8.0.0 label Dec 1, 2020

patrykkopycinski reviewed Dec 1, 2020

View reviewed changes

...lugins/security_solution/public/timelines/components/timeline/body/events/stateful_event.tsx Outdated Show resolved Hide resolved

patrykkopycinski reviewed Dec 1, 2020

View reviewed changes

...ck/plugins/security_solution/public/timelines/components/timeline/expandable_event/index.tsx Outdated Show resolved Hide resolved

patrykkopycinski reviewed Dec 1, 2020

View reviewed changes

...ck/plugins/security_solution/public/timelines/components/timeline/expandable_event/index.tsx Outdated Show resolved Hide resolved

patrykkopycinski reviewed Dec 1, 2020

View reviewed changes

x-pack/plugins/security_solution/public/common/components/event_details/summary_view.tsx Outdated Show resolved Hide resolved

isolate lineClamp component

c323f64

angorayc added 2 commits December 11, 2020 05:32

cleanup defaultModel

f8bd1a4

unit test

10371bc

patrykkopycinski reviewed Dec 10, 2020

View reviewed changes

x-pack/plugins/security_solution/public/timelines/components/timeline/body/index.tsx Outdated Show resolved Hide resolved

rollback handleClearSelection

99b3026

kibanamachine and others added 5 commits December 11, 2020 04:14

Merge branch 'master' into alerts-details

389592f

fixup

e49a362

Merge branch 'alerts-details' of github.com:angorayc/kibana into aler…

46f944f

…ts-details

fix i18n

56a7e52

cleanup defaultmodel

da31fe2

kibanamachine and others added 6 commits December 11, 2020 07:37

Merge branch 'master' into alerts-details

0c2c0d1

cleanup

26191ac

summary value

64a9371

fix showing timeline details

eed7b8b

layout

02ac297

fix timeline memoization

0a9e904

patrykkopycinski approved these changes Dec 11, 2020

View reviewed changes

kibanamachine and others added 4 commits December 11, 2020 18:46

Merge branch 'master' into alerts-details

77c5235

fix long query

b5d1ff1

styling

b7d3843

Merge branch 'alerts-details' of github.com:angorayc/kibana into aler…

f167fae

…ts-details

angorayc merged commit 7b32835 into elastic:master Dec 12, 2020

angorayc mentioned this pull request Dec 12, 2020

[7.x] [Security Solution] Alerts details (#83963) #85710

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution] Alerts details #83963

[Security Solution] Alerts details #83963

angorayc commented Nov 20, 2020 •

edited

Loading

elasticmachine commented Nov 30, 2020

MadameSheema commented Dec 1, 2020 •

edited

Loading

patrykkopycinski Dec 10, 2020

angorayc Dec 10, 2020

angorayc Dec 10, 2020

patrykkopycinski Dec 10, 2020

angorayc Dec 11, 2020

angorayc commented Dec 11, 2020

patrykkopycinski commented Dec 11, 2020

patrykkopycinski left a comment

patrykkopycinski commented Dec 11, 2020

kibanamachine commented Dec 12, 2020

[Security Solution] Alerts details #83963

[Security Solution] Alerts details #83963

Conversation

angorayc commented Nov 20, 2020 • edited Loading

Summary

Checklist

elasticmachine commented Nov 30, 2020

MadameSheema commented Dec 1, 2020 • edited Loading

patrykkopycinski Dec 10, 2020

Choose a reason for hiding this comment

angorayc Dec 10, 2020

Choose a reason for hiding this comment

angorayc Dec 10, 2020

Choose a reason for hiding this comment

patrykkopycinski Dec 10, 2020

Choose a reason for hiding this comment

angorayc Dec 11, 2020

Choose a reason for hiding this comment

angorayc commented Dec 11, 2020

patrykkopycinski commented Dec 11, 2020

patrykkopycinski left a comment

Choose a reason for hiding this comment

patrykkopycinski commented Dec 11, 2020

kibanamachine commented Dec 12, 2020

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Distributable file count

History

angorayc commented Nov 20, 2020 •

edited

Loading

MadameSheema commented Dec 1, 2020 •

edited

Loading