[Security Solution] Refactor Timeline Notes to use EuiCommentList #85256
Conversation
patrykkopycinski
added
release_note:enhancement
v8.0.0
v7.11.0
Team:Threat Hunting
...ck/plugins/security_solution/public/cases/components/timeline_actions/add_to_case_action.tsx
Show resolved
Hide resolved
| export const useTimelineEventsCountPortal = () => { | ||
| const [timelineEventsCountPortalNode] = useState(timelineEventsCountPortalNodeSingleton); | ||
|
|
||
| return { timelineEventsCountPortalNode }; |
There was a problem hiding this comment.
Why don't you return timelineEventsCountPortalNodeSingleton ? What the advantage of using useState here?
There was a problem hiding this comment.
that's a good question @cnasikas
I've just followed the pattern that we're using for other portals
There was a problem hiding this comment.
I see. I am trying to understand it :). timelineEventsCountPortalNodeSingleton is a singleton and after the importation of the file, it will be the same instance across security solution. Theoretically, it shouldn't create rerenders. And I am wondering, is something I do not get with the useState?
…-notes # Conflicts: # x-pack/plugins/security_solution/public/timelines/components/timeline/body/column_headers/index.tsx
…-notes # Conflicts: # x-pack/plugins/security_solution/public/timelines/components/timeline/body/helpers.tsx
There was a problem hiding this comment.
Reviewed code + test locally
I saw that some translations were missing and I integrated the new details event from angela's PR #83963.
I did see some bugs with the json view and also with getting the rule id from the detail data on detections page. I also cleared the notes when creating a new timeline.
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Distributable file count
History
To update your PR or re-run it, just comment with: |
…astic#85256) * [Security Solution] Refactor Timeline Notes to use EuiCommentList * notes * fix types * unit tests * selector * uncomment Pinned tab * note event details * cleanup * cleanup * transparent background * don't display elastic as an owner when note is created * review + bugs fixed found Co-authored-by: Xavier Mouligneau <[email protected]>
…5256) (#85716) * [Security Solution] Refactor Timeline Notes to use EuiCommentList * notes * fix types * unit tests * selector * uncomment Pinned tab * note event details * cleanup * cleanup * transparent background * don't display elastic as an owner when note is created * review + bugs fixed found Co-authored-by: Xavier Mouligneau <[email protected]> Co-authored-by: Patryk Kopyciński <[email protected]>
* master: (116 commits) Fix UX E2E tests (elastic#85722) Increasing default api key removalDelay to 1h (elastic#85576) align cors settings names with elasticsearch (elastic#85738) unskip tests and make sure submit is not triggered too quickly (elastic#85567) Row trigger 2 (elastic#83167) Add session id to audit log (elastic#85451) [TSVB] Fields lists do not populate all the times (elastic#85530) [Visualize] Removes the external link icon from OSS badges (elastic#85580) fixes EQL tests (elastic#85712) [APM] enable 'log_level' for Go (elastic#85511) ini `1.3.5` -> `1.3.7` (elastic#85707) Fix fleet route protections (elastic#85626) [Monitoring] Some progress on making alerts better in the UI (elastic#81569) [Security Solution] Refactor Timeline Notes to use EuiCommentList (elastic#85256) [Security Solution][Detections][Threshold Rules] Threshold rule exceptions (elastic#85103) [Security Solution] Alerts details (elastic#83963) skip flaky suite (elastic#62060) skip flaky suite (elastic#85098) skip flaky suite (elastic#84020) skip flaky suite (elastic#85671) ...
Summary
Event notes
Notes tab:
Checklist
Delete any items that are not applicable to this PR.
For maintainers