Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Case] Alerts comment UI #84450

Merged
merged 17 commits into from
Dec 10, 2020
Merged

[Security Solution][Case] Alerts comment UI #84450

merged 17 commits into from
Dec 10, 2020

Conversation

cnasikas
Copy link
Member

@cnasikas cnasikas commented Nov 27, 2020 •
edited
Loading

Summary

This PR implements the UI for comments of type alerts (alerts attach to case).

Depends on: #83963. When this PR is merged the alerts flyout is gonna show the alert's details tab.

Technical details:

  • Fetch alerts (signals) by using useQueryAlerts
  • Use EventDetailsFlyout to display alert's details.
  • Use useSourcererScope. Signal index is needed by useQueryAlerts and b) browserFields, and docValueFields is needed by EventDetailsFlyout. All of them are provided by useSourcererScope.
  • Create getAlertComment helper function to create EuiComment of type alert.

Use case:

1

Deleted alert:

Screenshot 2020-12-09 at 1 14 02 PM

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@cnasikas cnasikas added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Feature:Cases Cases feature labels Nov 27, 2020
@cnasikas cnasikas self-assigned this Nov 27, 2020
@cnasikas cnasikas marked this pull request as ready for review December 5, 2020 14:16
@cnasikas cnasikas requested review from a team as code owners December 5, 2020 14:16
@cnasikas cnasikas force-pushed the case_alerts_ui branch 2 times, most recently from 5acddac to 8d32d88 Compare December 7, 2020 16:28
@cnasikas
Copy link
Member Author

cnasikas commented Dec 9, 2020

@elasticmachine merge upstream

@XavierM
Copy link
Contributor

XavierM commented Dec 9, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

expected head sha didn’t match current head ref.

@XavierM
Copy link
Contributor

XavierM commented Dec 9, 2020

I found a good bug here, if you open an alert in Case like this: ->
image

and then you open the timeline, this detail view appear in timeline too.
image

@XavierM
Copy link
Contributor

XavierM commented Dec 10, 2020

I found a good bug here, if you open an alert in Case like this: ->
image

and then you open the timeline, this detail view appear in timeline too.
image

I fixed it with this commit -> 31054b9

XavierM
XavierM approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@XavierM XavierM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to verify might last commit but it seems to do the job.

Good job and let's move forward!!!

@cnasikas
Copy link
Member Author

Make sure to verify might last commit but it seems to do the job.

Good job and let's move forward!!!

Thank you so much! I tested and it works correctly!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 2116 2119 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 8.2MB 8.3MB +9.4KB

Distributable file count

id before after diff
default 46991 47751 +760

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 210.8KB 213.8KB +3.0KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cnasikas cnasikas merged commit a740a3f into elastic:master Dec 10, 2020
@cnasikas cnasikas deleted the case_alerts_ui branch December 10, 2020 14:17
@cnasikas cnasikas mentioned this pull request Dec 10, 2020
Merged
cnasikas added a commit to cnasikas/kibana that referenced this pull request Dec 10, 2020
@cnasikas @kibanamachine @XavierM
[Security Solution][Case] Alerts comment UI (elastic#84450)
267ca1f 
Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Xavier Mouligneau <[email protected]>
cnasikas added a commit that referenced this pull request Dec 10, 2020
@cnasikas @kibanamachine @XavierM
[Security Solution][Case] Alerts comment UI (#84450) (#85571)
d8f2684 
Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Xavier Mouligneau <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Xavier Mouligneau <[email protected]>
@jmikell821 jmikell821 mentioned this pull request Jan 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XavierM XavierM XavierM approved these changes

Assignees

@cnasikas cnasikas

Labels
Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cnasikas @XavierM @kibanamachine