[Security Solution] Alerts details (elastic#83963)

* init alert details tab * styles * readMore button * readmore btn * field mappings * add unit tests * unit test * fix unit test * functional test * isolate lineClamp component * review * unit test * fix rule name in events table * originalvalue * unit test * add close event details button * rollback cypress configs * cypress * close events details * remove Ip * review * review * review * review * review * review * review * fix i18n check * fix import * fix eslint * use connect * close flyout when expanded event doesn't exist in the list * Update x-pack/plugins/security_solution/public/timelines/components/timeline/expandable_event/index.tsx Co-authored-by: Patryk Kopyciński <[email protected]> * fix types * unit test * fix rule status badge * isolate host name renderer * fixup * cypress * cypress * defaultModel * review comments * unit test * replace findIndex with some * review * remove defaultModel from toggle event action * review * cleanup defaultModel * unit test * rollback handleClearSelection * fixup * fix i18n * cleanup defaultmodel * cleanup * summary value * fix showing timeline details * layout * fix timeline memoization * fix long query * styling Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Patryk Kopyciński <[email protected]>
angorayc · Dec 12, 2020 · 1399c47 · 1399c47
1 parent ac49c78
commit 1399c47
Show file tree

Hide file tree

Showing 49 changed files with 1,617 additions and 176 deletions.
diff --git a/x-pack/plugins/security_solution/common/search_strategy/timeline/events/details/index.ts b/x-pack/plugins/security_solution/common/search_strategy/timeline/events/details/index.ts
@@ -9,6 +9,7 @@ import { Inspect, Maybe } from '../../../common';
 import { TimelineRequestOptionsPaginated } from '../..';
 
 export interface TimelineEventsDetailsItem {
+  category?: string;
   field: string;
   values?: Maybe<string[]>;
   // eslint-disable-next-line @typescript-eslint/no-explicit-any

diff --git a/x-pack/plugins/security_solution/common/types/timeline/index.ts b/x-pack/plugins/security_solution/common/types/timeline/index.ts
@@ -411,7 +411,6 @@ export type TimelineEventsType = 'all' | 'raw' | 'alert' | 'signal' | 'custom';
 export interface TimelineExpandedEventType {
   eventId: string;
   indexName: string;
-  loading: boolean;
 }
 
 // eslint-disable-next-line @typescript-eslint/no-explicit-any

diff --git a/x-pack/plugins/security_solution/cypress/integration/alerts_timeline.spec.ts b/x-pack/plugins/security_solution/cypress/integration/alerts_timeline.spec.ts
@@ -4,14 +4,9 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-import { ALERT_ID } from '../screens/alerts';
 import { PROVIDER_BADGE } from '../screens/timeline';
 
-import {
-  expandFirstAlert,
-  investigateFirstAlertInTimeline,
-  waitForAlertsPanelToBeLoaded,
-} from '../tasks/alerts';
+import { investigateFirstAlertInTimeline, waitForAlertsPanelToBeLoaded } from '../tasks/alerts';
 import { esArchiverLoad, esArchiverUnload } from '../tasks/es_archiver';
 import { loginAndWaitForPage } from '../tasks/login';
 
@@ -29,13 +24,13 @@ describe('Alerts timeline', () => {
 
   it('Investigate alert in default timeline', () => {
     waitForAlertsPanelToBeLoaded();
-    expandFirstAlert();
-    cy.get(ALERT_ID)
+    investigateFirstAlertInTimeline();
+    cy.get(PROVIDER_BADGE)
       .first()
       .invoke('text')
       .then((eventId) => {
         investigateFirstAlertInTimeline();
-        cy.get(PROVIDER_BADGE).filter(':visible').should('have.text', `_id: "${eventId}"`);
+        cy.get(PROVIDER_BADGE).filter(':visible').should('have.text', eventId);
       });
   });
 });
diff --git a/x-pack/plugins/security_solution/public/cases/components/case_view/index.tsx b/x-pack/plugins/security_solution/public/cases/components/case_view/index.tsx
@@ -352,7 +352,6 @@ export const CaseComponent = React.memo<CaseProps>(
             event: {
               eventId: alertId,
               indexName: index,
-              loading: false,
             },
           })
         );